)]}'
{"src/openvpn/win32-util.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a88c4e9a129634a83368d0b0323483eb2c4925b3","unresolved":true,"context_lines":[{"line_number":179,"context_line":"win_path_in_dir(const WCHAR *path, const WCHAR *dir)"},{"line_number":180,"context_line":"{"},{"line_number":181,"context_line":"    size_t dir_len \u003d wcslen(dir);"},{"line_number":182,"context_line":"    if (dir_len \u003d\u003d 0 || wcsnicmp(dir, path, dir_len) !\u003d 0)"},{"line_number":183,"context_line":"    {"},{"line_number":184,"context_line":"        return false;"},{"line_number":185,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d02afeba_81f8d36e","line":182,"updated":"2026-06-27 10:36:45.000000000","message":"I think since you are doing dir_len -1 below you should maybe change the dir_len check to be \u003c\u003d 1","commit_id":"e0ba79507431a8c970b721cd1413d32c64c15415"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"d00be6a35ad3bd73465c0a227117d268f4e79694","unresolved":false,"context_lines":[{"line_number":179,"context_line":"win_path_in_dir(const WCHAR *path, const WCHAR *dir)"},{"line_number":180,"context_line":"{"},{"line_number":181,"context_line":"    size_t dir_len \u003d wcslen(dir);"},{"line_number":182,"context_line":"    if (dir_len \u003d\u003d 0 || wcsnicmp(dir, path, dir_len) !\u003d 0)"},{"line_number":183,"context_line":"    {"},{"line_number":184,"context_line":"        return false;"},{"line_number":185,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"eceaf529_9076a5c9","line":182,"in_reply_to":"d02afeba_81f8d36e","updated":"2026-06-29 12:27:00.000000000","message":"dir \u003c\u003d 1 should not happen - we pass normalized dir - but I can fix it anyway.","commit_id":"e0ba79507431a8c970b721cd1413d32c64c15415"}],"tests/unit_tests/openvpn/test_misc.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ace09c35eed4dce2225eded54eb162b066df34df","unresolved":true,"context_lines":[{"line_number":489,"context_line":"                                         cmocka_unit_test(test_auth_fail_temp_flags_msg),"},{"line_number":490,"context_line":"                                         cmocka_unit_test(test_list),"},{"line_number":491,"context_line":"                                         cmocka_unit_test(test_atoi_variants) };"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"int"},{"line_number":494,"context_line":"main(void)"},{"line_number":495,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d7d50c28_3bb0579b","line":492,"updated":"2026-06-29 08:40:17.000000000","message":"this upsets clang-format, alas - if you move towards an empty opening brace (`... \u003d {`), clang-formwat wants the rest with 4 character indents, like for a normal function body.\n\nI could fix that on the fly, but since Arne has other comments, please do this as well.","commit_id":"e0ba79507431a8c970b721cd1413d32c64c15415"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"d00be6a35ad3bd73465c0a227117d268f4e79694","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                         cmocka_unit_test(test_auth_fail_temp_flags_msg),"},{"line_number":490,"context_line":"                                         cmocka_unit_test(test_list),"},{"line_number":491,"context_line":"                                         cmocka_unit_test(test_atoi_variants) };"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"int"},{"line_number":494,"context_line":"main(void)"},{"line_number":495,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3b37e912_e2c5249b","line":492,"in_reply_to":"d7d50c28_3bb0579b","updated":"2026-06-29 12:27:00.000000000","message":"will fix.","commit_id":"e0ba79507431a8c970b721cd1413d32c64c15415"}]}
