)]}'
{"id":"openvpn~1738","triplet_id":"openvpn~master~I46a9ef71359f42395d69cf899c948014fb72f65a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-09-25 21:56:11.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-25 21:56:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I46a9ef71359f42395d69cf899c948014fb72f65a","subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard","status":"MERGED","created":"2026-06-29 00:36:00.000000000","updated":"2026-09-25 21:56:11.000000000","submitted":"2026-09-25 21:56:11.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1738","meta_rev_id":"037c179edaf4a2c223f4c9bd1160fe4ec80c0972","_number":1738,"virtual_id_number":1738,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 00:36:01.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 00:36:01.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-25 13:14:42.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"83cc8da82edc142e1e51f58a6fe60d9c0e367249","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-06-29 00:36:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d14e9a259af7ed7e055195446a4b7f8ba8b7775a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-25 12:37:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dcb30982c2b11981132834f8614bb9539471ce55","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-25 13:05:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2b67a4ad38207a7abc5fabd314fd4cf76de34e4d","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-25 13:14:42.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"037c179edaf4a2c223f4c9bd1160fe4ec80c0972","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-25 21:56:11.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e6670b335b99bed5810cf2d0465279e208d14462","revisions":{"6fc9258c4765a02f21fb47063fed4cace474f606":{"kind":"REWORK","_number":1,"created":"2026-06-29 00:36:00.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/38/1738/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/1738/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/1 \u0026\u0026 git checkout -b change-1738 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/38/1738/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"faaea4c811c3bc93b2121a96b2a4aef893259467","subject":"dco_linux: read multicast notifications on a dedicated netlink socket"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-06-29 00:31:37.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-06-29 00:34:32.000000000","tz":120},"subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard","message":"dco_linux: drop the now-redundant __is_locked re-entrancy guard\n\n__is_locked existed only to stop setenv_stats() from issuing a GET_PEER\nrequest/reply while the shared socket was still being drained for a batch\nof notifications, which could fail with NLE_BUSY/NLE_NOMEM or re-enter\nnl_recvmsgs() on the busy socket. Now that notifications are read on a\ndedicated socket and GET_PEER goes to the request/reply socket, the two\nnever share an nl_recvmsgs() call: the request/reply socket no longer\ndispatches notifications, so multi_process_incoming_dco() (the only path\nthat reaches dco_get_peer() during message parsing) never runs while that\nsocket is in flight, and the flag is always false at its check. Remove\nthe flag, its set/clear and the early return.\n\nChange-Id: I46a9ef71359f42395d69cf899c948014fb72f65a\nSigned-off-by: Antonio Quartulli \u003cantonio.quartulli@openvpn.com\u003e\n"},"branch":"refs/heads/master"},"694e3b11c0e339919efd77ed7a8fe93346bfc21c":{"kind":"REWORK","_number":2,"created":"2026-09-25 12:37:42.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/38/1738/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/1738/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/2 \u0026\u0026 git checkout -b change-1738 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/38/1738/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e93012164d7ab0476efc41aa8bfe034b40bbdb7c","subject":"multi: make multi_add_mbuf static"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-25 12:37:11.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-25 12:37:11.000000000","tz":120},"subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard","message":"dco_linux: drop the now-redundant __is_locked re-entrancy guard\n\n__is_locked existed only to stop setenv_stats() from issuing a GET_PEER\nrequest/reply while the shared socket was still being drained for a batch\nof notifications, which could fail with NLE_BUSY/NLE_NOMEM or re-enter\nnl_recvmsgs() on the busy socket. Now that notifications are read on a\ndedicated socket and GET_PEER goes to the request/reply socket, the two\nnever share an nl_recvmsgs() call: the request/reply socket no longer\ndispatches notifications, so multi_process_incoming_dco() (the only path\nthat reaches dco_get_peer() during message parsing) never runs while that\nsocket is in flight, and the flag is always false at its check. Remove\nthe flag, its set/clear and the early return.\n\nChange-Id: I46a9ef71359f42395d69cf899c948014fb72f65a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"235e8730afd06d8b6cd75d8422c2e64089d5ffbe":{"kind":"REWORK","_number":3,"created":"2026-09-25 13:05:10.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/38/1738/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/1738/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/3 \u0026\u0026 git checkout -b change-1738 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/38/1738/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23cbacde0afc425938af3171111cdefde5651c62","subject":"dco_linux: read multicast notifications on a dedicated netlink socket"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-25 12:37:11.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-25 13:05:00.000000000","tz":120},"subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard","message":"dco_linux: drop the now-redundant __is_locked re-entrancy guard\n\n__is_locked existed only to stop setenv_stats() from issuing a GET_PEER\nrequest/reply while the shared socket was still being drained for a batch\nof notifications, which could fail with NLE_BUSY/NLE_NOMEM or re-enter\nnl_recvmsgs() on the busy socket. Now that notifications are read on a\ndedicated socket and GET_PEER goes to the request/reply socket, the two\nnever share an nl_recvmsgs() call: the request/reply socket no longer\ndispatches notifications, so multi_process_incoming_dco() (the only path\nthat reaches dco_get_peer() during message parsing) never runs while that\nsocket is in flight, and the flag is always false at its check. Remove\nthe flag, its set/clear and the early return.\n\nChange-Id: I46a9ef71359f42395d69cf899c948014fb72f65a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"e6670b335b99bed5810cf2d0465279e208d14462":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-09-25 21:56:11.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/38/1738/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/1738/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/4 \u0026\u0026 git checkout -b change-1738 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/38/1738/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/1738/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"08407e0d3c45ab889e6ff4252fc40d778acca149","subject":"dco_linux: read multicast notifications on a dedicated netlink socket"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-25 13:18:24.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-25 16:15:14.000000000","tz":120},"subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard","message":"dco_linux: drop the now-redundant __is_locked re-entrancy guard\n\n__is_locked existed only to stop setenv_stats() from issuing a GET_PEER\nrequest/reply while the shared socket was still being drained for a batch\nof notifications, which could fail with NLE_BUSY/NLE_NOMEM or re-enter\nnl_recvmsgs() on the busy socket. Now that notifications are read on a\ndedicated socket and GET_PEER goes to the request/reply socket, the two\nnever share an nl_recvmsgs() call: the request/reply socket no longer\ndispatches notifications, so multi_process_incoming_dco() (the only path\nthat reaches dco_get_peer() during message parsing) never runs while that\nsocket is in flight, and the flag is always false at its check. Remove\nthe flag, its set/clear and the early return.\n\nChange-Id: I46a9ef71359f42395d69cf899c948014fb72f65a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1738\nMessage-Id: \u003c20260925131830.10902-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39499.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}