)]}'
{"id":"openvpn~1739","triplet_id":"openvpn~master~Icc14b286f2409738c73873aa7550dcc005ee8cbb","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-07-13 15:54:21.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-13 15:54:21.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Icc14b286f2409738c73873aa7550dcc005ee8cbb","subject":"CMake: detect cmocka_version.h via include path, not by linking","status":"MERGED","created":"2026-06-29 07:58:31.000000000","updated":"2026-07-13 15:54:21.000000000","submitted":"2026-07-13 15:54:21.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1739","meta_rev_id":"e4120d3efb93022c27bec8b6281324f7ca0503cf","_number":1739,"virtual_id_number":1739,"owner":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 07:58:35.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 07:58:35.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-07-08 15:38:00.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"31dedd7ad75b40d3e885d256101ab6b2242823ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 07:58:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1f7bc9aa47f65b77acce909e79571ce7cea1226","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-08 15:38:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"852315fe8aa6e6e6fee11e0490f523644fed372d","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-09 14:42:53.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"e4120d3efb93022c27bec8b6281324f7ca0503cf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-13 15:54:21.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2c2fec4a965cf046b3d71b3250f8d84f6af81b89","revisions":{"db8e018e3ee3b6932911b2ca65d7eeffb6609e80":{"kind":"REWORK","_number":1,"created":"2026-06-29 07:58:31.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/39/1739/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/39/1739/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/1 \u0026\u0026 git checkout -b change-1739 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/39/1739/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"294d5ebb32e632c756290cb7b1de3df29a516154","subject":"openvpnserv: rework ConvertItfDnsDomains and tests"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-17 07:26:43.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 07:58:02.000000000","tz":180},"subject":"CMake: detect cmocka_version.h via include path, not by linking","message":"CMake: detect cmocka_version.h via include path, not by linking\n\ncheck_include_files() was invoked with cmocka in CMAKE_REQUIRED_LIBRARIES,\nwhich makes the probe link the (shared, imported) cmocka library. On some\nplatforms that link step fails inside the minimal probe, so the header check\nreports failure and HAVE_CMOCKA_VERSION_H is left undefined even though\ncmocka_version.h is present.\n\ntest_common.h then selects its cmocka 1.x compatibility shims and redefines\nmacros (check_expected_uint, expect_uint_value, ...) that cmocka 2.x already\nprovides, which breaks the -Werror build of every unit test driver.\n\nDetecting a header only needs the include search path, so pass cmocka\u0027s\nINTERFACE_INCLUDE_DIRECTORIES via CMAKE_REQUIRED_INCLUDES and drop the library\nlink requirement from the probe.\n\nChange-Id: Icc14b286f2409738c73873aa7550dcc005ee8cbb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"2c2fec4a965cf046b3d71b3250f8d84f6af81b89":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-07-13 15:54:21.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/39/1739/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/39/1739/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/2 \u0026\u0026 git checkout -b change-1739 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/39/1739/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/39/1739/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d41472de0144f3c483a8397dea3bb55f00dc57e4","subject":"ssl_pkt: Fix doxygen warning about read_control_auth"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-07-09 14:42:40.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-07-13 15:52:04.000000000","tz":120},"subject":"CMake: detect cmocka_version.h via include path, not by linking","message":"CMake: detect cmocka_version.h via include path, not by linking\n\ncheck_include_files() was invoked with cmocka in CMAKE_REQUIRED_LIBRARIES,\nwhich makes the probe link the (shared, imported) cmocka library. On some\nplatforms that link step fails inside the minimal probe, so the header check\nreports failure and HAVE_CMOCKA_VERSION_H is left undefined even though\ncmocka_version.h is present.\n\ntest_common.h then selects its cmocka 1.x compatibility shims and redefines\nmacros (check_expected_uint, expect_uint_value, ...) that cmocka 2.x already\nprovides, which breaks the -Werror build of every unit test driver.\n\nDetecting a header only needs the include search path, so pass cmocka\u0027s\nINTERFACE_INCLUDE_DIRECTORIES via CMAKE_REQUIRED_INCLUDES and drop the library\nlink requirement from the probe.\n\nChange-Id: Icc14b286f2409738c73873aa7550dcc005ee8cbb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1739\nMessage-Id: \u003c20260709144240.61362-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37552.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
