)]}'
{"id":"openvpn~1741","triplet_id":"openvpn~master~I1c8d302ac57c5603d622a7be14be369437388268","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-29 07:58:36.000000000","reason":"Reviewer was added"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-07-02 12:30:33.000000000","reason":"Vote got outdated and was removed: Code-Review-1"}},"removed_from_attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-07-02 12:31:22.000000000","reason":"\u003cGERRIT_ACCOUNT_1000008\u003e replied on the change","reason_account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}}},"hashtags":[],"change_id":"I1c8d302ac57c5603d622a7be14be369437388268","subject":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)","status":"NEW","created":"2026-06-29 07:58:31.000000000","updated":"2026-07-02 12:31:22.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1e85739400d6f6d1a9e98dfb4004520cd126e2f0","_number":1741,"virtual_id_number":1741,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 07:58:36.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 07:58:36.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-06-30 11:59:32.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"fa8ebd27a6df4eddf07d3d2b74f3bcca4bf5120a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 07:58:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"14b230cd8593bbee5d1e5c7e6abdab275a96331d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 12:37:47.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"aaf9452cdd9a3c6ddb4cbd70092d6586b96c458e","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-30 11:59:32.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8428b0ec3dc10add58fffb0f8eefe302f738a5b9","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-30 12:02:11.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b4872dc5819410ac50d3a0301e5a8a7b19000609","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-07-02 12:30:33.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"1e85739400d6f6d1a9e98dfb4004520cd126e2f0","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-07-02 12:31:22.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"493aec58151150b86fbdc1665e116706b34dcfcf","revisions":{"2ff2cd48f827716f0eb8e58c4396eec027284068":{"kind":"REWORK","_number":1,"created":"2026-06-29 07:58:31.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/41/1741/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1741/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/1 \u0026\u0026 git checkout -b change-1741 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1741/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c1d09e3bb0b5db506178a6d091fc08dc8a456ee","subject":"buffer: Add buf_read_u64() and buf_write_u64()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-17 07:09:23.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 07:58:02.000000000","tz":180},"subject":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)","message":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)\n\nReserve opcode 12 (P_CONTROL_OOB_V1) for out-of-band control messages and\nadd encoding/decoding for the SERVER_PROBE / PROBE_REPLY TLVs used for\nserver latency checks:\n\n  - probe_parameter (0x200): client timestamp + capability flags\n  - probe_reply    (0x201): echoed session id, DNS-SRV style priority and\n                            weight, connect_lifetime and behaviour flags\n\nEach TLV has a 4-byte header (15-bit type plus an optional flag, then a\n16-bit value length). Readers enforce the minimum value length and skip\ntrailing bytes they do not understand, so the format stays forward\ncompatible and multi-TLV framing resynchronises.\n\nP_LAST_OPCODE is deliberately left at 11: opcode 12 is not yet accepted by\ntls_pre_decrypt(). The legal-opcode range is widened together with the\nreceive handler in a follow-up, which also wires oob.c into the openvpn\nbuild. For now the codec is exercised only by the unit tests.\n\nSee the OOB control message section of the OpenVPN wire protocol\nspecification (openvpn-rfc PR #30).\n\nChange-Id: I1c8d302ac57c5603d622a7be14be369437388268\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"e268a6167a01da9be34af5193ec5ba8a5c093e82":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-29 12:37:47.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/41/1741/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1741/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/2 \u0026\u0026 git checkout -b change-1741 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1741/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"837260c57e6dee5b2eb106534d12f05f3e7dbbc0","subject":"buffer: Add buf_read_u64() and buf_write_u64()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-17 07:09:23.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 12:32:06.000000000","tz":180},"subject":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)","message":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)\n\nReserve opcode 12 (P_CONTROL_OOB_V1) for out-of-band control messages and\nadd encoding/decoding for the SERVER_PROBE / PROBE_REPLY TLVs used for\nserver latency checks:\n\n  - probe_parameter (0x200): client timestamp + capability flags\n  - probe_reply    (0x201): echoed session id, DNS-SRV style priority and\n                            weight, connect_lifetime and behaviour flags\n\nEach TLV has a 4-byte header (15-bit type plus an optional flag, then a\n16-bit value length). Readers enforce the minimum value length and skip\ntrailing bytes they do not understand, so the format stays forward\ncompatible and multi-TLV framing resynchronises.\n\nP_LAST_OPCODE is deliberately left at 11: opcode 12 is not yet accepted by\ntls_pre_decrypt(). The legal-opcode range is widened together with the\nreceive handler in a follow-up, which also wires oob.c into the openvpn\nbuild. For now the codec is exercised only by the unit tests.\n\nSee the OOB control message section of the OpenVPN wire protocol\nspecification (openvpn-rfc PR #30).\n\nChange-Id: I1c8d302ac57c5603d622a7be14be369437388268\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"493aec58151150b86fbdc1665e116706b34dcfcf":{"kind":"REWORK","_number":3,"created":"2026-07-02 12:30:33.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/41/1741/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1741/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/3 \u0026\u0026 git checkout -b change-1741 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1741/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1741/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"837260c57e6dee5b2eb106534d12f05f3e7dbbc0","subject":"buffer: Add buf_read_u64() and buf_write_u64()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-17 07:09:23.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-07-02 12:07:42.000000000","tz":180},"subject":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)","message":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)\n\nReserve opcode 12 (P_CONTROL_OOB_V1) for out-of-band control messages and\nadd encoding/decoding for the SERVER_PROBE / PROBE_REPLY TLVs used for\nserver latency checks:\n\n  - probe_parameter (0x200): client timestamp + capability flags\n  - probe_reply    (0x201): echoed session id, DNS-SRV style priority and\n                            weight, connect_lifetime and behaviour flags\n\nEach TLV has a 4-byte header (15-bit type plus an optional flag, then a\n16-bit value length). Readers enforce the minimum value length and skip\ntrailing bytes they do not understand, so the format stays forward\ncompatible and multi-TLV framing resynchronises.\n\nP_LAST_OPCODE is deliberately left at 11: opcode 12 is not yet accepted by\ntls_pre_decrypt(). The legal-opcode range is widened together with the\nreceive handler in a follow-up, which also wires oob.c into the openvpn\nbuild. For now the codec is exercised only by the unit tests.\n\nSee the OOB control message section of the OpenVPN wire protocol\nspecification (openvpn-rfc PR #30).\n\nChange-Id: I1c8d302ac57c5603d622a7be14be369437388268\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}