)]}'
{"id":"openvpn~1742","triplet_id":"openvpn~master~Iafa9efc1c156974ad9f5752e9de810a8c2f68c30","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-29 07:58:36.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Iafa9efc1c156974ad9f5752e9de810a8c2f68c30","subject":"oob: Add SERVER_PROBE parsing and the probe-reply decision","status":"NEW","created":"2026-06-29 07:58:31.000000000","updated":"2026-07-02 12:30:33.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b622d384d2800ca5058070d12738a3d412472b51","_number":1742,"virtual_id_number":1742,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 07:58:36.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 07:58:36.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"ebc9830d622adef58d7a9c967e1b88f608491877","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 07:58:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"112e36d165db15c361709a49d5c15a7d343dd63a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 12:37:47.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"b622d384d2800ca5058070d12738a3d412472b51","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-07-02 12:30:33.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1677f0129d972112fb253c172e8802b595135e3d","revisions":{"caefe6c905a8f9a6fecf18b0301daa8fdc444f51":{"kind":"REWORK","_number":1,"created":"2026-06-29 07:58:31.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/42/1742/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/1742/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/1 \u0026\u0026 git checkout -b change-1742 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/1742/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2ff2cd48f827716f0eb8e58c4396eec027284068","subject":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-18 12:15:00.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 07:58:02.000000000","tz":180},"subject":"oob: Add SERVER_PROBE parsing and the probe-reply decision","message":"oob: Add SERVER_PROBE parsing and the probe-reply decision\n\nAdd the message-level helpers the server needs to answer a probe:\n\n  - oob_server_probe_read() scans the TLV payload of a received OOB\n    SERVER_PROBE for the probe_parameter TLV, skipping other/future TLV\n    types and rejecting malformed or truncated input.\n  - oob_timestamp_in_window() performs the cheap replay/skew check on the\n    probe timestamp described in the wire protocol specification.\n  - oob_build_probe_reply() composes the two: given a received SERVER_PROBE\n    it scans for the probe_parameter, drops the probe if it is missing or\n    its timestamp is outside the acceptable window, and otherwise populates\n    the probe_reply (echoing the peer\u0027s session id) to send back.\n\nThese are pure functions exercised by unit tests; the server packet path\ncalls oob_build_probe_reply() in a follow-up, which performs the actual send.\n\nChange-Id: Iafa9efc1c156974ad9f5752e9de810a8c2f68c30\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"bbae0fe83a7a0a59e3084f917241cc5ab30a2576":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-29 12:37:47.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/42/1742/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/1742/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/2 \u0026\u0026 git checkout -b change-1742 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/1742/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e268a6167a01da9be34af5193ec5ba8a5c093e82","subject":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-18 12:15:00.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 12:32:06.000000000","tz":180},"subject":"oob: Add SERVER_PROBE parsing and the probe-reply decision","message":"oob: Add SERVER_PROBE parsing and the probe-reply decision\n\nAdd the message-level helpers the server needs to answer a probe:\n\n  - oob_server_probe_read() scans the TLV payload of a received OOB\n    SERVER_PROBE for the probe_parameter TLV, skipping other/future TLV\n    types and rejecting malformed or truncated input.\n  - oob_timestamp_in_window() performs the cheap replay/skew check on the\n    probe timestamp described in the wire protocol specification.\n  - oob_build_probe_reply() composes the two: given a received SERVER_PROBE\n    it scans for the probe_parameter, drops the probe if it is missing or\n    its timestamp is outside the acceptable window, and otherwise populates\n    the probe_reply (echoing the peer\u0027s session id) to send back.\n\nThese are pure functions exercised by unit tests; the server packet path\ncalls oob_build_probe_reply() in a follow-up, which performs the actual send.\n\nChange-Id: Iafa9efc1c156974ad9f5752e9de810a8c2f68c30\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"1677f0129d972112fb253c172e8802b595135e3d":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-07-02 12:30:33.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/42/1742/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/1742/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/3 \u0026\u0026 git checkout -b change-1742 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/1742/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1742/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"493aec58151150b86fbdc1665e116706b34dcfcf","subject":"oob: Add control message TLV encoding (P_CONTROL_OOB_V1)"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-18 12:15:00.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-07-02 12:07:42.000000000","tz":180},"subject":"oob: Add SERVER_PROBE parsing and the probe-reply decision","message":"oob: Add SERVER_PROBE parsing and the probe-reply decision\n\nAdd the message-level helpers the server needs to answer a probe:\n\n  - oob_server_probe_read() scans the TLV payload of a received OOB\n    SERVER_PROBE for the probe_parameter TLV, skipping other/future TLV\n    types and rejecting malformed or truncated input.\n  - oob_timestamp_in_window() performs the cheap replay/skew check on the\n    probe timestamp described in the wire protocol specification.\n  - oob_build_probe_reply() composes the two: given a received SERVER_PROBE\n    it scans for the probe_parameter, drops the probe if it is missing or\n    its timestamp is outside the acceptable window, and otherwise populates\n    the probe_reply (echoing the peer\u0027s session id) to send back.\n\nThese are pure functions exercised by unit tests; the server packet path\ncalls oob_build_probe_reply() in a follow-up, which performs the actual send.\n\nChange-Id: Iafa9efc1c156974ad9f5752e9de810a8c2f68c30\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}