)]}'
{"id":"openvpn~1748","triplet_id":"openvpn~master~I375a41749060b7d006647bc27002c55436c8a8bb","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-29 07:58:38.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I375a41749060b7d006647bc27002c55436c8a8bb","subject":"oob: Measure probe RTT for candidate-band selection","status":"NEW","created":"2026-06-29 07:58:31.000000000","updated":"2026-07-02 12:30:33.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"980db3c4eb6d52fab935909e427b1fd871946900","_number":1748,"virtual_id_number":1748,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 07:58:38.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 07:58:38.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"ac0e4d5942a666390d227f038ea6cc3342aefce9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 07:58:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0cb057276636d400b5eef01eb75d54c349c4b65b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 12:08:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"d805f325d209283cbd304888be1314340041530d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 12:37:47.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"980db3c4eb6d52fab935909e427b1fd871946900","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-07-02 12:30:33.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"ec8570f762f19242f95856f2a20789a97e3ca227","revisions":{"e56c7d39e606b11b39bb35fc225c5091e99f8917":{"kind":"REWORK","_number":1,"created":"2026-06-29 07:58:31.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/48/1748/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1748/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/1 \u0026\u0026 git checkout -b change-1748 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1748/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"577a0d1d7afdf2b6f17f2595c5b72401dc6fb5d2","subject":"oob: Add --server-probe to order client remotes by probe"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-22 08:47:55.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 07:58:03.000000000","tz":180},"subject":"oob: Measure probe RTT for candidate-band selection","message":"oob: Measure probe RTT for candidate-band selection\n\nRecord each probe\u0027s round-trip time (per-target send timestamp vs reply\narrival) and feed it to oob_rank_probe_results(), where RTT forms the\ncandidate band: responders within the effective margin of the fastest compete\non weight, slower ones fall behind. Log the measured RTT and the effective\nmargin (with its source: client / server-advertised / default) at verb 4.\n\nBefore this the client never measured RTT, so every responder sat in the band\nand selection was purely weighted-random; with real measurements the\nlatency-based candidate selection takes effect.\n\nChange-Id: I375a41749060b7d006647bc27002c55436c8a8bb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"136ac8eb135ca56b0f1e7d30ce955dc627a1f5f6":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-29 12:08:26.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/48/1748/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1748/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/2 \u0026\u0026 git checkout -b change-1748 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1748/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8056a449f5a2a25c9a9c8ef191a3648a40177b0d","subject":"oob: Add --server-probe to order client remotes by probe"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-22 08:47:55.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 11:45:13.000000000","tz":180},"subject":"oob: Measure probe RTT for candidate-band selection","message":"oob: Measure probe RTT for candidate-band selection\n\nRecord each probe\u0027s round-trip time (per-target send timestamp vs reply\narrival) and feed it to oob_rank_probe_results(), where RTT forms the\ncandidate band: responders within the effective margin of the fastest compete\non weight, slower ones fall behind. Log the measured RTT and the effective\nmargin (with its source: client / server-advertised / default) at verb 4.\n\nBefore this the client never measured RTT, so every responder sat in the band\nand selection was purely weighted-random; with real measurements the\nlatency-based candidate selection takes effect.\n\nChange-Id: I375a41749060b7d006647bc27002c55436c8a8bb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"8dfb48f684b4e87cabe86639fa81a83895297f4f":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-06-29 12:37:47.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/48/1748/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1748/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/3 \u0026\u0026 git checkout -b change-1748 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1748/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"412d78bef9b38f9b5cdfc7b10cce2d6c85c0fbda","subject":"oob: Add --server-probe to order client remotes by probe"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-22 08:47:55.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 12:32:06.000000000","tz":180},"subject":"oob: Measure probe RTT for candidate-band selection","message":"oob: Measure probe RTT for candidate-band selection\n\nRecord each probe\u0027s round-trip time (per-target send timestamp vs reply\narrival) and feed it to oob_rank_probe_results(), where RTT forms the\ncandidate band: responders within the effective margin of the fastest compete\non weight, slower ones fall behind. Log the measured RTT and the effective\nmargin (with its source: client / server-advertised / default) at verb 4.\n\nBefore this the client never measured RTT, so every responder sat in the band\nand selection was purely weighted-random; with real measurements the\nlatency-based candidate selection takes effect.\n\nChange-Id: I375a41749060b7d006647bc27002c55436c8a8bb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"ec8570f762f19242f95856f2a20789a97e3ca227":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-07-02 12:30:33.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/48/1748/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1748/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/4 \u0026\u0026 git checkout -b change-1748 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1748/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1748/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e9a53b6caf34f4a17daec54368fe1d62c1215248","subject":"oob: Add --server-probe to order client remotes by probe"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-22 08:47:55.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-07-02 12:11:48.000000000","tz":180},"subject":"oob: Measure probe RTT for candidate-band selection","message":"oob: Measure probe RTT for candidate-band selection\n\nRecord each probe\u0027s round-trip time (per-target send timestamp vs reply\narrival) and feed it to oob_rank_probe_results(), where RTT forms the\ncandidate band: responders within the effective margin of the fastest compete\non weight, slower ones fall behind. Log the measured RTT and the effective\nmargin (with its source: client / server-advertised / default) at verb 4.\n\nBefore this the client never measured RTT, so every responder sat in the band\nand selection was purely weighted-random; with real measurements the\nlatency-based candidate selection takes effect.\n\nChange-Id: I375a41749060b7d006647bc27002c55436c8a8bb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}