)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ff7099a078e57b172e8c320fe674e22bc91053fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"45d2a9a4_42e9ff6e","updated":"2026-11-18 18:24:16.000000000","message":"This needs to be rebased, alas, as `pid_persist` is gone.  I can fix the \"it does not apply nicely\" conflict, but I can not change the new code.","commit_id":"0200c99493db3dbf9e8a7c15c90fbaf7b6e956e5"}],"src/openvpn/init.c":[{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"5b3bab9a9733b3755437d8dfa489ee64265d2c2a","unresolved":true,"context_lines":[{"line_number":3129,"context_line":" * tls-crypt-v2 specifics (WKc, server key) are handled by the caller."},{"line_number":3130,"context_line":" */"},{"line_number":3131,"context_line":"void"},{"line_number":3132,"context_line":"init_tls_wrap_ctx(struct tls_wrap_ctx *tls_wrap, const struct connection_entry *ce, bool tls_client,"},{"line_number":3133,"context_line":"                  const struct key_schedule *ks, struct packet_id_persist *pid_persist)"},{"line_number":3134,"context_line":"{"},{"line_number":3135,"context_line":"    /* TLS handshake authentication (--tls-auth) */"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"15ae18f0_a3ba9d3c","line":3132,"updated":"2026-09-11 15:37:29.000000000","message":"nit: This function assumes that `tls_wrap` is already zero-initialized: otherwise the no-wrapping case does not necessarily leave it in `TLS_WRAP_NONE`, and `opt.flags |\u003d` preserves arbitrary bits. I\u0027d either clear the structure itself here, or at least document this precondition explicitly.","commit_id":"b2bb3e28da4209be92ea29027c6b089b2be63fb2"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"dbbebbcc17cc5d0fcaeb15f46f3842667ee9454a","unresolved":false,"context_lines":[{"line_number":3129,"context_line":" * tls-crypt-v2 specifics (WKc, server key) are handled by the caller."},{"line_number":3130,"context_line":" */"},{"line_number":3131,"context_line":"void"},{"line_number":3132,"context_line":"init_tls_wrap_ctx(struct tls_wrap_ctx *tls_wrap, const struct connection_entry *ce, bool tls_client,"},{"line_number":3133,"context_line":"                  const struct key_schedule *ks, struct packet_id_persist *pid_persist)"},{"line_number":3134,"context_line":"{"},{"line_number":3135,"context_line":"    /* TLS handshake authentication (--tls-auth) */"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"570e2e0d_26f782a5","line":3132,"in_reply_to":"15ae18f0_a3ba9d3c","updated":"2026-09-17 08:00:35.000000000","message":"Done: the function clears the context first and the comment says so.","commit_id":"b2bb3e28da4209be92ea29027c6b089b2be63fb2"}]}
