)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"c20e8c90cb245ec818467ea51e5bde564aa5aee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"6af33182_08b084c5","updated":"2026-09-14 14:35:25.000000000","message":"Non blocking: The existing OOB round-trip tests cover client-to-server wrapping through `tls_pre_decrypt_lite`, but not the new server-to-client reply path through `read_control_auth`. A reverse-direction test would be useful","commit_id":"7ae449254bdf2e78c59214b71fe4e36cf389e76d"}],"src/openvpn/oob_client.c":[{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"c20e8c90cb245ec818467ea51e5bde564aa5aee5","unresolved":true,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"/* Do a and b wrap the control channel with the same key (--tls-auth,"},{"line_number":219,"context_line":" * --tls-crypt, --tls-crypt-v2 and key direction)? The one probe is wrapped"},{"line_number":220,"context_line":" * with entry 0\u0027s key, so a server keyed differently could never answer it. */"},{"line_number":221,"context_line":"static bool"},{"line_number":222,"context_line":"oob_probe_same_wrap(const struct connection_entry *a, const struct connection_entry *b)"},{"line_number":223,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"e6070c47_7d38f33f","line":220,"range":{"start_line":220,"start_character":8,"end_line":220,"end_character":15},"updated":"2026-09-14 14:35:25.000000000","message":"nit: probably a leftover from the previous implementation","commit_id":"7ae449254bdf2e78c59214b71fe4e36cf389e76d"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"46137913ccba04f834f6270fd057a0941381858a","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"/* Do a and b wrap the control channel with the same key (--tls-auth,"},{"line_number":219,"context_line":" * --tls-crypt, --tls-crypt-v2 and key direction)? The one probe is wrapped"},{"line_number":220,"context_line":" * with entry 0\u0027s key, so a server keyed differently could never answer it. */"},{"line_number":221,"context_line":"static bool"},{"line_number":222,"context_line":"oob_probe_same_wrap(const struct connection_entry *a, const struct connection_entry *b)"},{"line_number":223,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"933edddb_05987e73","line":220,"range":{"start_line":220,"start_character":8,"end_line":220,"end_character":15},"in_reply_to":"e6070c47_7d38f33f","updated":"2026-09-15 06:24:11.000000000","message":"Fixed!","commit_id":"7ae449254bdf2e78c59214b71fe4e36cf389e76d"}]}
