)]}'
{"id":"openvpn~1752","triplet_id":"openvpn~master~Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-29 07:58:40.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8","subject":"oob: Add --server-probe-reply to advertise probe priority/weight","status":"NEW","created":"2026-06-29 07:58:31.000000000","updated":"2026-07-02 12:30:33.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9fabd2283282c0fd05066bd1f9eb7faf3350243d","_number":1752,"virtual_id_number":1752,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 07:58:40.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 07:58:40.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"e14329c538305cb8ef5f16d8bc35e59111c13984","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 07:58:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8e77d28159f86f4e4385fe0244d0d4436e501406","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 12:08:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"cacbc1672350dbe6099ae8445e34a37983df4411","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-29 12:37:47.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"9fabd2283282c0fd05066bd1f9eb7faf3350243d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-07-02 12:30:33.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"13ca8fe0be37de4facdfc58b938a3e25015a2852","revisions":{"64c3c1d12fadb070a6bd08eaf158a7918c23de67":{"kind":"REWORK","_number":1,"created":"2026-06-29 07:58:31.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/52/1752/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/1752/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/1 \u0026\u0026 git checkout -b change-1752 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/1752/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c61b7d5a2328624930aa3dd39b82659fe8c16093","subject":"oob: Probe every resolved address of a remote"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-23 12:34:38.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 07:58:03.000000000","tz":180},"subject":"oob: Add --server-probe-reply to advertise probe priority/weight","message":"oob: Add --server-probe-reply to advertise probe priority/weight\n\nAdd a server option, --server-probe-reply \u003cpriority\u003e \u003cweight\u003e, that sets\nthe DNS-SRV-style priority and weight the server returns in its OOB\nPROBE_REPLY. Both default to 0 (the previous hardcoded behaviour), and are\nrange-checked to 0..65535.\n\nThe values are plumbed through oob_build_probe_reply() into the probe_reply\nTLV; the client already reads and ranks remotes by them.\n\nChange-Id: Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"532244a15122df8364bd49075fdc6b54b499f1de":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-29 12:08:26.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/52/1752/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/1752/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/2 \u0026\u0026 git checkout -b change-1752 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/1752/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7b219e378db5d8abf79391a6e844c3274694795b","subject":"oob: Probe every resolved address of a remote"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-23 12:34:38.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 11:45:13.000000000","tz":180},"subject":"oob: Add --server-probe-reply to advertise probe priority/weight","message":"oob: Add --server-probe-reply to advertise probe priority/weight\n\nAdd a server option, --server-probe-reply \u003cpriority\u003e \u003cweight\u003e, that sets\nthe DNS-SRV-style priority and weight the server returns in its OOB\nPROBE_REPLY. Both default to 0 (the previous hardcoded behaviour), and are\nrange-checked to 0..65535.\n\nThe values are plumbed through oob_build_probe_reply() into the probe_reply\nTLV; the client already reads and ranks remotes by them.\n\nChange-Id: Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"35ea41fde6875dd46e7ba0eebe3a4c1ffa88b09d":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-06-29 12:37:47.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/52/1752/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/1752/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/3 \u0026\u0026 git checkout -b change-1752 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/1752/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbc4ea4a63644ac8506c1e02f9b6b72dcaca650e","subject":"oob: Probe every resolved address of a remote"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-23 12:34:38.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-29 12:32:06.000000000","tz":180},"subject":"oob: Add --server-probe-reply to advertise probe priority/weight","message":"oob: Add --server-probe-reply to advertise probe priority/weight\n\nAdd a server option, --server-probe-reply \u003cpriority\u003e \u003cweight\u003e, that sets\nthe DNS-SRV-style priority and weight the server returns in its OOB\nPROBE_REPLY. Both default to 0 (the previous hardcoded behaviour), and are\nrange-checked to 0..65535.\n\nThe values are plumbed through oob_build_probe_reply() into the probe_reply\nTLV; the client already reads and ranks remotes by them.\n\nChange-Id: Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"13ca8fe0be37de4facdfc58b938a3e25015a2852":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-07-02 12:30:33.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/52/1752/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/1752/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/4 \u0026\u0026 git checkout -b change-1752 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/1752/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/1752/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5a4a4b09d411bcf2cec1e5e0af805b548d65fc47","subject":"oob: Probe every resolved address of a remote"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-23 12:34:38.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-07-02 12:11:49.000000000","tz":180},"subject":"oob: Add --server-probe-reply to advertise probe priority/weight","message":"oob: Add --server-probe-reply to advertise probe priority/weight\n\nAdd a server option, --server-probe-reply \u003cpriority\u003e \u003cweight\u003e, that sets\nthe DNS-SRV-style priority and weight the server returns in its OOB\nPROBE_REPLY. Both default to 0 (the previous hardcoded behaviour), and are\nrange-checked to 0..65535.\n\nThe values are plumbed through oob_build_probe_reply() into the probe_reply\nTLV; the client already reads and ranks remotes by them.\n\nChange-Id: Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}
