)]}'
{"id":"openvpn~1753","triplet_id":"openvpn~master~I746bd8c0fa3496d23569cde496438fc4189600fe","project":"openvpn","branch":"master","topic":"tserver_tclient","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-30 12:52:22.000000000","reason":"Vote got outdated and was removed: Code-Review+2"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-06-29 13:08:19.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I746bd8c0fa3496d23569cde496438fc4189600fe","subject":"t_client.sh.in: Use printf instead of echo -e","status":"NEW","created":"2026-06-29 12:59:41.000000000","updated":"2026-07-02 09:53:03.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8c16aea6ccec4ae87235c59cb7e485b3fb326a53","_number":1753,"virtual_id_number":1753,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 12:59:42.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 12:59:42.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"9a06cb55ee6847c0bf751ba254c6d9a7c321e723","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-29 12:59:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0f4da9a16843d086336d786a39d23546a92bddbe","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-29 13:08:19.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fb1a033d552c5e9c03628dd4716bd33092f71114","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-30 12:52:22.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"8c16aea6ccec4ae87235c59cb7e485b3fb326a53","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-02 09:53:03.000000000","message":"Topic set to tserver_tclient","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"850669564c688e89785505e0e0124854a9b96cef","revisions":{"2c4d0cd992d884f72b73ef16d7fe0bfdf776f490":{"kind":"REWORK","_number":1,"created":"2026-06-29 12:59:41.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/53/1753/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1753/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/1 \u0026\u0026 git checkout -b change-1753 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/53/1753/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"294d5ebb32e632c756290cb7b1de3df29a516154","subject":"openvpnserv: rework ConvertItfDnsDomains and tests"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-29 12:47:11.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-29 12:47:11.000000000","tz":120},"subject":"t_client.sh.in: Improve output when echo -e writes \"echo -e\"","message":"t_client.sh.in: Improve output when echo -e writes \"echo -e\"\n\nIn some shells the echo builtin doesn\u0027t interpret -e as\nan argument, it just outputs it as a string. These shells\ngenerally still behave like -e was given, so check whether\nwe need to specify it. Makes the output a bit nicer in those\nshells.\n\nExamples for shells I have observed this with are dash on\nUbuntu and /bin/sh on macOS.\n\nChange-Id: I746bd8c0fa3496d23569cde496438fc4189600fe\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"850669564c688e89785505e0e0124854a9b96cef":{"kind":"REWORK","_number":2,"created":"2026-06-30 12:52:22.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/53/1753/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1753/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/2 \u0026\u0026 git checkout -b change-1753 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/53/1753/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1753/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"401f629c6b01a4c8ed6e74c2e3e53fbc91078ec8","subject":"doc: clarify that --float only applies to UDP"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-29 12:47:11.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-30 12:38:45.000000000","tz":120},"subject":"t_client.sh.in: Use printf instead of echo -e","message":"t_client.sh.in: Use printf instead of echo -e\n\nIn some shells the echo builtin doesn\u0027t interpret -e as\nan argument, it just outputs it as a string.\n\nExamples for shells I have observed this with are dash on\nUbuntu and /bin/sh on macOS.\n\nUse printf instead which should have better consistency\nacross shells and operating systems.\n\nChange-Id: I746bd8c0fa3496d23569cde496438fc4189600fe\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}