)]}'
{"id":"openvpn~1755","triplet_id":"openvpn~master~I6c51bcdda5666e0dab2adcdaff28408c9bfcb844","project":"openvpn","branch":"master","topic":"tserver_tclient","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-29 13:56:18.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I6c51bcdda5666e0dab2adcdaff28408c9bfcb844","subject":"t_client.sh.in: Add support for expected test failures","status":"NEW","created":"2026-06-29 13:56:17.000000000","updated":"2026-07-02 09:53:03.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"34a49a414d04f7acb85f55cc09080e7da964fea9","_number":1755,"virtual_id_number":1755,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-29 13:56:18.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-29 13:56:18.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"3201857fd302a6bd6013393e852d5e5342cb84ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-29 13:56:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9eeab67e51fe0bf64365c6956a8d5eb2e8aaa2ee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-30 12:52:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"34a49a414d04f7acb85f55cc09080e7da964fea9","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-02 09:53:03.000000000","message":"Topic set to tserver_tclient","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b0868a4bcb1c01e5fd8e870af51cedb4491283a0","revisions":{"32774667ddf102e519077ed6c1de01341260c4c3":{"kind":"REWORK","_number":1,"created":"2026-06-29 13:56:17.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/55/1755/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1755/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/1 \u0026\u0026 git checkout -b change-1755 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1755/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c4d0cd992d884f72b73ef16d7fe0bfdf776f490","subject":"t_client.sh.in: Improve output when echo -e writes \"echo -e\""}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-29 13:48:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-29 13:52:51.000000000","tz":120},"subject":"t_client.sh.in: Add support for expected test failures","message":"t_client.sh.in: Add support for expected test failures\n\nAllow to mark tests that must fail. The EXPECT_FAIL\nmessage must contain a message that can be found in\nthe log output. OpenVPN must not start up successfully,\nso this does not allow to test for failures that only\naffect the traffic over the link.\n\nThis is based on work by Gert Doering for the t_server\ntest infrastructure.\n\nChange-Id: I6c51bcdda5666e0dab2adcdaff28408c9bfcb844\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b0868a4bcb1c01e5fd8e870af51cedb4491283a0":{"kind":"REWORK","_number":2,"created":"2026-06-30 12:52:22.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/55/1755/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1755/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/2 \u0026\u0026 git checkout -b change-1755 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1755/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1755/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"850669564c688e89785505e0e0124854a9b96cef","subject":"t_client.sh.in: Use printf instead of echo -e"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-29 13:48:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-30 12:41:23.000000000","tz":120},"subject":"t_client.sh.in: Add support for expected test failures","message":"t_client.sh.in: Add support for expected test failures\n\nAllow to mark tests that must fail. The EXPECT_FAIL\nmessage must contain a message that can be found in\nthe log output. OpenVPN must not start up successfully,\nso this does not allow to test for failures that only\naffect the traffic over the link.\n\nThis is based on work by Gert Doering for the t_server\ntest infrastructure.\n\nChange-Id: I6c51bcdda5666e0dab2adcdaff28408c9bfcb844\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}
