)]}'
{"id":"openvpn~1759","triplet_id":"openvpn~master~I5cc100dd7dc810d7d1e6f29bb57584905fbcf4a0","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-30 11:47:24.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I5cc100dd7dc810d7d1e6f29bb57584905fbcf4a0","subject":"oob: Send tls-crypt-v2 SERVER_PROBE from the client","status":"NEW","created":"2026-06-30 11:47:23.000000000","updated":"2026-07-02 12:30:33.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8628a8731b3c0c682ded37ee0422cbd32bcd3fa2","_number":1759,"virtual_id_number":1759,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-30 11:47:24.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-30 11:47:24.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"adc830012372c0a56567bc2df333fefcf96cbc86","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-30 11:47:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8628a8731b3c0c682ded37ee0422cbd32bcd3fa2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-07-02 12:30:33.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6d8441fa74a29b92c912b4c0e7b5b68cc14b0b46","revisions":{"00813ff3ea10557edcc15cd33289982ac990bd48":{"kind":"REWORK","_number":1,"created":"2026-06-30 11:47:23.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/59/1759/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/1759/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/1 \u0026\u0026 git checkout -b change-1759 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/59/1759/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f9d8e33e87bc775a9db0df42edf8b0696936ab0","subject":"oob: Unwrap tls-crypt-v2 server probes (P_CONTROL_OOB_WKC_V1)"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-30 11:03:54.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-30 11:27:23.000000000","tz":180},"subject":"oob: Send tls-crypt-v2 SERVER_PROBE from the client","message":"oob: Send tls-crypt-v2 SERVER_PROBE from the client\n\nWhen tls-crypt-v2 is configured, send the probe as P_CONTROL_OOB_WKC_V1\nwith the wrapped client key (WKc) appended, so the server can recover the\nper-client key and unwrap it. Without tls-crypt-v2 the probe stays a plain\nP_CONTROL_OOB_V1, unchanged.\n\n  - drop the \"skip probing under tls-crypt-v2\" bail-out\n  - make the WKc available on the probe\u0027s wrap context (mirroring\n    init_instance()), so tls_wrap_control() appends it\n  - choose the opcode (P_CONTROL_OOB_WKC_V1 vs P_CONTROL_OOB_V1) and report\n    \"tls-crypt-v2\" in the wrapping log line\n\nChange-Id: I5cc100dd7dc810d7d1e6f29bb57584905fbcf4a0\n"},"branch":"refs/heads/master"},"6d8441fa74a29b92c912b4c0e7b5b68cc14b0b46":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-07-02 12:30:33.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/59/1759/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/1759/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/2 \u0026\u0026 git checkout -b change-1759 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/59/1759/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1759/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f89df78b7f3dde82f8a4c163dbcecb4557de98c3","subject":"oob: Unwrap tls-crypt-v2 server probes (P_CONTROL_OOB_WKC_V1)"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-30 11:03:54.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-07-02 12:11:49.000000000","tz":180},"subject":"oob: Send tls-crypt-v2 SERVER_PROBE from the client","message":"oob: Send tls-crypt-v2 SERVER_PROBE from the client\n\nWhen tls-crypt-v2 is configured, send the probe as P_CONTROL_OOB_WKC_V1\nwith the wrapped client key (WKc) appended, so the server can recover the\nper-client key and unwrap it. Without tls-crypt-v2 the probe stays a plain\nP_CONTROL_OOB_V1, unchanged.\n\n  - drop the \"skip probing under tls-crypt-v2\" bail-out\n  - make the WKc available on the probe\u0027s wrap context (mirroring\n    init_instance()), so tls_wrap_control() appends it\n  - choose the opcode (P_CONTROL_OOB_WKC_V1 vs P_CONTROL_OOB_V1) and report\n    \"tls-crypt-v2\" in the wrapping log line\n\nChange-Id: I5cc100dd7dc810d7d1e6f29bb57584905fbcf4a0\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}