)]}'
{"id":"openvpn~1760","triplet_id":"openvpn~master~Id8945dce437da11e6fecae9550c3be52e393d4cf","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-01 07:54:09.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-07-01 07:54:09.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id8945dce437da11e6fecae9550c3be52e393d4cf","subject":"dco.c: fix argument order in dco_install_key() log string","status":"MERGED","created":"2026-07-01 05:31:09.000000000","updated":"2026-07-01 07:54:09.000000000","submitted":"2026-07-01 07:54:09.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1760","meta_rev_id":"0f19c8ab6c60d6ed13da6a4794beecb1031e74c4","_number":1760,"virtual_id_number":1760,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-01 05:31:09.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-01 05:31:09.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-07-01 07:41:04.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"66197535bca1a44b98404a9b66d744848a93d2e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-07-01 05:31:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"39a1cbf9f9d60084a68e960b944c5b07026d1d28","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-01 07:41:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0f19c8ab6c60d6ed13da6a4794beecb1031e74c4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-01 07:54:09.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cda2f2533c27f37cfe7a741c9e042a54740e377f","revisions":{"14c1af739c6041b7e516c1aee425610d4969cc11":{"kind":"REWORK","_number":1,"created":"2026-07-01 05:31:09.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/60/1760/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/60/1760/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/1 \u0026\u0026 git checkout -b change-1760 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/60/1760/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"294d5ebb32e632c756290cb7b1de3df29a516154","subject":"openvpnserv: rework ConvertItfDnsDomains and tests"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-07-01 05:26:12.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-07-01 05:26:12.000000000","tz":120},"subject":"dco.c: fix argument order in dco_install_key() log string","message":"dco.c: fix argument order in dco_install_key() log string\n\nThe debug log in dco_install_key() has the epoch and dco_keys_installed\narguments swapped. So a line like epoch\u003d1, currently 0 keys installed\nactually means dco_keys_installed \u003d\u003d 1 and epoch \u003d\u003d false.\n\nUse the correct argument ordering in the log string.\n\nChange-Id: Id8945dce437da11e6fecae9550c3be52e393d4cf\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"cda2f2533c27f37cfe7a741c9e042a54740e377f":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-07-01 07:54:09.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/60/1760/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/60/1760/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/2 \u0026\u0026 git checkout -b change-1760 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/60/1760/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/60/1760/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"401f629c6b01a4c8ed6e74c2e3e53fbc91078ec8","subject":"doc: clarify that --float only applies to UDP"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-07-01 07:41:15.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-07-01 07:48:09.000000000","tz":120},"subject":"dco.c: fix argument order in dco_install_key() log string","message":"dco.c: fix argument order in dco_install_key() log string\n\nThe debug log in dco_install_key() has the epoch and dco_keys_installed\narguments swapped. So a line like epoch\u003d1, currently 0 keys installed\nactually means dco_keys_installed \u003d\u003d 1 and epoch \u003d\u003d false.\n\nUse the correct argument ordering in the log string.\n\nChange-Id: Id8945dce437da11e6fecae9550c3be52e393d4cf\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1760\nMessage-Id: \u003c20260701074122.28795-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37418.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}