)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6ed31c9dd0fac68fbe5b7f712506216d04f600ce","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A server answering an out-of-band SERVER_PROBE now also advertises a"},{"line_number":10,"context_line":"connect_lifetime in the PROBE_REPLY: the seconds the reply doubles as a"},{"line_number":11,"context_line":"handshake shortcut, letting a probing client reuse it as the server\u0027s"},{"line_number":12,"context_line":"HARD_RESET and start the three-way handshake at the third packet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The value is inferred, not configurable: the reply is only valid as a shortcut"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9c1f6d35_735d3c00","line":11,"updated":"2026-07-26 02:18:22.000000000","message":"the seconds the reply?","commit_id":"a60e3ab7df6f11dd9574f976d8d0fea1e447aff3"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"ed8d1ffba3685048a0bc273aa135a1ec14ac021a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A server answering an out-of-band SERVER_PROBE now also advertises a"},{"line_number":10,"context_line":"connect_lifetime in the PROBE_REPLY: the seconds the reply doubles as a"},{"line_number":11,"context_line":"handshake shortcut, letting a probing client reuse it as the server\u0027s"},{"line_number":12,"context_line":"HARD_RESET and start the three-way handshake at the third packet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The value is inferred, not configurable: the reply is only valid as a shortcut"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8ac540fc_47e3261a","line":11,"in_reply_to":"9c1f6d35_735d3c00","updated":"2026-08-17 11:49:50.000000000","message":"I will rephrase it - A server answering an out-of-band SERVER_PROBE now also advertises a connect_lifetime in the PROBE_REPLY: how long, in seconds, a probing client may reuse the reply as the server\u0027s HARD_RESET and start the three-way handshake at the third packet.","commit_id":"a60e3ab7df6f11dd9574f976d8d0fea1e447aff3"}],"src/openvpn/oob.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6ed31c9dd0fac68fbe5b7f712506216d04f600ce","unresolved":true,"context_lines":[{"line_number":255,"context_line":"    reply-\u003econnect_lifetime \u003d connect_lifetime;"},{"line_number":256,"context_line":"    reply-\u003eflags \u003d flags;"},{"line_number":257,"context_line":"    return true;"},{"line_number":258,"context_line":"}"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"/* Base ordering: responders before non-responders, then by priority (lower"},{"line_number":261,"context_line":" * first), then by RTT (lower first), then by original index for determinism."}],"source_content_type":"text/x-csrc","patch_set":8,"id":"f338da62_9bdf6b98","line":258,"updated":"2026-07-26 02:18:22.000000000","message":"This scream that it needs to be refactored. This is a method that gets all parameters of a struct just to put them into a struct.\n\nIt does a little bit else but still.","commit_id":"a60e3ab7df6f11dd9574f976d8d0fea1e447aff3"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"ed8d1ffba3685048a0bc273aa135a1ec14ac021a","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    reply-\u003econnect_lifetime \u003d connect_lifetime;"},{"line_number":256,"context_line":"    reply-\u003eflags \u003d flags;"},{"line_number":257,"context_line":"    return true;"},{"line_number":258,"context_line":"}"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"/* Base ordering: responders before non-responders, then by priority (lower"},{"line_number":261,"context_line":" * first), then by RTT (lower first), then by original index for determinism."}],"source_content_type":"text/x-csrc","patch_set":8,"id":"ddb4cfdd_7887bfe7","line":258,"in_reply_to":"f338da62_9bdf6b98","updated":"2026-08-17 11:49:50.000000000","message":"Agreed. Reply is now in/out - the function is now only sets the peer\u0027s session id, so parameters list goes from 10 to 5. As a side effect, commits adding --server-probe-reply and connect_lifetime no longer touch oob.h/oob.c","commit_id":"a60e3ab7df6f11dd9574f976d8d0fea1e447aff3"}]}