)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"a30d1b6dd53f391e2cdc35a0abac3a589819d4a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3af320ae_90defb04","updated":"2026-08-17 11:04:59.000000000","message":"Left comments on a few minor issues.","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"}],"src/openvpn/options.c":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"a30d1b6dd53f391e2cdc35a0abac3a589819d4a6","unresolved":true,"context_lines":[{"line_number":928,"context_line":"}"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"static void"},{"line_number":932,"context_line":"setenv_connection_entry(struct env_set *es, const struct connection_entry *e, const int i)"},{"line_number":933,"context_line":"{"},{"line_number":934,"context_line":"    setenv_str_i(es, \"remote\", e-\u003eremote, i);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"48bb3d28_3d57c2e6","line":931,"updated":"2026-08-17 11:04:59.000000000","message":"This function is now preceeded by 2 blank lines.","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff03993f226dc9fd85140b76cacee646afbae06c","unresolved":false,"context_lines":[{"line_number":928,"context_line":"}"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"static void"},{"line_number":932,"context_line":"setenv_connection_entry(struct env_set *es, const struct connection_entry *e, const int i)"},{"line_number":933,"context_line":"{"},{"line_number":934,"context_line":"    setenv_str_i(es, \"remote\", e-\u003eremote, i);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8ef3198d_1b6bc81a","line":931,"in_reply_to":"48bb3d28_3d57c2e6","updated":"2026-08-17 12:09:21.000000000","message":"Done","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"}],"src/openvpn/options_show.c":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"a30d1b6dd53f391e2cdc35a0abac3a589819d4a6","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#ifdef HAVE_CONFIG_H"},{"line_number":24,"context_line":"#include \"config.h\""},{"line_number":25,"context_line":"#endif"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e75de4d9_cbb1939e","line":25,"updated":"2026-08-17 11:04:59.000000000","message":"Don\u0027t we want to #include \"options_show.h\" here, and include config.h in that header?","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"5d7fa19d7a302709fb6e89c7c4518eff6941f8c0","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#ifdef HAVE_CONFIG_H"},{"line_number":24,"context_line":"#include \"config.h\""},{"line_number":25,"context_line":"#endif"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a5671ea6_e8cc4660","line":25,"in_reply_to":"4c10fd49_2a754157","updated":"2026-08-17 12:20:10.000000000","message":"It\u0027s not that we need anything from there, but my reasoning was that if we include the header here we will be warned for free, by the compiler, if the \"public\" function\u0027s signature drifts (in this case, `show_settings()`).","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"19bd133dd7d5219afb64dbc1f885748afebde466","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#ifdef HAVE_CONFIG_H"},{"line_number":24,"context_line":"#include \"config.h\""},{"line_number":25,"context_line":"#endif"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c527374f_5c6ef187","line":25,"in_reply_to":"a5671ea6_e8cc4660","updated":"2026-08-17 14:13:40.000000000","message":"Done","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff03993f226dc9fd85140b76cacee646afbae06c","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#ifdef HAVE_CONFIG_H"},{"line_number":24,"context_line":"#include \"config.h\""},{"line_number":25,"context_line":"#endif"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4c10fd49_2a754157","line":25,"in_reply_to":"e75de4d9_cbb1939e","updated":"2026-08-17 12:09:21.000000000","message":"Have added the #include there. But not sure whether I should include options_show.h here. We do not need anything from it?","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"b9b52eeb54ceb72ecb309b9666a3f2bdf3e60d20","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#include \"syshead.h\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#include \"crypto.h\""},{"line_number":32,"context_line":"#include \"error.h\""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9f5dae6e_7a41f8e1","line":29,"updated":"2026-08-17 12:41:52.000000000","message":"Looking at src/openvpn/lzo.c, it unconditionally includes this header. comp-lz4.c does too.\n\nNot sure what the convention is here.","commit_id":"16f746e22115b096bb1e6f1723cb4f63f0f6885c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2a4853de5a55965249ece7c990df17236786cac4","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#include \"syshead.h\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#include \"crypto.h\""},{"line_number":32,"context_line":"#include \"error.h\""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"bab5dfb8_9d14d59b","line":29,"in_reply_to":"1076440b_9cbcbfa7","updated":"2026-08-17 12:49:12.000000000","message":"I mean \"recent\"...","commit_id":"16f746e22115b096bb1e6f1723cb4f63f0f6885c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"273ba43d43c9b0c71036d2215860c6315375fad9","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#include \"syshead.h\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#include \"crypto.h\""},{"line_number":32,"context_line":"#include \"error.h\""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1076440b_9cbcbfa7","line":29,"in_reply_to":"9f5dae6e_7a41f8e1","updated":"2026-08-17 12:48:33.000000000","message":"```\n$ git grep --files-without-match syshead.h src/openvpn/*.c\nsrc/openvpn/crypto_epoch.c\nsrc/openvpn/options_parse.c\nsrc/openvpn/push_util.c\nsrc/openvpn/siphash_reference.c\n```\n\nThe tradition is definitely to just include it. Only some very reason files dropped it when not necessary.","commit_id":"16f746e22115b096bb1e6f1723cb4f63f0f6885c"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"2b52da41f0b893ede8228ed5f0ebcefc64abd2fe","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifndef ENABLE_SMALL"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"#include \"syshead.h\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#include \"crypto.h\""},{"line_number":32,"context_line":"#include \"error.h\""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e7173510_1a8e660a","line":29,"in_reply_to":"bab5dfb8_9d14d59b","updated":"2026-08-17 12:52:52.000000000","message":"I wonder if the traditional way happened because `-Wpedantic` complains that ISO C forbids an empty translation unit. Either way, probably not important.","commit_id":"16f746e22115b096bb1e6f1723cb4f63f0f6885c"}],"src/openvpn/options_show.h":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"a30d1b6dd53f391e2cdc35a0abac3a589819d4a6","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#endif /* ENABLE_SMALL */"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fda60c25_db68c638","line":42,"updated":"2026-08-17 11:04:59.000000000","message":"Nit: missing `/* OPTIONS_SHOW_H */`","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff03993f226dc9fd85140b76cacee646afbae06c","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#endif /* ENABLE_SMALL */"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5e592a64_359f6cdc","line":42,"in_reply_to":"fda60c25_db68c638","updated":"2026-08-17 12:09:21.000000000","message":"Done","commit_id":"cb70de4b43ae34fc00ffcd8162f776e4b9a0cf3f"}]}