)]}'
{"id":"openvpn~1782","triplet_id":"openvpn~master~Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-01 17:01:24.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-09-01 17:01:24.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-09-01 14:56:56.000000000","reason":"\u003cGERRIT_ACCOUNT_1000041\u003e replied on the change","reason_account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}}},"hashtags":[],"change_id":"Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7","subject":"networking_sitnl: validate netlink replies against the request","status":"MERGED","created":"2026-07-13 21:22:03.000000000","updated":"2026-09-01 17:01:24.000000000","submitted":"2026-09-01 17:01:24.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1782","meta_rev_id":"dca290c93d3baf649e4257ffac6eed7bb253451f","_number":1782,"virtual_id_number":1782,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-13 21:22:04.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-13 21:22:04.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-31 22:50:56.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"state":"REVIEWER"}],"messages":[{"id":"d95486aeca750c4d9ae7895dc09bcc495e495bed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-13 21:22:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"77430b2ddcd015c491af5bea7d996c2b5cf2dd44","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-01 07:12:36.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5fe6088e574fc9d75bc8c3196f3676109da78846","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-01 07:37:10.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"814f45d364552f44811ff37d5c6fb76134639c3d","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-01 07:41:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"953df0452863bff1cabcf4e50bec7bdae89a24ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-01 14:46:49.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"713cb528e0af037e26cb30665c7081a63555523f","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-01 14:56:56.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"dca290c93d3baf649e4257ffac6eed7bb253451f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-01 17:01:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"90ab7be00e73d06f7a5bf72e6a454fcfd5f2818c","revisions":{"5c717bb8efc141e6f2354a4bf5cea832f94e43eb":{"kind":"REWORK","_number":1,"created":"2026-07-13 21:22:03.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/82/1782/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1782/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/1 \u0026\u0026 git checkout -b change-1782 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/82/1782/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d41472de0144f3c483a8397dea3bb55f00dc57e4","subject":"ssl_pkt: Fix doxygen warning about read_control_auth"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-13 19:49:48.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-13 21:20:46.000000000","tz":120},"subject":"networking_sitnl: validate netlink replies against the request","message":"networking_sitnl: validate netlink replies against the request\n\nsitnl_send() passed every well-formed reply to the callback without\nchecking it matched the outstanding request: the seq/pid check was\ncommented out and the sequence number came from time(NULL).\n\nSeed a monotonically increasing sequence number and drop any message\nthat is not from the kernel (nl_pid 0) or does not echo our port id and\nsequence number.\n\nChange-Id: Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7\nGitHub: fixes OpenVPN/openvpn-private-issues#9\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"40ad1633b9b336e8cb4bec0d533ee6065e22e6f2":{"kind":"REWORK","_number":2,"created":"2026-09-01 07:37:10.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/82/1782/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1782/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/2 \u0026\u0026 git checkout -b change-1782 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/82/1782/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ece6fe6fd586501b486aac6932d424c167a3adb","subject":"dhcp: Fix off-by-one in write_dhcp_search_str() temp buffer guard"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-13 19:49:48.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-01 07:36:22.000000000","tz":120},"subject":"networking_sitnl: validate netlink replies against the request","message":"networking_sitnl: validate netlink replies against the request\n\nsitnl_send() passed every well-formed reply to the callback without\nchecking it matched the outstanding request: the seq/pid check was\ncommented out and the sequence number came from time(NULL).\n\nSeed a monotonically increasing sequence number and drop any message\nthat is not from the kernel (nl_pid 0) or does not echo our port id and\nsequence number.\n\nChange-Id: Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7\nGitHub: fixes OpenVPN/openvpn-private-issues#9\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"2d51d6444e7d1fb73223752b9031a79006ee62ab":{"kind":"REWORK","_number":3,"created":"2026-09-01 14:46:49.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/82/1782/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1782/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/3 \u0026\u0026 git checkout -b change-1782 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/82/1782/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ece6fe6fd586501b486aac6932d424c167a3adb","subject":"dhcp: Fix off-by-one in write_dhcp_search_str() temp buffer guard"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-13 19:49:48.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-01 14:46:22.000000000","tz":120},"subject":"networking_sitnl: validate netlink replies against the request","message":"networking_sitnl: validate netlink replies against the request\n\nsitnl_send() passed every well-formed reply to the callback without\nchecking it matched the outstanding request: the seq/pid check was\ncommented out and the sequence number came from time(NULL).\n\nSeed a monotonically increasing sequence number and drop any message\nthat is not from the kernel (nl_pid 0) or does not echo our port id and\nsequence number.\n\nChange-Id: Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7\nGitHub: fixes OpenVPN/openvpn-private-issues#9\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"90ab7be00e73d06f7a5bf72e6a454fcfd5f2818c":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-09-01 17:01:24.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/82/1782/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1782/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/4 \u0026\u0026 git checkout -b change-1782 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/82/1782/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1782/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c5308c026f837215f6f7eccad82b5c3601a7b418","subject":"openvpnserv: fix off-by-one input validation"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-01 15:10:10.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-01 16:46:45.000000000","tz":120},"subject":"networking_sitnl: validate netlink replies against the request","message":"networking_sitnl: validate netlink replies against the request\n\nsitnl_send() passed every well-formed reply to the callback without\nchecking it matched the outstanding request: the seq/pid check was\ncommented out and the sequence number came from time(NULL).\n\nSeed a monotonically increasing sequence number and drop any message\nthat is not from the kernel (nl_pid 0) or does not echo our port id and\nsequence number.\n\nChange-Id: Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7\nGitHub: fixes OpenVPN/openvpn-private-issues#9\nReported-by: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1782\nMessage-Id: \u003c20260901151017.16221-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38879.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}