)]}'
{"id":"openvpn~1787","triplet_id":"openvpn~master~I7c0ff48fb019ac7c2d1d981b7b7e4578ff5dce48","project":"openvpn","branch":"master","topic":"multi subnet-pool","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-14 22:17:31.000000000","reason":"Reviewer was added"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-07-15 10:46:31.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I7c0ff48fb019ac7c2d1d981b7b7e4578ff5dce48","subject":"push: push route-gateway(s) for subnet-pool clients","status":"NEW","created":"2026-07-14 22:17:28.000000000","updated":"2026-07-15 14:46:37.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"93154d14c67697e04b52e6b30db4731a78665343","_number":1787,"virtual_id_number":1787,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"date":"2026-07-15 14:46:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-14 22:17:31.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-14 22:17:31.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-07-15 10:46:31.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"13086ad6350df8c7bd2deaeda5de0426af2eb112","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-14 22:17:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1efa8d9cb6460e9b2f2d022e2acb7da13bf659d9","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-14 22:18:09.000000000","message":"Topic set to multi subnet-pool","accounts_in_message":[],"_revision_number":1},{"id":"5864921b2a39b2ee4619377a9c62cb8cd0c39118","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-15 07:56:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"4de015298609ae6e0c7a9f2183f3db91efead376","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-15 10:46:31.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"067ff42380ca3b2d825fdb79491495ae3785edc8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-15 13:23:53.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"93154d14c67697e04b52e6b30db4731a78665343","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-15 14:46:37.000000000","message":"Patch Set 3: -Code-Review","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"eff09c2e10f41845757f14d537c4153319af6284","revisions":{"e67cbb49c4a262fdf4f7af4eff5495f0146eacd3":{"kind":"REWORK","_number":1,"created":"2026-07-14 22:17:28.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/87/1787/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1787/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/1 \u0026\u0026 git checkout -b change-1787 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1787/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"72c1d8d81e3a2fc5962597d5d8d627718ca8952d","subject":"multi: assign IPv6 addresses from a tagged subnet-pool"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-14 14:43:53.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-14 22:17:07.000000000","tz":120},"subject":"push: push route-gateway(s) and server route(s) for subnet-pool clients","message":"push: push route-gateway(s) and server route(s) for subnet-pool clients\n\nA subnet-pool client sits outside the --server / --server-ipv6 network,\nso the global route-gateway (the server\u0027s own VPN IP) is off-link for\nit. Push a route-gateway, and for IPv6 a route-ipv6-gateway, inside the\nclient\u0027s own subnet, plus a host route back to the server\u0027s VPN IPv4 and\nIPv6, so the client\u0027s pushed routes install and the server stays\nreachable.\n\nChange-Id: I7c0ff48fb019ac7c2d1d981b7b7e4578ff5dce48\nGitHub: closes openvpn/OpenVPN#987\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"4f1173c86b727de98c0aee4a0f07a5ad83feb043":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-07-15 07:56:56.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/87/1787/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1787/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/2 \u0026\u0026 git checkout -b change-1787 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1787/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41378df81fccebcb8f6b93afe22a9df245814925","subject":"multi: assign IPv6 addresses from a tagged subnet-pool"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-14 14:43:53.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-15 07:35:47.000000000","tz":120},"subject":"push: push route-gateway(s) and server route(s) for subnet-pool clients","message":"push: push route-gateway(s) and server route(s) for subnet-pool clients\n\nA subnet-pool client sits outside the --server / --server-ipv6 network,\nso the global route-gateway (the server\u0027s own VPN IP) is off-link for\nit. Push a route-gateway, and for IPv6 a route-ipv6-gateway, inside the\nclient\u0027s own subnet, plus a host route back to the server\u0027s VPN IPv4 and\nIPv6, so the client\u0027s pushed routes install and the server stays\nreachable.\n\nChange-Id: I7c0ff48fb019ac7c2d1d981b7b7e4578ff5dce48\nGitHub: closes openvpn/OpenVPN#987\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"eff09c2e10f41845757f14d537c4153319af6284":{"kind":"REWORK","_number":3,"created":"2026-07-15 13:23:53.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/87/1787/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1787/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/3 \u0026\u0026 git checkout -b change-1787 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1787/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1787/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f5038725a0104d7f238ff7080c8ee13ab1ccdca0","subject":"multi: assign IPv6 addresses from a tagged subnet-pool"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-15 11:56:24.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-15 11:56:24.000000000","tz":120},"subject":"push: push route-gateway(s) for subnet-pool clients","message":"push: push route-gateway(s) for subnet-pool clients\n\nA subnet-pool client sits outside the --server / --server-ipv6 network,\nso the global route-gateway (the server\u0027s own VPN IP) is off-link for\nit. Replace it with a route-gateway, and for IPv6 a route-ipv6-gateway,\ninside the client\u0027s own subnet, so the client\u0027s pushed routes install\non-link.\n\nA host route to the server\u0027s own VPN IP is deliberately not pushed: it\nis not needed to reach the networks behind the server. An admin whose\nclients must reach the server\u0027s VPN address itself can add an explicit\npush \"route ...\" to the server config.\n\nChange-Id: I7c0ff48fb019ac7c2d1d981b7b7e4578ff5dce48\nGitHub: closes openvpn/OpenVPN#987\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}
