)]}'
{"id":"openvpn~1789","triplet_id":"openvpn~master~I8219c6295acf28ff10ddb2fcc285f813c42fa8fe","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-15 15:53:06.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-07-17 07:12:44.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-07-17 07:12:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8219c6295acf28ff10ddb2fcc285f813c42fa8fe","subject":"proto: correct 802.1Q length check in is_ipv_X","status":"MERGED","created":"2026-07-15 14:42:03.000000000","updated":"2026-07-17 07:12:44.000000000","submitted":"2026-07-17 07:12:44.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1789","meta_rev_id":"c44a787bd2a1b90256f6484d116e97a1f436363c","_number":1789,"virtual_id_number":1789,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-15 14:42:03.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-15 14:42:03.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-07-15 15:14:09.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"CC"},{"updated":"2026-07-15 18:56:25.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"01e8f73e910c1ee4080227eb6d3be55157ff78fd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-15 14:42:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7f7f2935b216b773d9ee2ceede873f12c302957a","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-15 15:14:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1519bcd0811882ec886648b33bc27e34b0413106","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-15 15:30:55.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0e064aa6c8f23d7d725eaba2325e2ba9d6c88001","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-15 15:35:26.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5c39b0b2beba08a1d5123f7a640a44b4cb22c8d8","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-15 15:40:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6d1e9d7e2ce9e751fa42feb1988e48f782d86bf3","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-15 15:53:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b72832673f989d7c1a927b1ea946799be489e05a","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-15 18:56:25.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c44a787bd2a1b90256f6484d116e97a1f436363c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-17 07:12:44.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f8b15dad1258d6cf71ffa16f67efd9f8b57b9727","revisions":{"a20d76761ca008d4f9485b46d59fbd2fde0a348d":{"kind":"REWORK","_number":1,"created":"2026-07-15 14:42:03.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/89/1789/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1789/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/1 \u0026\u0026 git checkout -b change-1789 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1789/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8d39061007b0a29f78cecce72a0269d6dd3ecde","subject":"buffer: Add buf_read_u64() and buf_write_u64()"}],"author":{"name":"rootvector2","email":"dxbnaveed.k@gmail.com","date":"2026-05-27 18:30:20.000000000","tz":330},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-07-15 14:25:12.000000000","tz":120},"subject":"proto: correct 802.1Q length check in is_ipv_X","message":"proto: correct 802.1Q length check in is_ipv_X\n\nGithub: OpenVPN/openvpn#1044\nSigned-off-by: rootvector2 \u003cdxbnaveed.k@gmail.com\u003e\n\nThis has also been reported twice as a security relevant bug, but\nonly later than the original finding - and it isn\u0027t.\n\nWhile --client-nat would modify a 32bit integer \"after the packet\"\n(the place where an IPv4 address would be, in a well-formed packet),\nthe underlying buffer is always max-frame sized, and we never look\nat the \"modified integer\" afterwards, so there are no consequences\nwarranting allocation of a CVE ID.\n\nReported-By: 章鱼哥 (www.aipyaipy.com)\nReported-By: Yu Zhang Wong \u003cwongyuzhang45@gmail.com\u003e\nChange-Id: I8219c6295acf28ff10ddb2fcc285f813c42fa8fe\n"},"branch":"refs/heads/master"},"08e75f6ea182acd2c9b6d4ca06b5bb35b7b7addd":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-07-15 15:30:55.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/89/1789/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1789/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/2 \u0026\u0026 git checkout -b change-1789 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1789/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8d39061007b0a29f78cecce72a0269d6dd3ecde","subject":"buffer: Add buf_read_u64() and buf_write_u64()"}],"author":{"name":"rootvector2","email":"dxbnaveed.k@gmail.com","date":"2026-05-27 18:30:20.000000000","tz":330},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-07-15 15:30:22.000000000","tz":120},"subject":"proto: correct 802.1Q length check in is_ipv_X","message":"proto: correct 802.1Q length check in is_ipv_X\n\nGithub: OpenVPN/openvpn#1044\n\nThis has also been reported twice as a security relevant bug, but\nonly later than the original finding - and it isn\u0027t.\n\nWhile --client-nat would modify a 32bit integer \"after the packet\"\n(the place where an IPv4 address would be, in a well-formed packet),\nthe underlying buffer is always max-frame sized, and we never look\nat the \"modified integer\" afterwards, so there are no consequences\nwarranting allocation of a CVE ID.\n\nSigned-off-by: rootvector2 \u003cdxbnaveed.k@gmail.com\u003e\nReported-By: 章鱼哥 (www.aipyaipy.com)\nReported-By: Yu Zhang Wong \u003cwongyuzhang45@gmail.com\u003e\nChange-Id: I8219c6295acf28ff10ddb2fcc285f813c42fa8fe\n"},"branch":"refs/heads/master"},"f8b15dad1258d6cf71ffa16f67efd9f8b57b9727":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-07-17 07:12:44.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/89/1789/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1789/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/3 \u0026\u0026 git checkout -b change-1789 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1789/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1789/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"27df276eabdf87ad97ab88e8e84cc53d2bbc59c8","subject":"Replace strtok with strtok_r"}],"author":{"name":"rootvector2","email":"dxbnaveed.k@gmail.com","date":"2026-07-15 20:22:02.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-07-16 21:10:36.000000000","tz":120},"subject":"proto: correct 802.1Q length check in is_ipv_X","message":"proto: correct 802.1Q length check in is_ipv_X\n\nGithub: OpenVPN/openvpn#1044\n\nThis has also been reported twice as a security relevant bug, but\nonly later than the original finding - and it isn\u0027t.\n\nWhile --client-nat would modify a 32bit integer \"after the packet\"\n(the place where an IPv4 address would be, in a well-formed packet),\nthe underlying buffer is always max-frame sized, and we never look\nat the \"modified integer\" afterwards, so there are no consequences\nwarranting allocation of a CVE ID.\n\nSigned-off-by: rootvector2 \u003cdxbnaveed.k@gmail.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1789\nReported-By: 章鱼哥 (www.aipyaipy.com)\nReported-By: Yu Zhang Wong \u003cwongyuzhang45@gmail.com\u003e\nChange-Id: I8219c6295acf28ff10ddb2fcc285f813c42fa8fe\nMessage-Id: \u003c20260715202210.9010-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37652.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
