)]}'
{"id":"openvpn~1790","triplet_id":"openvpn~master~I0bff8d0a549a65b7da01ea0e785b7ec8bea17f05","project":"openvpn","branch":"master","topic":"multi subnet-pool","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-15 21:19:51.000000000","reason":"Reviewer was added"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-07-16 11:06:03.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-07-16 11:06:03.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}},"hashtags":[],"change_id":"I0bff8d0a549a65b7da01ea0e785b7ec8bea17f05","subject":"pool, multi: persist subnet pools via --ifconfig-pool-persist","status":"NEW","created":"2026-07-15 21:19:50.000000000","updated":"2026-07-16 11:06:03.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"31fd3479b1eda244b6220d4bc5a0ea630479a49c","_number":1790,"virtual_id_number":1790,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"rejected":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":-2,"date":"2026-07-16 11:05:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"blocking":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-15 21:19:51.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-15 21:19:51.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-07-16 10:59:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"c1462495c2d11b34bf320d11d6d430fa79a64bbb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-15 21:19:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03da9d7b5f1e5c07dcfa760f3be4824dcde11d54","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-15 21:21:32.000000000","message":"Topic set to multi subnet-pool","accounts_in_message":[],"_revision_number":1},{"id":"bd21109b77e20afdaec512c19eed6bbd46e4b3bf","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-16 10:59:22.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"97bb1a552448bbde208b02484ee81def10e02a2b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-16 11:05:48.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"31fd3479b1eda244b6220d4bc5a0ea630479a49c","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-16 11:06:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"17d00ffc7d8c5851bc10f3b1c03e5c3c2badabef","revisions":{"4860795e539180ed0d6bd1e38e73c8376f653cf7":{"kind":"REWORK","_number":1,"created":"2026-07-15 21:19:50.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/90/1790/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1790/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/1 \u0026\u0026 git checkout -b change-1790 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1790/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eff09c2e10f41845757f14d537c4153319af6284","subject":"push: push route-gateway(s) for subnet-pool clients"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-15 14:32:22.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-15 18:56:55.000000000","tz":120},"subject":"pool, multi: persist subnet pools via --ifconfig-pool-persist","message":"pool, multi: persist subnet pools via --ifconfig-pool-persist\n\nExtend --ifconfig-pool-persist so its single file covers the global pool\nand every --subnet-pool. ifconfig_pool_read()/ifconfig_pool_write() now\noperate on the set of pools: each persisted entry is routed to the pool\nwhose address range owns it, and an entry matching no configured pool is\nignored on load (e.g. a --subnet-pool that was removed). When persist is\nenabled the subnet pools are created eagerly at startup so their saved\nallocations can be reloaded before the first client connects.\n\nChange-Id: I0bff8d0a549a65b7da01ea0e785b7ec8bea17f05\nGitHub: closes openvpn/OpenVPN#987\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"17d00ffc7d8c5851bc10f3b1c03e5c3c2badabef":{"kind":"REWORK","_number":2,"created":"2026-07-16 11:05:48.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/90/1790/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1790/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/2 \u0026\u0026 git checkout -b change-1790 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1790/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1790/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eff09c2e10f41845757f14d537c4153319af6284","subject":"push: push route-gateway(s) for subnet-pool clients"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-15 14:32:22.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-16 11:02:51.000000000","tz":120},"subject":"pool, multi: persist subnet pools via --ifconfig-pool-persist","message":"pool, multi: persist subnet pools via --ifconfig-pool-persist\n\nExtend --ifconfig-pool-persist so its single file covers the global pool\nand every --subnet-pool. ifconfig_pool_read()/ifconfig_pool_write() now\noperate on the set of pools: each persisted entry is routed to the pool\nwhose address range owns it, and an entry matching no configured pool is\nignored on load (e.g. a --subnet-pool that was removed). When persist is\nenabled the subnet pools are created eagerly at startup so their saved\nallocations can be reloaded before the first client connects.\n\nChange-Id: I0bff8d0a549a65b7da01ea0e785b7ec8bea17f05\nGitHub: closes openvpn/OpenVPN#987\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"REJECT","applied_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}