)]}'
{"id":"openvpn~1792","triplet_id":"openvpn~master~I80a94dde26631e5a665029f495b2104cfecb1915","project":"openvpn","branch":"master","topic":"reformat-shell","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-08-20 10:16:24.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-20 10:16:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I80a94dde26631e5a665029f495b2104cfecb1915","subject":"dev-tools/reformat-shell.sh: Make our shell code more consistent","status":"MERGED","created":"2026-07-17 16:21:43.000000000","updated":"2026-08-20 10:16:24.000000000","submitted":"2026-08-20 10:16:24.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1792-reformat-shell","meta_rev_id":"f9f6af3130a988a446c7118807f3325c936c42dc","_number":1792,"virtual_id_number":1792,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-17 16:21:44.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-17 16:21:44.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-14 11:47:40.000000000","updated_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"},{"updated":"2026-08-20 10:01:40.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"state":"CC"}],"messages":[{"id":"9e00f5f71e62be9702cfdb7fb6d476733453a801","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-17 16:21:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"291311a25f0d7ceab158ac32c58f53de6991b0ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-22 13:11:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"981403d2b2090352f6265dcc56cbba7ce176fc8d","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-14 11:47:40.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0d96991721ccf623be42b82e6b7ab53e8c30e79e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 11:42:39.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"be64a492c9eb8a593e631ebf62fea2e8dc7c722b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 13:18:58.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"f31611a0341593498dde313bbfde8bea4c940de6","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-08-20 10:01:40.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f9f6af3130a988a446c7118807f3325c936c42dc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-20 10:16:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"5663fd71f4358e404031d57f9ec1acbb0b78358a","revisions":{"2e958937a03f010ebf61bad358e44e8b7f72ca34":{"kind":"REWORK","_number":1,"created":"2026-07-17 16:21:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1792/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1792/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/1 \u0026\u0026 git checkout -b change-1792 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1792/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8b15dad1258d6cf71ffa16f67efd9f8b57b9727","subject":"proto: correct 802.1Q length check in is_ipv_X"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-07-17 16:13:12.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-07-17 16:13:12.000000000","tz":120},"subject":"dev-tools/reformat-shell.sh: Make our shell code more consistent","message":"dev-tools/reformat-shell.sh: Make our shell code more consistent\n\nOur shell code is currently not very consistent about\nformatting. So provide a tool to achieve that consistency.\nEspecially in our test code we have several important shell\nscripts that we actively develop.\n\nChange-Id: I80a94dde26631e5a665029f495b2104cfecb1915\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2e02ce5ae37f81d5972a0e2a5103fccc8670eee6":{"kind":"REWORK","_number":2,"created":"2026-07-22 13:11:24.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1792/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1792/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/2 \u0026\u0026 git checkout -b change-1792 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1792/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4ad3c71ec4bdad706332d0281a3bb3bba0234288","subject":"silence autoconf warnings about openvpnserv_testdriver_CFLAGS etc"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-07-17 16:13:12.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-07-22 13:08:44.000000000","tz":120},"subject":"dev-tools/reformat-shell.sh: Make our shell code more consistent","message":"dev-tools/reformat-shell.sh: Make our shell code more consistent\n\nOur shell code is currently not very consistent about\nformatting. So provide a tool to achieve that consistency.\nEspecially in our test code we have several important shell\nscripts that we actively develop.\n\nChange-Id: I80a94dde26631e5a665029f495b2104cfecb1915\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"70c25fed3acde0c6e63aa00a3e21f67dc3025241":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-08-19 11:42:39.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1792/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1792/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/3 \u0026\u0026 git checkout -b change-1792 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1792/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"532f87b9cc89ae14ead0d9cd9884792e704f9a49","subject":"gen-release-tarballs.sh: Fix some shell issues"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-07-17 16:13:12.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 11:40:10.000000000","tz":120},"subject":"dev-tools/reformat-shell.sh: Make our shell code more consistent","message":"dev-tools/reformat-shell.sh: Make our shell code more consistent\n\nOur shell code is currently not very consistent about\nformatting. So provide a tool to achieve that consistency.\nEspecially in our test code we have several important shell\nscripts that we actively develop.\n\nChange-Id: I80a94dde26631e5a665029f495b2104cfecb1915\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"718da44ae0e0c3164b55df79ea27ec05814231a2":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-08-19 13:18:58.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1792/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1792/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/4 \u0026\u0026 git checkout -b change-1792 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1792/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3eedb5f7320dd04d6e03d3bd276844115724f1c5","subject":"gen-release-tarballs.sh: Remove"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-07-17 16:13:12.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 13:18:17.000000000","tz":120},"subject":"dev-tools/reformat-shell.sh: Make our shell code more consistent","message":"dev-tools/reformat-shell.sh: Make our shell code more consistent\n\nOur shell code is currently not very consistent about\nformatting. So provide a tool to achieve that consistency.\nEspecially in our test code we have several important shell\nscripts that we actively develop.\n\nChange-Id: I80a94dde26631e5a665029f495b2104cfecb1915\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5663fd71f4358e404031d57f9ec1acbb0b78358a":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-08-20 10:16:24.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/92/1792/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1792/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/5 \u0026\u0026 git checkout -b change-1792 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1792/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1792/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"889a873cdb7b7883166a9a1d305552336c117a39","subject":"Rename variables that shadow other variables or functions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-20 09:15:07.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-08-20 10:14:17.000000000","tz":120},"subject":"dev-tools/reformat-shell.sh: Make our shell code more consistent","message":"dev-tools/reformat-shell.sh: Make our shell code more consistent\n\nOur shell code is currently not very consistent about\nformatting. So provide a tool to achieve that consistency.\nEspecially in our test code we have several important shell\nscripts that we actively develop.\n\nChange-Id: I80a94dde26631e5a665029f495b2104cfecb1915\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1792\nMessage-Id: \u003c20260820091512.4550-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38546.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}