)]}'
{"id":"openvpn~1795","triplet_id":"openvpn~master~I4d0887839b4a13a92e92250d1b315dec949698f3","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-18 15:55:59.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4d0887839b4a13a92e92250d1b315dec949698f3","subject":"dco.c: make key state desync recoverable","status":"NEW","created":"2026-07-18 15:55:58.000000000","updated":"2026-07-18 15:57:11.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"865e1b76a3b1c4a2e8adb29eca979708fcee2a2f","_number":1795,"virtual_id_number":1795,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-18 15:55:59.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-18 15:55:59.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"26fdbde75817c397854a86ddccfc9290563cbba6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-07-18 15:55:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"865e1b76a3b1c4a2e8adb29eca979708fcee2a2f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-07-18 15:57:11.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"817919dafbc393f5b8b419bbb3248d595fc65729","revisions":{"f84c0f18b88dbc9f107d46e283c782be0cfa0cc6":{"kind":"REWORK","_number":1,"created":"2026-07-18 15:55:58.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/95/1795/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/95/1795/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/1 \u0026\u0026 git checkout -b change-1795 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/95/1795/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"01ee1693f960a696a613e7b83f9960002264a379","subject":"Ensure tls-crypt keys are not setup twice"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-07-01 07:37:27.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-07-01 13:40:40.000000000","tz":120},"subject":"dco.c: make key state desync recoverable","message":"dco.c: make key state desync recoverable\n\nIf installing a DCO key succeeds, always record the slot in the\ncorresponding key_state. The installed-key counter only tracks whether\nthe number of kernel slots grew, but a successful KEY_NEW still means\nthat this key_state is associated with the selected DCO slot.\n\nAlso replace the assertion in dco_update_keys() with an error return\nwhen the selected primary key is not marked as installed in DCO. This\npreserves the invariant check but lets the existing caller restart the\nconnection instead of aborting the process.\n\nGithub: https://github.com/OpenVPN/openvpn-private-issues/issues/143\nChange-Id: I4d0887839b4a13a92e92250d1b315dec949698f3\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"817919dafbc393f5b8b419bbb3248d595fc65729":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-07-18 15:57:11.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/95/1795/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/95/1795/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/2 \u0026\u0026 git checkout -b change-1795 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/95/1795/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1795/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"27a39d7c0b2ca7f9fc8b7dae0ea3570369f6ae25","subject":"Move incoming data processing in its own method"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-07-01 07:37:27.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-07-18 15:56:55.000000000","tz":120},"subject":"dco.c: make key state desync recoverable","message":"dco.c: make key state desync recoverable\n\nIf installing a DCO key succeeds, always record the slot in the\ncorresponding key_state. The installed-key counter only tracks whether\nthe number of kernel slots grew, but a successful KEY_NEW still means\nthat this key_state is associated with the selected DCO slot.\n\nAlso replace the assertion in dco_update_keys() with an error return\nwhen the selected primary key is not marked as installed in DCO. This\npreserves the invariant check but lets the existing caller restart the\nconnection instead of aborting the process.\n\nGithub: https://github.com/OpenVPN/openvpn-private-issues/issues/143\nChange-Id: I4d0887839b4a13a92e92250d1b315dec949698f3\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}