)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"f7f3319039a009694730eb1e009471276b59d826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac32fc5c_68bf3f1d","updated":"2026-07-20 23:18:40.000000000","message":"I think it is a good idea but I think we can clean up a bit more.","commit_id":"0ce327878bdd991c5a45c1b08ed1bb593d477975"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ff7cd8b2bb7e61b28f9a5ead7559faf3ed2a8c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"289d6019_4ad81a61","updated":"2026-07-21 09:20:25.000000000","message":"The documentation reads as if this is intended for 2.7, but the way it is coded (removing the `push` bits) will turn TCP_NODELAY *off* on clients where this is today pushed from the server (server config with `tcp-nodelay` -\u003e `helper_tcp_nodelay()` -\u003e `push socket-flags TCP_NODELAY`).\n\nSo for a 2.7 patch, \"turn it on\" is likely acceptable, but \"turn off the pushing functionality\" it is not.  For a master patch, it\u0027s still arguable if that is a good idea.\n\nThat said, the documentation also spends quite a few (new!) words on explaining what `TCP_NODELAY` does - which is a bit weird to add this if it\u0027s no longer configurable.  So this needs more work overall.","commit_id":"3f3d4b30df229e59ffa72bd725fcc167d64284de"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d965df86502d714a2d3a52caef559e2fd60ceb95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a04bb801_67643849","updated":"2026-07-21 11:36:45.000000000","message":"this works for me","commit_id":"ee7b3d5be874f61f2863b7a8698f82e4ca3bab25"}],"src/openvpn/options.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"f7f3319039a009694730eb1e009471276b59d826","unresolved":true,"context_lines":[{"line_number":7707,"context_line":"    else if (streq(p[0], \"tcp-nodelay\") \u0026\u0026 !p[1])"},{"line_number":7708,"context_line":"    {"},{"line_number":7709,"context_line":"        VERIFY_PERMISSION(OPT_P_GENERAL);"},{"line_number":7710,"context_line":"        msg(M_WARN, \"DEPRECATED OPTION: --tcp-nodelay is now the default and \""},{"line_number":7711,"context_line":"                    \"the option is ignored.\");"},{"line_number":7712,"context_line":"    }"},{"line_number":7713,"context_line":"    else if (streq(p[0], \"stale-routes-check\") \u0026\u0026 p[1] \u0026\u0026 !p[3])"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"089b99ab_9a547c6b","line":7710,"updated":"2026-07-20 23:18:40.000000000","message":"is enabled by default.","commit_id":"0ce327878bdd991c5a45c1b08ed1bb593d477975"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"2d6f1da9cb61c91c19dfea844177e0c4c7557a57","unresolved":false,"context_lines":[{"line_number":7707,"context_line":"    else if (streq(p[0], \"tcp-nodelay\") \u0026\u0026 !p[1])"},{"line_number":7708,"context_line":"    {"},{"line_number":7709,"context_line":"        VERIFY_PERMISSION(OPT_P_GENERAL);"},{"line_number":7710,"context_line":"        msg(M_WARN, \"DEPRECATED OPTION: --tcp-nodelay is now the default and \""},{"line_number":7711,"context_line":"                    \"the option is ignored.\");"},{"line_number":7712,"context_line":"    }"},{"line_number":7713,"context_line":"    else if (streq(p[0], \"stale-routes-check\") \u0026\u0026 p[1] \u0026\u0026 !p[3])"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e47c1e5d_41a48ba6","line":7710,"in_reply_to":"089b99ab_9a547c6b","updated":"2026-07-21 07:33:34.000000000","message":"Done","commit_id":"0ce327878bdd991c5a45c1b08ed1bb593d477975"}],"src/openvpn/socket.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"f7f3319039a009694730eb1e009471276b59d826","unresolved":true,"context_lines":[{"line_number":1489,"context_line":"     * skips it on dco-win and non-TCP transports) */"},{"line_number":1490,"context_line":"    if (proto_is_tcp(sock-\u003einfo.proto))"},{"line_number":1491,"context_line":"    {"},{"line_number":1492,"context_line":"        sock-\u003esockflags |\u003d SF_TCP_NODELAY;"},{"line_number":1493,"context_line":"    }"},{"line_number":1494,"context_line":""},{"line_number":1495,"context_line":"    /* set misc socket parameters */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f74cde81_10fbe178","line":1492,"updated":"2026-07-20 23:18:40.000000000","message":"Let\u0027s get rid of SF_TCP_NODELAY. And maybe the whole socket_set_flags wrapper and just do:\n\nif (proto_is_tcp(sock-\u003einfo.proto) \u0026\u0026 !sock-\u003esockflags \u0026 SF_DCO_WIN)\n   socket_set_tcp_nodelay(sd, 1)\n   \nto clean up the code.","commit_id":"0ce327878bdd991c5a45c1b08ed1bb593d477975"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"2d6f1da9cb61c91c19dfea844177e0c4c7557a57","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"     * skips it on dco-win and non-TCP transports) */"},{"line_number":1490,"context_line":"    if (proto_is_tcp(sock-\u003einfo.proto))"},{"line_number":1491,"context_line":"    {"},{"line_number":1492,"context_line":"        sock-\u003esockflags |\u003d SF_TCP_NODELAY;"},{"line_number":1493,"context_line":"    }"},{"line_number":1494,"context_line":""},{"line_number":1495,"context_line":"    /* set misc socket parameters */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"46b8588e_c78f6602","line":1492,"in_reply_to":"f74cde81_10fbe178","updated":"2026-07-21 07:33:34.000000000","message":"Done","commit_id":"0ce327878bdd991c5a45c1b08ed1bb593d477975"}]}