)]}'
{"id":"openvpn~1797","triplet_id":"openvpn~master~I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7","project":"openvpn","branch":"master","attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-07-21 12:05:11.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-21 12:05:11.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7","subject":"Enable TCP_NODELAY by default and push it to clients","status":"NEW","created":"2026-07-20 22:21:06.000000000","updated":"2026-07-21 12:05:11.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d862b34e188795ead4b924645f312d137a290f72","_number":1797,"virtual_id_number":1797,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"all":[{"value":2,"date":"2026-07-21 12:05:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":1,"date":"2026-07-21 11:36:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-20 22:21:07.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-20 22:21:07.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-07-21 09:20:25.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"7942cbdf29c1fed38588b2639d17ebf597fde492","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-20 22:21:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f7f3319039a009694730eb1e009471276b59d826","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-20 23:18:40.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"73a002e9288ea63a534d3712837153166329566b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-20 23:34:05.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f47d759ea46c90c141ab635f22273bef8ba22a31","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-20 23:51:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2d6f1da9cb61c91c19dfea844177e0c4c7557a57","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-21 07:33:34.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ff7cd8b2bb7e61b28f9a5ead7559faf3ed2a8c52","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-21 09:20:25.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e0b11d88806cb56e75fab22c9cb7e0f76191f25e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-21 11:28:45.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"d965df86502d714a2d3a52caef559e2fd60ceb95","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-21 11:36:45.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d862b34e188795ead4b924645f312d137a290f72","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-21 12:05:11.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ee7b3d5be874f61f2863b7a8698f82e4ca3bab25","revisions":{"0ce327878bdd991c5a45c1b08ed1bb593d477975":{"kind":"REWORK","_number":1,"created":"2026-07-20 22:21:06.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/97/1797/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1797/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/1 \u0026\u0026 git checkout -b change-1797 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1797/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a3942a62ff3c8e8f0a5dc577e24552a4d4fa5fb0","subject":"test_tls_crypt: Fix test failure on Windows"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-20 22:00:21.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-20 22:17:00.000000000","tz":120},"subject":"Enable TCP_NODELAY by default and deprecate --tcp-nodelay","message":"Enable TCP_NODELAY by default and deprecate --tcp-nodelay\n\nTCP_NODELAY disables Nagle\u0027s algorithm, which is\nbeneficial for tunnelled traffic and has long been\nrecommended for OpenVPN over TCP. Until now it had\nto be requested explicitly via --tcp-nodelay or\n\"socket-flags TCP_NODELAY\".\n\nSet SF_TCP_NODELAY unconditionally on every TCP\nsocket so the flag is always applied\n(socket_set_flags still skips it on dco-win and\nnon-TCP transports).\n\nWith the flag always on, --tcp-nodelay is deprecated.\n\nMeasured over a p2p TCP tunnel: bulk throughput is\nunchanged (~1.7 Gbit/s, within 0.4%), while\nsmall-packet interactive latency improves sharply\nwhere Nagle bites: a request/response turn that\nspans several packets drops from ~82 ms to ~0.03 ms\nround-trip. A turn of a single packet stays fast\nwith or without TCP_NODELAY, as Nagle cannot delay\na lone packet.\n\nChange-Id: I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"3f3d4b30df229e59ffa72bd725fcc167d64284de":{"kind":"REWORK","_number":2,"created":"2026-07-20 23:34:05.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/97/1797/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1797/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/2 \u0026\u0026 git checkout -b change-1797 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1797/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a3942a62ff3c8e8f0a5dc577e24552a4d4fa5fb0","subject":"test_tls_crypt: Fix test failure on Windows"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-20 22:00:21.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-20 23:32:07.000000000","tz":120},"subject":"Enable TCP_NODELAY by default and deprecate --tcp-nodelay","message":"Enable TCP_NODELAY by default and deprecate --tcp-nodelay\n\nTCP_NODELAY disables Nagle\u0027s algorithm, which is\nbeneficial for tunnelled traffic and has long been\nrecommended for OpenVPN over TCP. Until now it had\nto be requested explicitly via --tcp-nodelay or\n\"socket-flags TCP_NODELAY\".\n\nEnable it unconditionally on every TCP socket (dco-win\nis skipped as it manages its own socket) and drop the\nsocket_set_flags()/link_socket_update_flags() plumbing\nthat only ever applied it; the SF_TCP_NODELAY sockflag\nis now unused but kept reserved.\n\n--tcp-nodelay and \"socket-flags TCP_NODELAY\" become\nno-ops, kept for backwards compatibility; the\n--tcp-nodelay helper, its SF_TCP_NODELAY_HELPER flag\nand the client-side warning are dropped as well.\n\nMeasured over a p2p TCP tunnel: bulk throughput is\nunchanged (~1.7 Gbit/s, within 0.4%), while\nsmall-packet interactive latency improves sharply\nwhere Nagle bites: a request/response turn that\nspans several packets drops from ~82 ms to ~0.03 ms\nround-trip. A turn of a single packet stays fast\nwith or without TCP_NODELAY, as Nagle cannot delay\na lone packet.\n\nChange-Id: I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"ee7b3d5be874f61f2863b7a8698f82e4ca3bab25":{"kind":"REWORK","_number":3,"created":"2026-07-21 11:28:45.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/97/1797/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1797/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/3 \u0026\u0026 git checkout -b change-1797 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1797/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1797/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a3942a62ff3c8e8f0a5dc577e24552a4d4fa5fb0","subject":"test_tls_crypt: Fix test failure on Windows"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-20 22:00:21.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-07-21 11:28:09.000000000","tz":120},"subject":"Enable TCP_NODELAY by default and push it to clients","message":"Enable TCP_NODELAY by default and push it to clients\n\nTCP_NODELAY had to be requested explicitly via\n--tcp-nodelay or \"socket-flags TCP_NODELAY\". Enable\nit unconditionally on every TCP socket instead\n(dco-win is skipped as it manages its own socket).\nThe socket_set_flags() and\nlink_socket_update_flags() plumbing that only ever\napplied it is dropped; the SF_TCP_NODELAY sockflag\nand \"socket-flags TCP_NODELAY\" become no-ops, the\nlatter kept for backwards compatibility.\n\n--tcp-nodelay no longer touches the local socket\nbut, in --mode server, still pushes \"socket-flags\nTCP_NODELAY\" to clients, for the benefit of clients\nolder than 2.7.6 that do not enable it by default.\nOn a client the option is deprecated and inert. It\ncan be dropped once such clients are gone.\n\nChange-Id: I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}