)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"87ed1d8776a6941cfc6d43787be84ebfe2236d9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1274c28a_8a41c4cc","updated":"2026-07-22 15:38:01.000000000","message":"The overall change from \u0027field\u003d\u0027 to \u0027field\u0027 will create code differences which are going to bite us later when backporting master -\u003e 2.7, so I\u0027m not convinced this is a positive change (always passing in the \u0027\u003d\u0027 would actually simplify the `extract_var_peer_info()` a bit, as the first `snprintf()` is no longer needed at all).  So maybe not?\n\nBesides this there are a few more things that look like they need more love...","commit_id":"e21e74e8ed27c6187d4e72b83c1be1ca1a08deca"}],"CMakeLists.txt":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"87ed1d8776a6941cfc6d43787be84ebfe2236d9f","unresolved":true,"context_lines":[{"line_number":910,"context_line":"        src/openvpn/otime.c"},{"line_number":911,"context_line":"        src/openvpn/list.c"},{"line_number":912,"context_line":"        src/openvpn/ssl_util.c"},{"line_number":913,"context_line":"    )"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    target_sources(test_argv PRIVATE"},{"line_number":916,"context_line":"        tests/unit_tests/openvpn/mock_get_random.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"0c3efa0a_6ee11934","line":913,"updated":"2026-07-22 15:38:01.000000000","message":"your \u0027add ssl_util.c\u0027 key seems to be hickuping ;-)","commit_id":"e21e74e8ed27c6187d4e72b83c1be1ca1a08deca"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2e5565dbbdfe7640cac6e504011ac4f246cc88f6","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        src/openvpn/otime.c"},{"line_number":911,"context_line":"        src/openvpn/list.c"},{"line_number":912,"context_line":"        src/openvpn/ssl_util.c"},{"line_number":913,"context_line":"    )"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    target_sources(test_argv PRIVATE"},{"line_number":916,"context_line":"        tests/unit_tests/openvpn/mock_get_random.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"92d5ff1b_74c948c2","line":913,"in_reply_to":"0c3efa0a_6ee11934","updated":"2026-07-22 17:16:28.000000000","message":"Done","commit_id":"e21e74e8ed27c6187d4e72b83c1be1ca1a08deca"}],"src/openvpn/ssl_util.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"87ed1d8776a6941cfc6d43787be84ebfe2236d9f","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        snprintf(buf, sizeof(buf), \"%s\u003d%%d\", field);"},{"line_number":95,"context_line":"        int proto \u003d 0;"},{"line_number":96,"context_line":"        int r \u003d sscanf(optstr, buf, \u0026proto);"},{"line_number":97,"context_line":"        if (r \u003d\u003d 1 \u0026\u0026 proto \u003e 0)"},{"line_number":98,"context_line":"        {"},{"line_number":99,"context_line":"            return proto;"},{"line_number":100,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"05088baa_5ebd86ea","line":97,"updated":"2026-07-22 15:38:01.000000000","message":"this looks like a highly complicated way to do \n\n`r \u003d sscanf(optstr+strlen(field), \"\u003d%d\", \u0026proto)`\n\nno?","commit_id":"e21e74e8ed27c6187d4e72b83c1be1ca1a08deca"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a2f8ad5a277a404553952c66ee97b976b00706e8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        snprintf(buf, sizeof(buf), \"%s\u003d%%d\", field);"},{"line_number":95,"context_line":"        int proto \u003d 0;"},{"line_number":96,"context_line":"        int r \u003d sscanf(optstr, buf, \u0026proto);"},{"line_number":97,"context_line":"        if (r \u003d\u003d 1 \u0026\u0026 proto \u003e 0)"},{"line_number":98,"context_line":"        {"},{"line_number":99,"context_line":"            return proto;"},{"line_number":100,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"31f4551d_4a808ee6","line":97,"in_reply_to":"05088baa_5ebd86ea","updated":"2026-07-22 17:16:20.000000000","message":"Done","commit_id":"e21e74e8ed27c6187d4e72b83c1be1ca1a08deca"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"87ed1d8776a6941cfc6d43787be84ebfe2236d9f","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        {"},{"line_number":114,"context_line":"            return peer_id;"},{"line_number":115,"context_line":"        }"},{"line_number":116,"context_line":"    }"},{"line_number":117,"context_line":"    return MAX_PEER_ID;"},{"line_number":118,"context_line":"}"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ace55878_891009fa","line":116,"updated":"2026-07-22 15:38:01.000000000","message":"why not use `peer_info_extract_uint()` with `MAX_PEER_ID` as \"default if unset\" value?  done, reduced to 1 line","commit_id":"e21e74e8ed27c6187d4e72b83c1be1ca1a08deca"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a2f8ad5a277a404553952c66ee97b976b00706e8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        {"},{"line_number":114,"context_line":"            return peer_id;"},{"line_number":115,"context_line":"        }"},{"line_number":116,"context_line":"    }"},{"line_number":117,"context_line":"    return MAX_PEER_ID;"},{"line_number":118,"context_line":"}"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"96cf7976_194c65b5","line":116,"in_reply_to":"ace55878_891009fa","updated":"2026-07-22 17:16:20.000000000","message":"because it needs %x instead of %d to parse. I added peer_info_extract_int to still be able to unify the code paths.","commit_id":"e21e74e8ed27c6187d4e72b83c1be1ca1a08deca"}]}