)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"9cacf009bf8def1828718af81982575e12da5d2b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a50122c0_6a43712f","updated":"2026-07-28 12:04:55.000000000","message":"why did you decide to include this test in test_misc instead of creating its own runner? You did create its own .c file after all.","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"448253b9eb9cc817c7591460565354ab7b524e7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9c690449_46ba764f","in_reply_to":"589a515e_e783bce9","updated":"2026-07-30 10:12:23.000000000","message":"Acknowledged","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"c87aa9160d417383265c4df72517189a826bd760","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"589a515e_e783bce9","in_reply_to":"a50122c0_6a43712f","updated":"2026-07-28 12:16:30.000000000","message":"I don\u0027t think we need more test runners. We already have a quite a lot. But I still wanted to have it in its own C file to seperate the code.","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"}],"tests/unit_tests/openvpn/Makefile.am":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"9cacf009bf8def1828718af81982575e12da5d2b","unresolved":true,"context_lines":[{"line_number":370,"context_line":"misc_testdriver_LDFLAGS \u003d @TEST_LDFLAGS@"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"misc_testdriver_SOURCES \u003d test_misc.c \\"},{"line_number":373,"context_line":"    test_schedule.c test_schedule.h \\"},{"line_number":374,"context_line":"\tmock_msg.c test_common.h  \\"},{"line_number":375,"context_line":"\tmock_get_random.c \\"},{"line_number":376,"context_line":"\t$(top_srcdir)/src/openvpn/buffer.c \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"4064001a_d4143870","line":373,"updated":"2026-07-28 12:04:55.000000000","message":"wrong whitespace","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"c87aa9160d417383265c4df72517189a826bd760","unresolved":false,"context_lines":[{"line_number":370,"context_line":"misc_testdriver_LDFLAGS \u003d @TEST_LDFLAGS@"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"misc_testdriver_SOURCES \u003d test_misc.c \\"},{"line_number":373,"context_line":"    test_schedule.c test_schedule.h \\"},{"line_number":374,"context_line":"\tmock_msg.c test_common.h  \\"},{"line_number":375,"context_line":"\tmock_get_random.c \\"},{"line_number":376,"context_line":"\t$(top_srcdir)/src/openvpn/buffer.c \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"480750f8_e68355c4","line":373,"in_reply_to":"4064001a_d4143870","updated":"2026-07-28 12:16:30.000000000","message":"Done","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"}],"tests/unit_tests/openvpn/test_misc.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c4fc9a16e1b2f772b5d6d7bd8addcb196038e6a7","unresolved":true,"context_lines":[{"line_number":490,"context_line":"    cmocka_unit_test(test_auth_fail_temp_flags),"},{"line_number":491,"context_line":"    cmocka_unit_test(test_auth_fail_temp_flags_msg),"},{"line_number":492,"context_line":"    cmocka_unit_test(test_list),"},{"line_number":493,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":494,"context_line":"    cmocka_unit_test(test_atoi_variants)"},{"line_number":495,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":496,"context_line":"    cmocka_unit_test(test_atoi_variants),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bf184d19_1d7d5c8d","line":493,"updated":"2026-07-28 12:01:00.000000000","message":"conflict resolution damage","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"718c4ec1a8069eea2bd6f34df7aeb53afe48bd63","unresolved":false,"context_lines":[{"line_number":490,"context_line":"    cmocka_unit_test(test_auth_fail_temp_flags),"},{"line_number":491,"context_line":"    cmocka_unit_test(test_auth_fail_temp_flags_msg),"},{"line_number":492,"context_line":"    cmocka_unit_test(test_list),"},{"line_number":493,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":494,"context_line":"    cmocka_unit_test(test_atoi_variants)"},{"line_number":495,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":496,"context_line":"    cmocka_unit_test(test_atoi_variants),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e034f826_acc38827","line":493,"in_reply_to":"bf184d19_1d7d5c8d","updated":"2026-07-28 12:36:25.000000000","message":"Done","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"}],"tests/unit_tests/openvpn/test_schedule.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ee08af62452e747d9b43879b1a755176cd625b93","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    {"},{"line_number":89,"context_line":"        int d;"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        ASSERT(e !\u003d e-\u003elt);"},{"line_number":92,"context_line":"        ASSERT(e !\u003d e-\u003egt);"},{"line_number":93,"context_line":"        ASSERT(e !\u003d e-\u003eparent);"},{"line_number":94,"context_line":"        ASSERT(!e-\u003eparent || e-\u003eparent !\u003d e-\u003elt);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"6917016e_d4b4df7a","line":91,"updated":"2026-07-29 12:01:41.000000000","message":"We should change these to proper cmocka asserts, but not sure whether it is better to do that in a separate commit?","commit_id":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"8772936a4766f74955b0cbd12190106d1d5f3e33","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    {"},{"line_number":89,"context_line":"        int d;"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        ASSERT(e !\u003d e-\u003elt);"},{"line_number":92,"context_line":"        ASSERT(e !\u003d e-\u003egt);"},{"line_number":93,"context_line":"        ASSERT(e !\u003d e-\u003eparent);"},{"line_number":94,"context_line":"        ASSERT(!e-\u003eparent || e-\u003eparent !\u003d e-\u003elt);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f593a9d2_556a11ff","line":91,"in_reply_to":"6917016e_d4b4df7a","updated":"2026-07-29 18:41:56.000000000","message":"Done. I think it is okay to in the same commit as this is a unit test rather than code that is run in production.","commit_id":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ee08af62452e747d9b43879b1a755176cd625b93","unresolved":true,"context_lines":[{"line_number":165,"context_line":"    tv-\u003etv_usec \u003d random() % 100;"},{"line_number":166,"context_line":"}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"#else  /* if 1 */"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"void"},{"line_number":171,"context_line":"tv_randomize(struct timeval *tv)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c1735282_e178d672","line":168,"updated":"2026-07-29 12:01:41.000000000","message":"Does this code still have value? If so, then we should integrate it into the test. If not, maybe just delete it?","commit_id":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"8772936a4766f74955b0cbd12190106d1d5f3e33","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    tv-\u003etv_usec \u003d random() % 100;"},{"line_number":166,"context_line":"}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"#else  /* if 1 */"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"void"},{"line_number":171,"context_line":"tv_randomize(struct timeval *tv)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c52a43d2_a945fe3a","line":168,"in_reply_to":"c1735282_e178d672","updated":"2026-07-29 18:41:56.000000000","message":"Done","commit_id":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ee08af62452e747d9b43879b1a755176cd625b93","unresolved":true,"context_lines":[{"line_number":170,"context_line":"void"},{"line_number":171,"context_line":"tv_randomize(struct timeval *tv)"},{"line_number":172,"context_line":"{"},{"line_number":173,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":174,"context_line":"    long int choice \u003d get_random();"},{"line_number":175,"context_line":"    if ((choice \u0026 0xFF) \u003d\u003d 0)"},{"line_number":176,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"3ce2fabc_9e5f4fc4","line":173,"updated":"2026-07-29 12:01:41.000000000","message":"gc seems to be unused?","commit_id":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"8772936a4766f74955b0cbd12190106d1d5f3e33","unresolved":false,"context_lines":[{"line_number":170,"context_line":"void"},{"line_number":171,"context_line":"tv_randomize(struct timeval *tv)"},{"line_number":172,"context_line":"{"},{"line_number":173,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":174,"context_line":"    long int choice \u003d get_random();"},{"line_number":175,"context_line":"    if ((choice \u0026 0xFF) \u003d\u003d 0)"},{"line_number":176,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"8118172d_b4beb993","line":173,"in_reply_to":"3ce2fabc_9e5f4fc4","updated":"2026-07-29 18:41:56.000000000","message":"Done","commit_id":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2"}],"tests/unit_tests/openvpn/test_schedule.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"9cacf009bf8def1828718af81982575e12da5d2b","unresolved":true,"context_lines":[{"line_number":20,"context_line":" *"},{"line_number":21,"context_line":" *  You should have received a copy of the GNU General Public License along"},{"line_number":22,"context_line":" *  with this program; if not, write to the Free Software Foundation, Inc.,"},{"line_number":23,"context_line":" *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."},{"line_number":24,"context_line":" */"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#ifndef SCHEDULE_TEST_H"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"585e31f0_f653f8b1","line":23,"updated":"2026-07-28 12:04:55.000000000","message":"old style header, please use current one","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"c87aa9160d417383265c4df72517189a826bd760","unresolved":false,"context_lines":[{"line_number":20,"context_line":" *"},{"line_number":21,"context_line":" *  You should have received a copy of the GNU General Public License along"},{"line_number":22,"context_line":" *  with this program; if not, write to the Free Software Foundation, Inc.,"},{"line_number":23,"context_line":" *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."},{"line_number":24,"context_line":" */"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#ifndef SCHEDULE_TEST_H"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c822d468_63f4382d","line":23,"in_reply_to":"585e31f0_f653f8b1","updated":"2026-07-28 12:16:30.000000000","message":"Done","commit_id":"7601d26b4b32d6caaabf806b1a027f82c947a9ad"}]}