)]}'
{"id":"openvpn~1829","triplet_id":"openvpn~master~I5b862eabe032eb4d2229ff5b2f4f6af7406f6f4e","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-07-28 22:26:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-28 23:00:03.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}},"hashtags":[],"change_id":"I5b862eabe032eb4d2229ff5b2f4f6af7406f6f4e","subject":"Correctly calculate packet id size when epoch packet format is in use","status":"MERGED","created":"2026-07-28 18:47:21.000000000","updated":"2026-07-29 16:34:51.000000000","submitted":"2026-07-29 16:34:51.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1829","meta_rev_id":"242c9fc02e689346d63c86f2a6a0657556fb1b5c","_number":1829,"virtual_id_number":1829,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-28 18:47:22.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-07-28 19:06:34.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"e0262869c28f4b548726f8e33af63aeb956471aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-28 18:47:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c1aeb6f8bc15354297f60db3b51fc19bb0d6fe8","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-28 19:06:34.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d24dcfa14e95d75aa7e7c9a1182461fc0af0859d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-28 22:25:08.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0816132e0ca9e1ac1ddf631c634a0277c89347cd","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-07-28 22:26:51.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a4b707de27f6fccba72aeeb832f97ac350423282","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-28 23:00:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"242c9fc02e689346d63c86f2a6a0657556fb1b5c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-29 16:34:51.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2c8baca423b236ab12f7519b68ed88b4a709d0d1","revisions":{"8633bd5a871a62e457eeb592467f2af21678e7b6":{"kind":"REWORK","_number":1,"created":"2026-07-28 18:47:21.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/29/1829/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/1829/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/1 \u0026\u0026 git checkout -b change-1829 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/1829/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2","subject":"Move schedule test to a unit test"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-28 18:43:57.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-28 18:43:57.000000000","tz":120},"subject":"Correctly calculate packet id size when epoch is in use","message":"Correctly calculate packet id size when epoch is in use\n\nEven thought packet_id_long_form has a the same size (8) it is not\nthe same header format (32 bit time + 32 bit IV) as the epoch\nformat (16 bit epoch + 48 IV). Use a simple sizeof(uint64_t) to\navoid suggesting that it might be the same.\n\nCloses: Github #1074\n\nChange-Id: I5b862eabe032eb4d2229ff5b2f4f6af7406f6f4e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"c4c3172a707875fbb49f214adb2c12526d545488":{"kind":"REWORK","_number":2,"created":"2026-07-28 22:25:08.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/29/1829/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/1829/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/2 \u0026\u0026 git checkout -b change-1829 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/1829/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a106971f5cf6983ff862a7c0d8de831cd05b6bb2","subject":"Move schedule test to a unit test"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-28 18:43:57.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-28 22:22:49.000000000","tz":120},"subject":"Correctly calculate packet id size when epoch packet format is in use","message":"Correctly calculate packet id size when epoch packet format is in use\n\nThe code assumed that always when tls mode (without CFB/OFB) is in use\nthat the packet size is 4 bytes. With epoch packet format is incorrect\nas that uses 64 bit.\n\nEven thought packet_id_long_form has a the same size (8 byte) it is not\nthe same header format (32 bit time + 32 bit IV) as the epoch\nformat (16 bit epoch + 48 IV). Use a simple sizeof(uint64_t) to\navoid suggesting that it might be the same.\n\nCloses: Github #1074\n\nChange-Id: I5b862eabe032eb4d2229ff5b2f4f6af7406f6f4e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"2c8baca423b236ab12f7519b68ed88b4a709d0d1":{"kind":"REWORK","_number":3,"created":"2026-07-29 16:34:51.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/29/1829/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/1829/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/3 \u0026\u0026 git checkout -b change-1829 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/1829/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1829/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"74c2a965d39fea89c2fe392663eb699fb1324611","subject":"socket: Never use negative buf-\u003elen in link_socket_read*"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-29 06:41:52.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-07-29 16:28:20.000000000","tz":120},"subject":"Correctly calculate packet id size when epoch packet format is in use","message":"Correctly calculate packet id size when epoch packet format is in use\n\nThe code assumed that always when tls mode (without CFB/OFB) is in use\nthat the packet size is 4 bytes. With epoch packet format is incorrect\nas that uses 64 bit.\n\nEven thought packet_id_long_form has a the same size (8 byte) it is not\nthe same header format (32 bit time + 32 bit IV) as the epoch\nformat (16 bit epoch + 48 IV). Use a simple sizeof(uint64_t) to\navoid suggesting that it might be the same.\n\nGithub: closes OpenVPN/openvpn#1074\n\nChange-Id: I5b862eabe032eb4d2229ff5b2f4f6af7406f6f4e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1829\nMessage-Id: \u003c20260729064158.15731-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37983.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}