)]}'
{"id":"openvpn~1837","triplet_id":"openvpn~master~I728067ef08481c87c7b6918c88ebcaeeec466534","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-08-10 12:27:19.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-10 12:27:19.000000000","reason":"Change was submitted"},"1000030":{"account":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2026-08-10 09:31:47.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I728067ef08481c87c7b6918c88ebcaeeec466534","subject":"Reenable xmit_hold when using p2p tcp-server and tls-server","status":"MERGED","created":"2026-08-05 12:09:53.000000000","updated":"2026-08-10 12:27:19.000000000","submitted":"2026-08-10 12:27:19.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1837","meta_rev_id":"d900846208315a7e719be9f5fa716b8792e47355","_number":1837,"virtual_id_number":1837,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"value":0,"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-05 12:09:53.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-08-05 13:33:29.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2026-08-09 17:51:34.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"state":"REVIEWER"}],"messages":[{"id":"f56e4ef7e1cda8d4bfe2bf0f0f48b92cc3a600b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-05 12:09:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1720e47200b15b25b2cf6dffe30226e22e78dc49","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-05 13:33:29.000000000","message":"Patch Set 1: Code-Review-1\n\n(8 comments)","accounts_in_message":[],"_revision_number":1},{"id":"043fb74b82545e510750572b36279cbebb1f201f","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-05 15:09:54.000000000","message":"Patch Set 1:\n\n(7 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d6085659e2dd67f4ccc4ce648664a4a76f46c776","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-05 15:13:48.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased. Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c953951fb7e9846b58c7498404f5eebf67c1c675","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-08-09 17:51:34.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"114118c3e682bcbbf18ac911d89e867c3a6196d3","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-09 23:05:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1aed16e5f427f1b54df5850a933afe7b7d85ed7d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-09 23:06:06.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased. Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"a83176106e915e7b34bee061fb829cbca17a996e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-09 23:14:11.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"ae14045958eecb60fc5f34c9f15d6fe78f3dcdbe","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-08-10 09:31:47.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d900846208315a7e719be9f5fa716b8792e47355","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-10 12:27:19.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"603aa9698c140d15b7464af8fb83bd2aa71da680","revisions":{"b55b3d3d525662ec8f138a9ca86592c3ba58c33b":{"kind":"REWORK","_number":1,"created":"2026-08-05 12:09:53.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/37/1837/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/37/1837/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/1 \u0026\u0026 git checkout -b change-1837 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/37/1837/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d1e67f419f1ea9121d44fa4b91c59e7209785e57","subject":"ssl: Ignore hard reset packets with a non-zero packet id"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-05 12:00:51.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-05 12:06:40.000000000","tz":120},"subject":"Reenable xmit_hold when using  p2p tcp-server and tls-server","message":"Reenable xmit_hold when using  p2p tcp-server and tls-server\n\nCommit 619c3e9 changed the logic to only enable xmit_hold only\nwhen c-\u003emode is CM_CHILD_TOP. This works for the --mode server\nwas probably done to allow this to properly work when the server\nis listening on multiple sockets and options-\u003ece.proto cannot be\nanymore to determine if this socket is tcp or udp.\n\nRestore the logic for p2p logic to avoid both sides starting sending\nreset at the same time.\n\nChange-Id: I728067ef08481c87c7b6918c88ebcaeeec466534\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"d8a9c1d752e81e5aeaaeaf74f73a56130b97d7af":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-08-05 15:13:48.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/37/1837/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/37/1837/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/2 \u0026\u0026 git checkout -b change-1837 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/37/1837/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"50fb34ce46a128825076f24dbc0309c26d842ff2","subject":"interactive: forbid \"--setenv opt\" in startup data"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-05 12:00:51.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-05 15:05:34.000000000","tz":120},"subject":"Reenable xmit_hold when using p2p tcp-server and tls-server","message":"Reenable xmit_hold when using p2p tcp-server and tls-server\n\nCommit 619c3e9 changed the logic to enable xmit_hold only\nwhen c-\u003emode is CM_CHILD_TOP. This works for --mode server and\nwas probably done to allow  to properly work when the server\nis listening on multiple sockets and options-\u003ece.proto cannot be used\nto determine if this socket is tcp or udp.\n\nRestore the logic for p2p to avoid both sides starting sending\nresets at the same time.\n\nCloses: openvpn/openvpn#1089\nChange-Id: I728067ef08481c87c7b6918c88ebcaeeec466534\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"dbd79e213684a510530c1e9bcd57afad5a654523":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-08-09 23:06:06.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/37/1837/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/37/1837/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/3 \u0026\u0026 git checkout -b change-1837 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/37/1837/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d42a9912c1d62006323a12af86baa148c77592e9","subject":"Add check that username is identical to multi float"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-05 12:00:51.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-09 23:00:00.000000000","tz":120},"subject":"Reenable xmit_hold when using p2p tcp-server and tls-server","message":"Reenable xmit_hold when using p2p tcp-server and tls-server\n\nCommit 619c3e9 changed the logic to enable xmit_hold only\nwhen c-\u003emode is CM_CHILD_TOP. This works for --mode server and\nwas probably done to allow to properly work when the server\nis listening on multiple sockets and options-\u003ece.proto cannot be used\nto determine if this socket is tcp or udp.\n\nRestore the logic for p2p to avoid both sides starting sending\nresets at the same time.\n\nCloses: openvpn/openvpn#1089\nChange-Id: I728067ef08481c87c7b6918c88ebcaeeec466534\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"b059b5d88eabdecb0316326b52c2bdd6108d540e":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2026-08-09 23:14:11.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/37/1837/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/37/1837/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/4 \u0026\u0026 git checkout -b change-1837 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/37/1837/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d42a9912c1d62006323a12af86baa148c77592e9","subject":"Add check that username is identical to multi float"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-05 12:00:51.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-09 23:13:48.000000000","tz":120},"subject":"Reenable xmit_hold when using p2p tcp-server and tls-server","message":"Reenable xmit_hold when using p2p tcp-server and tls-server\n\nCommit 619c3e9 changed the logic to enable xmit_hold only\nwhen c-\u003emode is CM_CHILD_TCP. This works for --mode server and\nwas probably done to allow to properly work when the server\nis listening on multiple sockets and options-\u003ece.proto cannot be used\nto determine if this socket is tcp or udp.\n\nRestore the logic for p2p to avoid both sides starting sending\nresets at the same time.\n\nCloses: openvpn/openvpn#1089\nChange-Id: I728067ef08481c87c7b6918c88ebcaeeec466534\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"603aa9698c140d15b7464af8fb83bd2aa71da680":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2026-08-10 12:27:19.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/37/1837/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/37/1837/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/5 \u0026\u0026 git checkout -b change-1837 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/37/1837/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/37/1837/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d42a9912c1d62006323a12af86baa148c77592e9","subject":"Add check that username is identical to multi float"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-08-10 11:42:06.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-08-10 12:19:33.000000000","tz":120},"subject":"Reenable xmit_hold when using p2p tcp-server and tls-server","message":"Reenable xmit_hold when using p2p tcp-server and tls-server\n\nCommit 619c3e9 changed the logic to enable xmit_hold only\nwhen c-\u003emode is CM_CHILD_TCP. This works for --mode server and\nwas probably done to allow to properly work when the server\nis listening on multiple sockets and options-\u003ece.proto cannot be used\nto determine if this socket is tcp or udp.\n\nRestore the logic for p2p to avoid both sides starting sending\nresets at the same time.\n\nGithub: closes OpenVPN/openvpn#1089\nChange-Id: I728067ef08481c87c7b6918c88ebcaeeec466534\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1837\nMessage-Id: \u003c20260810114212.28379-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38265.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}