)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"ee53bc3e22552ea4d97047c13493a149592fb75d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4cf6d39b_b4956634","updated":"2026-08-17 10:08:18.000000000","message":"Is this a squash gone wrong? The patch does a lot more than the stated commit message, and the part where it does more doesn\u0027t build.","commit_id":"c35df952df85077d28b8b848f00ef5d450ce84ad"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0b59bead892ca1b8ca3ef987000bf0542417c6e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41987862_fe358f44","in_reply_to":"4cf6d39b_b4956634","updated":"2026-08-17 12:58:00.000000000","message":"Yeah, something really gone wrong here. I will redo the patch.,","commit_id":"c35df952df85077d28b8b848f00ef5d450ce84ad"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"5f9bc5f740071c4852d0fa1f314c11659b0fa520","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77f775d7_b5d470a6","updated":"2026-08-17 13:21:18.000000000","message":"This now looks good, just a couple of more nits:\n\n1. I think it\u0027s GiB not GB.\n\n2. I\u0027ve grepped for \u0027 16 \u0027 in the code and we have now-stale references to the old value in crypto_epoch.c (lines 311 and 312). Maybe we want to say something like \"\"at most epoch_data_keys_future_count keys\" there to avoid future cases where this goes out of sync?","commit_id":"79f87e8fa83b20485262f5a50497d621febc5e40"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"923630877be9041cdade4cb585020cd5f9d7a97d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef04bafd_b6b07fba","in_reply_to":"26c4d70d_19ff54d8","updated":"2026-08-17 13:43:06.000000000","message":"The comment still says GB (not GiB):\n\n     * One epoch lasts 910 GB with 128 byte packets or 78s at 100 GBit/s.\n     * (respectively 1011 GB and 86s with 1280 byte packets).\n\nDid I calculate wrong and GB is correct?","commit_id":"79f87e8fa83b20485262f5a50497d621febc5e40"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a14e0b227cf98b0b2c1c2afde95492599fea42dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26c4d70d_19ff54d8","in_reply_to":"77f775d7_b5d470a6","updated":"2026-08-17 13:36:33.000000000","message":"Done. I added a more explicit epoch_data_keys_future_count but also kept the real number since I don\u0027t think we will change this often.","commit_id":"79f87e8fa83b20485262f5a50497d621febc5e40"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"3279d4784b62c52e993a6e1657f0d8e8b8d7bab3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5aec6086_91b5b606","in_reply_to":"ef04bafd_b6b07fba","updated":"2026-08-17 14:06:38.000000000","message":"No I forgot to change this.","commit_id":"79f87e8fa83b20485262f5a50497d621febc5e40"}],"src/openvpn/ssl.c":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"ee53bc3e22552ea4d97047c13493a149592fb75d","unresolved":true,"context_lines":[{"line_number":1997,"context_line":"             * mismatched ping */"},{"line_number":1998,"context_line":"            if (session-\u003eopt-\u003eping_rec_timeout)"},{"line_number":1999,"context_line":"            {"},{"line_number":2000,"context_line":"                buf_printf(\u0026out, \"P\u003d%d\\n\", session-\u003eopt-\u003eping_rec_timeout);"},{"line_number":2001,"context_line":"            }"},{"line_number":2002,"context_line":"        }"},{"line_number":2003,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f2a53ae7_00e7b2f9","line":2000,"updated":"2026-08-17 10:08:18.000000000","message":"This actually does not build:\n\nssl.c: In function ‘push_peer_info’:\nssl.c:1998:31: error: ‘struct tls_options’ has no member named ‘ping_rec_timeout’; did you mean ‘packet_timeout’?\n 1998 |             if (session-\u003eopt-\u003eping_rec_timeout)\n      |                               ^~~~~~~~~~~~~~~~\n      |                               packet_timeout\nssl.c:2000:58: error: ‘struct tls_options’ has no member named ‘ping_rec_timeout’; did you mean ‘packet_timeout’?\n 2000 |                 buf_printf(\u0026out, \"P\u003d%d\\n\", session-\u003eopt-\u003eping_rec_timeout);\n      |                                                          ^~~~~~~~~~~~~~~~\n      |                                                          packet_timeout","commit_id":"c35df952df85077d28b8b848f00ef5d450ce84ad"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0b59bead892ca1b8ca3ef987000bf0542417c6e4","unresolved":false,"context_lines":[{"line_number":1997,"context_line":"             * mismatched ping */"},{"line_number":1998,"context_line":"            if (session-\u003eopt-\u003eping_rec_timeout)"},{"line_number":1999,"context_line":"            {"},{"line_number":2000,"context_line":"                buf_printf(\u0026out, \"P\u003d%d\\n\", session-\u003eopt-\u003eping_rec_timeout);"},{"line_number":2001,"context_line":"            }"},{"line_number":2002,"context_line":"        }"},{"line_number":2003,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"39eef646_1c164414","line":2000,"in_reply_to":"f2a53ae7_00e7b2f9","updated":"2026-08-17 12:58:00.000000000","message":"Done","commit_id":"c35df952df85077d28b8b848f00ef5d450ce84ad"}]}