)]}'
{"id":"openvpn~1846","triplet_id":"openvpn~master~I12bef330e2c8a5e5b21c2fa807584319b2b7101f","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-10-17 19:36:19.000000000","reason":"removed on reply"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-20 13:09:06.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-10-20 13:09:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I12bef330e2c8a5e5b21c2fa807584319b2b7101f","subject":"Factor out address resolve code to a new file resolve.c","status":"MERGED","created":"2026-08-17 12:08:15.000000000","updated":"2026-10-20 13:09:06.000000000","submitted":"2026-10-20 13:09:06.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1846","meta_rev_id":"d3538c374284671af97f40dcb6a3b4f3fde0d802","_number":1846,"virtual_id_number":1846,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-17 12:08:19.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-08-17 12:08:19.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-19 07:38:42.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"88895848bd985c80f76bb6eca4a289592187750f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-17 12:08:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87e1f0b359b693740e0a20065bb3eacd07ddb476","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-17 14:13:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d268f5d0075198bbd5dd85237fd385ae9bb23099","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-19 07:38:42.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"202e086855b09734137abe8cc676f2903f69b459","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 15:39:10.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"37fa9a85d684114f2f942d850a62faf246d88a8c","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 15:39:25.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"63c6c31e7f50d2157df359af3a85040c88b05fb3","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-19 15:40:41.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8a1eb4519e6f4f9618847c3fda5c43487fa16bed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-14 13:18:47.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"3cd1845781f9a7ab810764bc306de323921d8b4d","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-17 19:36:19.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d3538c374284671af97f40dcb6a3b4f3fde0d802","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-20 13:09:06.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"c83d2f22bbbfc81b4375d366972ccb338cf526a6","revisions":{"e2ff0fc4c7e12f0cf70d60bf29f7caf463b9a285":{"kind":"REWORK","_number":1,"created":"2026-08-17 12:08:15.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/46/1846/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/1846/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/1 \u0026\u0026 git checkout -b change-1846 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/1846/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fbc7c22c0298983a1fd66591b87b04edd465799c","subject":"options: Move string utility functions to buffer"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-17 11:57:38.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-17 12:07:16.000000000","tz":120},"subject":"Factor out address resolve code to a new file resolve.c","message":"Factor out address resolve code to a new file resolve.c\n\nThe code was weirdly split between socket.c, socket_util.c,\nand options.c. The new structure makes more sense.\n\nWhile here move some related string helper code to buffer.h.\n\nChange-Id: I12bef330e2c8a5e5b21c2fa807584319b2b7101f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"fb4e826c65887f4433d18f193b1ded8a80330b73":{"kind":"REWORK","_number":2,"created":"2026-08-17 14:13:19.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/46/1846/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/1846/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/2 \u0026\u0026 git checkout -b change-1846 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/1846/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1c9829deefea6c86f4704d0ac9d2866af4c0b441","subject":"options: Move string utility functions to buffer"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-17 11:57:38.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-17 14:08:59.000000000","tz":120},"subject":"Factor out address resolve code to a new file resolve.c","message":"Factor out address resolve code to a new file resolve.c\n\nThe code was weirdly split between socket.c, socket_util.c,\nand options.c. The new structure makes more sense.\n\nWhile here move some related string helper code to buffer.h.\n\nChange-Id: I12bef330e2c8a5e5b21c2fa807584319b2b7101f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"82c8562de76089838ee7b4ad609aa6ab92f3bddc":{"kind":"REWORK","_number":3,"created":"2026-08-19 15:39:10.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/46/1846/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/1846/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/3 \u0026\u0026 git checkout -b change-1846 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/1846/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43ecd1c1cc1309d338ce4b50f5e45b7b81b1a193","subject":"options: Move string utility functions to buffer"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-17 11:57:38.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 15:38:54.000000000","tz":120},"subject":"Factor out address resolve code to a new file resolve.c","message":"Factor out address resolve code to a new file resolve.c\n\nThe code was weirdly split between socket.c, socket_util.c,\nand options.c. The new structure makes more sense.\n\nWhile here move some related string helper code to buffer.h.\n\nChange-Id: I12bef330e2c8a5e5b21c2fa807584319b2b7101f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"27536b037fb0b147d040876515a831b5604f7c10":{"kind":"REWORK","_number":4,"created":"2026-10-14 13:18:47.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/46/1846/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/1846/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/4 \u0026\u0026 git checkout -b change-1846 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/1846/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15a1465f981bb3f1950056a8f82b91dfe5f3fdbc","subject":"Make CRL reload EOF detection independent of stale error queue entries"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-17 11:57:38.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-14 13:16:34.000000000","tz":120},"subject":"Factor out address resolve code to a new file resolve.c","message":"Factor out address resolve code to a new file resolve.c\n\nThe code was weirdly split between socket.c, socket_util.c,\nand options.c. The new structure makes more sense.\n\nWhile here move some related string helper code to buffer.h.\n\nChange-Id: I12bef330e2c8a5e5b21c2fa807584319b2b7101f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c83d2f22bbbfc81b4375d366972ccb338cf526a6":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-10-20 13:09:06.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/46/1846/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/1846/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/5 \u0026\u0026 git checkout -b change-1846 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/1846/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/1846/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f1f9d72cbf41127ee5e2a7c75971b9a4ee2d670","subject":"packet_id: Avoid conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-18 15:28:55.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-20 12:31:26.000000000","tz":120},"subject":"Factor out address resolve code to a new file resolve.c","message":"Factor out address resolve code to a new file resolve.c\n\nThe code was weirdly split between socket.c, socket_util.c,\nand options.c. The new structure makes more sense.\n\nWhile here move some related string helper code to buffer.h.\n\nChange-Id: I12bef330e2c8a5e5b21c2fa807584319b2b7101f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1846\nMessage-Id: \u003c20261018152900.22589-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg40027.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}