)]}'
{"id":"openvpn~1847","triplet_id":"openvpn~master~I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879","project":"openvpn","branch":"master","topic":"reformat-shell","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-08-19 15:03:14.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-19 15:03:14.000000000","reason":"Change was submitted"},"1000053":{"account":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-08-19 13:33:26.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879","subject":"gen-release-tarballs.sh: Remove","status":"MERGED","created":"2026-08-19 11:42:39.000000000","updated":"2026-08-19 15:03:14.000000000","submitted":"2026-08-19 15:03:14.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1847-reformat-shell","meta_rev_id":"c4abe2600103f23e8a86dde75282fcf68bd5f9db","_number":1847,"virtual_id_number":1847,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-19 11:42:43.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-08-19 11:42:43.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-19 11:49:57.000000000","updated_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"},{"updated":"2026-08-19 13:26:35.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"a706b7af3fd433bc93f2584452124d2e8bbbf922","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 11:42:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0c31158b22e35394c18f03cfdbb9a81df40bc005","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-19 11:49:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e53024abce5a712ded7333105f0229a3e4613176","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-19 12:07:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4a7518fb39af8b4567e51490707506ea48360997","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 13:18:58.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"94f4e71607602478759ce4bacdfb7a6fa13d3fe2","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 13:20:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"03232582edcaf935e8f231867f5db52ca59fed09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 13:21:17.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"59423f3fc4113c9ed1260005bc4a76b92545eeba","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-19 13:26:35.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"898862b5301cad4f02b5e2d5029df40cf7b03a08","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-19 13:33:26.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c4abe2600103f23e8a86dde75282fcf68bd5f9db","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-19 15:03:14.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2b3df1ed0f0207a1df6ffa4640457655ab2aa10c","revisions":{"532f87b9cc89ae14ead0d9cd9884792e704f9a49":{"kind":"REWORK","_number":1,"created":"2026-08-19 11:42:39.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/47/1847/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1847/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/1 \u0026\u0026 git checkout -b change-1847 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1847/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89a5c5351028d351ce4f3f093e49dd4168d86638","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 11:32:00.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 11:39:12.000000000","tz":120},"subject":"gen-release-tarballs.sh: Fix some shell issues","message":"gen-release-tarballs.sh: Fix some shell issues\n\n- Force bash, this script uses {gz,xz} style globs which\n  are a bashism.\n- Change a `` with nested \"\" to $(). The current code\n  is correct but shfmt would do this conversion wrong,\n  so do it manually now.\n\nChange-Id: I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3eedb5f7320dd04d6e03d3bd276844115724f1c5":{"kind":"REWORK","_number":2,"created":"2026-08-19 13:18:58.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/47/1847/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1847/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/2 \u0026\u0026 git checkout -b change-1847 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1847/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89a5c5351028d351ce4f3f093e49dd4168d86638","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 11:32:00.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 13:16:55.000000000","tz":120},"subject":"gen-release-tarballs.sh: Remove","message":"gen-release-tarballs.sh: Remove\n\nThis is unused (all our releases use code in openvpn-build\nrepository insted) and of doubtful use. E.g. why would we\nneed three different tarballs for releases?\n\nIt also has small issues like using a /bin/sh shebang but\ncontaining bashisms.\n\nSo get rid of the dead code.\n\nChange-Id: I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"1fb0b5f4ecbdacdf2ccf0596d57363adc405c1d7":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-08-19 13:21:17.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/47/1847/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1847/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/3 \u0026\u0026 git checkout -b change-1847 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1847/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89a5c5351028d351ce4f3f093e49dd4168d86638","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 11:32:00.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 13:21:06.000000000","tz":120},"subject":"gen-release-tarballs.sh: Remove","message":"gen-release-tarballs.sh: Remove\n\nThis is unused (all our releases use code in openvpn-build\nrepository instead) and of doubtful use. E.g. why would we\nneed three different tarballs for releases?\n\nIt also has small issues like using a /bin/sh shebang but\ncontaining bashisms.\n\nSo get rid of the dead code.\n\nChange-Id: I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2b3df1ed0f0207a1df6ffa4640457655ab2aa10c":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2026-08-19 15:03:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/47/1847/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1847/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/4 \u0026\u0026 git checkout -b change-1847 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1847/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1847/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89a5c5351028d351ce4f3f093e49dd4168d86638","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 13:26:46.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-08-19 15:02:32.000000000","tz":120},"subject":"gen-release-tarballs.sh: Remove","message":"gen-release-tarballs.sh: Remove\n\nThis is unused (all our releases use code in openvpn-build\nrepository instead) and of doubtful use. E.g. why would we\nneed three different tarballs for releases?\n\nIt also has small issues like using a /bin/sh shebang but\ncontaining bashisms.\n\nSo get rid of the dead code.\n\nChange-Id: I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1847\nMessage-Id: \u003c20260819132652.24207-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38509.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}