)]}'
{"src/openvpn/mbedtls_compat.h":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"205d044ef815dd8f10b41e808b995665c218710a","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        ASSERT(mbed_ok(psa_export_public_key(prv-\u003eMBEDTLS_PRIVATE(priv_id),"},{"line_number":238,"context_line":"                                             (uint8_t *)prv-\u003eMBEDTLS_PRIVATE(pub_raw),"},{"line_number":239,"context_line":"                                             sizeof(prv-\u003eMBEDTLS_PRIVATE(pub_raw)),"},{"line_number":240,"context_line":"                                             (size_t *)\u0026prv-\u003eMBEDTLS_PRIVATE(pub_raw_len))));"},{"line_number":241,"context_line":"    }"},{"line_number":242,"context_line":"#endif"},{"line_number":243,"context_line":"    return mbedtls_pk_check_pair(pub, prv);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7bf7e771_e75277ab","line":240,"updated":"2026-08-20 10:28:50.000000000","message":"These two casts would build even if the types of the variables would change in the future.\n\nWould it be good to cast the whole thing upfront, then no longer require the cast, e.g. `mbedtls_pk_context *mut_prv \u003d (mbedtls_pk_context *)prv;` + use `mut_prv` (with no casts for individual data members)?","commit_id":"63603d64043f4ffc0761d964988ccddc36772709"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"dec678032d853e4b48c4b3d6d4f62870c27ca7ef","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        ASSERT(mbed_ok(psa_export_public_key(prv-\u003eMBEDTLS_PRIVATE(priv_id),"},{"line_number":238,"context_line":"                                             (uint8_t *)prv-\u003eMBEDTLS_PRIVATE(pub_raw),"},{"line_number":239,"context_line":"                                             sizeof(prv-\u003eMBEDTLS_PRIVATE(pub_raw)),"},{"line_number":240,"context_line":"                                             (size_t *)\u0026prv-\u003eMBEDTLS_PRIVATE(pub_raw_len))));"},{"line_number":241,"context_line":"    }"},{"line_number":242,"context_line":"#endif"},{"line_number":243,"context_line":"    return mbedtls_pk_check_pair(pub, prv);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0b52619d_3c0b293e","line":240,"in_reply_to":"7bf7e771_e75277ab","updated":"2026-08-21 13:07:41.000000000","message":"If I understand it correctly, we\u0027ll only need to do this for versions 4.1 and 4.2.0. If a fixed version is released, I\u0027d just add MBEDTLS_VERSION_NUMBER \u003c ...\n\nMaybe we could do that preemptively so we don\u0027t forget later but I\u0027m not sure if the fix will be in 4.2.1 or 4.3.0.","commit_id":"63603d64043f4ffc0761d964988ccddc36772709"}]}