)]}'
{"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"a241b7ae70bf85aeec5c3516b1ccdc61c34ee19a","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"    if (err)"},{"line_number":1226,"context_line":"    {"},{"line_number":1227,"context_line":"        PWSTR wide_name \u003d utf8to16(itf_name);"},{"line_number":1228,"context_line":"        MsgToEventLog(M_ERR, L\"%S: failed to convert itf alias \u0027%s\u0027\", __func__, wide_name);"},{"line_number":1229,"context_line":"        free(wide_name);"},{"line_number":1230,"context_line":"        goto out;"},{"line_number":1231,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8c4d92b3_b1aef36b","line":1228,"updated":"2026-08-24 08:50:10.000000000","message":"This is probably correct and Windows can deal with it, but `wide_name` _can_ be `NULL` here (especially in allocator failure situations - `ERROR_OUTOFMEMORY`).\n\nSo whether this patch is correct or not depends on how safe it is to pass `NULL` into `%s` here.","commit_id":"4cccdf6e27b97d01e33a9b95ddc6ea1f1252dc24"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"3772e741eb7e62a2aa1b1a3aa48b9df79e1cc3f1","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    if (err)"},{"line_number":1226,"context_line":"    {"},{"line_number":1227,"context_line":"        PWSTR wide_name \u003d utf8to16(itf_name);"},{"line_number":1228,"context_line":"        MsgToEventLog(M_ERR, L\"%S: failed to convert itf alias \u0027%s\u0027\", __func__, wide_name);"},{"line_number":1229,"context_line":"        free(wide_name);"},{"line_number":1230,"context_line":"        goto out;"},{"line_number":1231,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7669db36_0e096c45","line":1228,"in_reply_to":"8c4d92b3_b1aef36b","updated":"2026-08-24 15:28:01.000000000","message":"Yeah, spent a thought on this, but vswprintf() (called in MsgToEventLog) handles NULL arguments and prints \"(null)\". Only the _s version of the functions halts the program.","commit_id":"4cccdf6e27b97d01e33a9b95ddc6ea1f1252dc24"}]}