)]}'
{"id":"openvpn~1866","triplet_id":"openvpn~master~Iad13c3bf73dbe073e52ede504ced7fb2f6a9b71d","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-08-25 07:35:52.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-25 07:35:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iad13c3bf73dbe073e52ede504ced7fb2f6a9b71d","subject":"mroute: Remove unused functions","status":"MERGED","created":"2026-08-24 11:22:43.000000000","updated":"2026-08-25 07:35:52.000000000","submitted":"2026-08-25 07:35:52.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1866-cppcheck","meta_rev_id":"5500331b4138e6802a31faa97d51e484100f03b5","_number":1866,"virtual_id_number":1866,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-24 11:22:54.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-08-24 11:22:54.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-24 16:17:30.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"ea77ba56fcf534ef082aeacf169749d894683483","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-24 11:22:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"852eeae790b6bf4f6ccfbbf95b32819cb7d6050e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-24 11:24:55.000000000","message":"Topic set to cppcheck","accounts_in_message":[],"_revision_number":1},{"id":"4f50f5443daf2388e0ed1d1146c93d5ec2503745","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-24 16:17:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5500331b4138e6802a31faa97d51e484100f03b5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-25 07:35:52.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"de5381481584165cf83a0b8b423e2efab40ebd9f","revisions":{"f849b0a40256ce97961b9da5ff2ca96626e37a3e":{"kind":"REWORK","_number":1,"created":"2026-08-24 11:22:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/66/1866/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1866/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/1 \u0026\u0026 git checkout -b change-1866 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/66/1866/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"48b7adb1a9cc67261a820bc1be2b548794c221d9","subject":"route: Remove unused function print_routes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-24 11:14:02.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-24 11:18:47.000000000","tz":120},"subject":"mroute: Remove unused functions","message":"mroute: Remove unused functions\n\nBoth of these have been unused since commit\n1308ccec9f85418b088723bb870855c0a933311b\n(\"Remove support for PF\").\nThe first is ipv4 specific and very limited in scope.\nThe second is equivalent to just using CLEAR (at least\nin actual usage).\nSo I think both can safely be removed.\n\nIdentified by cppcheck.\n\nChange-Id: Iad13c3bf73dbe073e52ede504ced7fb2f6a9b71d\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"de5381481584165cf83a0b8b423e2efab40ebd9f":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-08-25 07:35:52.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/66/1866/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1866/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/2 \u0026\u0026 git checkout -b change-1866 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/66/1866/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1866/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"47ec9ef53cfaaaa119724bfb03d152b5f98bd269","subject":"route: Remove unused function print_routes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-24 16:17:38.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-08-25 07:34:10.000000000","tz":120},"subject":"mroute: Remove unused functions","message":"mroute: Remove unused functions\n\nBoth of these have been unused since commit\n1308ccec9f85418b088723bb870855c0a933311b\n(\"Remove support for PF\").\nThe first is ipv4 specific and very limited in scope.\nThe second is equivalent to just using CLEAR (at least\nin actual usage).\nSo I think both can safely be removed.\n\nIdentified by cppcheck.\n\nChange-Id: Iad13c3bf73dbe073e52ede504ced7fb2f6a9b71d\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1866\nMessage-Id: \u003c20260824161743.2156-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38645.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}