)]}'
{"id":"openvpn~1868","triplet_id":"openvpn~master~I65beb37a2d822333aa888de1baf11dfcb8490e90","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-09-07 17:09:38.000000000","reason":"removed on reply"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-08 07:33:50.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-09-08 07:33:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I65beb37a2d822333aa888de1baf11dfcb8490e90","subject":"run-cppcheck.sh: Make it more configurable","status":"MERGED","created":"2026-08-25 15:45:20.000000000","updated":"2026-09-08 07:33:50.000000000","submitted":"2026-09-08 07:33:50.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1868-cppcheck","meta_rev_id":"53f4f10b953fc07979e56bc67a7c7ce4cb28139a","_number":1868,"virtual_id_number":1868,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-25 15:45:26.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-08-25 15:45:26.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-30 18:01:19.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"CC"},{"updated":"2026-09-07 17:09:38.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"abe714b93afc10cde25e30fae6adad6b585d5b49","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-25 15:45:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"32110daf3784db2fcc7441af887def0835f06ae7","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-30 18:01:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"645b7071c6d48884f5ae0f8d3129049edba06fa7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-07 15:22:09.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"3e163c5d75e706537379281bd3c1ddce22279fe3","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-07 15:24:54.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dca19bb43d6b3aa6a0de7b760971a14f77d2e574","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-07 15:44:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d22c57fe72647d0dabd6c1a60ff27c08226f3539","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-07 16:01:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"38e687298e31d0fd75da9faab0cc648c31e1aa6f","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-07 16:01:47.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"94904c6188cd481cd41faedb27ed28220a2aedf3","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-07 17:09:38.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"5be72094ab0c9ba8105031b4a4c993a9c5af4f96","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-07 21:03:55.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"53f4f10b953fc07979e56bc67a7c7ce4cb28139a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-08 07:33:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"28ec0f90fd5e4da73d9a0246fcb43d20150943ab","revisions":{"5666e7ada4aee52a1277fc8f24614b6d9f2f418e":{"kind":"REWORK","_number":1,"created":"2026-08-25 15:45:20.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/1868/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1868/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/1 \u0026\u0026 git checkout -b change-1868 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/68/1868/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d818506d565af43c394ce0f5ba2420806401642","subject":"buffer: Remove some useless casts on BLAST returns"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-25 13:04:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-25 13:30:11.000000000","tz":120},"subject":"run-cppcheck.sh: Make it more configurable","message":"run-cppcheck.sh: Make it more configurable\n\n- Allow to easily control verbosity and automatically\n  adjust to the verbosity of the Make run\n- Allow to easily control check level. With exhaustive the\n  check can take hours (due to options.c), so we couldn\u0027t\n  use that in CI\n\nChange-Id: I65beb37a2d822333aa888de1baf11dfcb8490e90\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"dc8cc058476b674a71a87f51f25ced18221aaf09":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-09-07 15:22:09.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/1868/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1868/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/2 \u0026\u0026 git checkout -b change-1868 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/68/1868/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22a24132da88b6be9f121e4c6e74c18a46e7741f","subject":"Check for \\0 and RFC 2253 chars in cert subjects"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-25 13:04:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 15:20:33.000000000","tz":120},"subject":"run-cppcheck.sh: Make it more configurable","message":"run-cppcheck.sh: Make it more configurable\n\n- Allow to easily control verbosity and automatically\n  adjust to the verbosity of the Make run\n- Allow to easily control check level. With exhaustive the\n  check can take hours (due to options.c), so we couldn\u0027t\n  use that in CI\n\nChange-Id: I65beb37a2d822333aa888de1baf11dfcb8490e90\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6c839553075328e0103ee33d0fb6c26f1e50a2e2":{"kind":"REWORK","_number":3,"created":"2026-09-07 16:01:27.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/1868/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1868/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/3 \u0026\u0026 git checkout -b change-1868 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/68/1868/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22a24132da88b6be9f121e4c6e74c18a46e7741f","subject":"Check for \\0 and RFC 2253 chars in cert subjects"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-25 13:04:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 15:59:53.000000000","tz":120},"subject":"run-cppcheck.sh: Make it more configurable","message":"run-cppcheck.sh: Make it more configurable\n\n- Allow to easily control verbosity and automatically\n  adjust to the verbosity of the Make run\n- Allow to easily control check level. With exhaustive the\n  check can take hours (due to options.c), so we couldn\u0027t\n  use that in CI\n\nv3:\n- Use AM_V_P instead of V to correctly reflect\n  AM_DEFAULT_VERBOSITY\n\nChange-Id: I65beb37a2d822333aa888de1baf11dfcb8490e90\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"dac08c156a18733f6dd8e687ea3a3572a5b1782a":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-09-07 21:03:55.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/1868/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1868/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/4 \u0026\u0026 git checkout -b change-1868 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/68/1868/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"57b1f870a76dbe94dbf8dc6a4d22d1a225a42578","subject":"Convert Changes.rst to Markdown"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-25 13:04:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 20:43:04.000000000","tz":120},"subject":"run-cppcheck.sh: Make it more configurable","message":"run-cppcheck.sh: Make it more configurable\n\n- Allow to easily control verbosity and automatically\n  adjust to the verbosity of the Make run\n- Allow to easily control check level. With exhaustive the\n  check can take hours (due to options.c), so we couldn\u0027t\n  use that in CI\n\nv3:\n- Use AM_V_P instead of V to correctly reflect\n  AM_DEFAULT_VERBOSITY\n\nChange-Id: I65beb37a2d822333aa888de1baf11dfcb8490e90\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"28ec0f90fd5e4da73d9a0246fcb43d20150943ab":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2026-09-08 07:33:50.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/68/1868/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1868/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/5 \u0026\u0026 git checkout -b change-1868 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/68/1868/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1868/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"57b1f870a76dbe94dbf8dc6a4d22d1a225a42578","subject":"Convert Changes.rst to Markdown"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 18:17:49.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-08 07:31:36.000000000","tz":120},"subject":"run-cppcheck.sh: Make it more configurable","message":"run-cppcheck.sh: Make it more configurable\n\n- Allow to easily control verbosity and automatically\n  adjust to the verbosity of the Make run\n- Allow to easily control check level. With exhaustive the\n  check can take hours (due to options.c), so we couldn\u0027t\n  use that in CI\n\nv3:\n- Use AM_V_P instead of V to correctly reflect\n  AM_DEFAULT_VERBOSITY\n\nChange-Id: I65beb37a2d822333aa888de1baf11dfcb8490e90\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1868\nMessage-Id: \u003c20260907181754.13356-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39000.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
