)]}'
{"id":"openvpn~1891","triplet_id":"openvpn~master~I68429deb39c0bae335d46a4170973a14c644ccf9","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-02 15:35:40.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-09-02 15:35:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I68429deb39c0bae335d46a4170973a14c644ccf9","subject":"win32: quote arguments that cmd.exe would reinterpret","status":"MERGED","created":"2026-09-01 20:48:28.000000000","updated":"2026-09-02 15:35:40.000000000","submitted":"2026-09-02 15:35:40.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1891","meta_rev_id":"305c7bcf29fba3c5bcb25f525ddfe9f3c3af9c03","_number":1891,"virtual_id_number":1891,"owner":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-01 20:48:29.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-01 20:48:29.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-02 12:11:16.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"70531c84b1b5e80baca9a9247d96f802fd04f86c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-01 20:48:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b2b8efcc06f412c0377b5258ef2b34e9d40d4fb1","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-09-02 12:11:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"305c7bcf29fba3c5bcb25f525ddfe9f3c3af9c03","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-02 15:35:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cf08504bbbacdb0c3d94c7a0358a6ec06c553cdd","revisions":{"8de20c8c1408935ebb47b395edb637de4e6818e9":{"kind":"REWORK","_number":1,"created":"2026-09-01 20:48:28.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/91/1891/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1891/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/1 \u0026\u0026 git checkout -b change-1891 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/91/1891/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"90ab7be00e73d06f7a5bf72e6a454fcfd5f2818c","subject":"networking_sitnl: validate netlink replies against the request"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-08-10 12:17:14.000000000","tz":180},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-01 20:32:21.000000000","tz":120},"subject":"win32: quote arguments that cmd.exe would reinterpret","message":"win32: quote arguments that cmd.exe would reinterpret\n\nwide_cmd_line() only quoted arguments containing a space, so \u0026 | \u003c \u003e ^ %\n( ) and ! were passed unquoted. CreateProcess() runs .bat and .cmd files\nthrough cmd.exe, which parses the command line again, so a certificate\nsubject passed to --tls-verify could start a second command (CERT/CC\nVU#123335).\n\nQuote on those characters too. Double quotes are already replaced with\n\u0027_\u0027, so nothing else needs escaping. The delimiters , ; and \u003d are left\nout: cmd.exe uses them to separate %1..%9 but cannot run anything with\nthem, and quoting them would change what existing scripts receive.\n\nGitHub: OpenVPN/openvpn-private-issues#159\nReported-By: Clouditera Security; Z.ai Security; NSFOCUS \u003csecurity@clouditera.com\u003e\nCVE: 2026-84256\nChange-Id: I68429deb39c0bae335d46a4170973a14c644ccf9\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"cf08504bbbacdb0c3d94c7a0358a6ec06c553cdd":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-09-02 15:35:40.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/91/1891/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1891/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/2 \u0026\u0026 git checkout -b change-1891 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/91/1891/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/1891/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"03f8b88898b06d0d0acb3bded18eba82fa2e6277","subject":"tapctl: prevent binary planting with netsh"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-02 12:14:09.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-02 15:16:39.000000000","tz":120},"subject":"win32: quote arguments that cmd.exe would reinterpret","message":"win32: quote arguments that cmd.exe would reinterpret\n\nwide_cmd_line() only quoted arguments containing a space, so \u0026 | \u003c \u003e ^ %\n( ) and ! were passed unquoted. CreateProcess() runs .bat and .cmd files\nthrough cmd.exe, which parses the command line again, so a certificate\nsubject passed to --tls-verify could start a second command (CERT/CC\nVU#123335).\n\nQuote on those characters too. Double quotes are already replaced with\n\u0027_\u0027, so nothing else needs escaping. The delimiters , ; and \u003d are left\nout: cmd.exe uses them to separate %1..%9 but cannot run anything with\nthem, and quoting them would change what existing scripts receive.\n\nGitHub: OpenVPN/openvpn-private-issues#159\nReported-By: Clouditera Security; Z.ai Security; NSFOCUS \u003csecurity@clouditera.com\u003e\nCVE: 2026-84256\nChange-Id: I68429deb39c0bae335d46a4170973a14c644ccf9\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Heiko Hund \u003cheiko@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1891\nMessage-Id: \u003c20260902121416.7047-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38897.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}