)]}'
{"id":"openvpn~1892","triplet_id":"openvpn~master~Iba66235cbad52692da542abd47e9f51810b0ed66","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-02 15:45:10.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-09-02 15:45:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iba66235cbad52692da542abd47e9f51810b0ed66","subject":"win32: unit-test the CreateProcess() command line quoting","status":"MERGED","created":"2026-09-01 20:48:28.000000000","updated":"2026-09-02 15:45:10.000000000","submitted":"2026-09-02 15:45:10.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1892","meta_rev_id":"a235b069c8c982c70bba22af32cd6314354d15d8","_number":1892,"virtual_id_number":1892,"owner":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-01 20:48:29.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-01 20:48:29.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-02 12:13:09.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"714ad017aac44d8f7c3feb048399f075690d67b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-01 20:48:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e36374a4963e82bdb82f600f4327d944414f2cab","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-09-02 12:13:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a235b069c8c982c70bba22af32cd6314354d15d8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-02 15:45:10.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3496ee3fb3d21ec8790abd2ebee6e5b15e7dc5d7","revisions":{"0bdd7a5cc6fc5939af8f269f424538aa3692c45f":{"kind":"REWORK","_number":1,"created":"2026-09-01 20:48:28.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/92/1892/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1892/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/1 \u0026\u0026 git checkout -b change-1892 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/92/1892/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8de20c8c1408935ebb47b395edb637de4e6818e9","subject":"win32: quote arguments that cmd.exe would reinterpret"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-08-10 13:01:17.000000000","tz":180},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-01 20:32:47.000000000","tz":120},"subject":"win32: unit-test the CreateProcess() command line quoting","message":"win32: unit-test the CreateProcess() command line quoting\n\nCover which argument shapes wide_cmd_line() quotes: plain arguments and\nthe batch delimiters , ; \u003d stay bare, a space or a cmd.exe metacharacter\nforces quotes, and an embedded double quote is replaced so quoting cannot\nbe broken out of. The first two cases pin the compatibility guarantee -\nthey are what a later \"just quote everything\" simplification would break.\n\nMove wide_cmd_line() to win32-util.c next to wide_string(), which it\ncalls. The unit tests already link that file, so nothing else needs to\nchange to reach it.\n\nChange-Id: Iba66235cbad52692da542abd47e9f51810b0ed66\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"3496ee3fb3d21ec8790abd2ebee6e5b15e7dc5d7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-09-02 15:45:10.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/92/1892/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1892/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/2 \u0026\u0026 git checkout -b change-1892 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/92/1892/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/1892/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cf08504bbbacdb0c3d94c7a0358a6ec06c553cdd","subject":"win32: quote arguments that cmd.exe would reinterpret"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-02 14:09:55.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-02 15:37:10.000000000","tz":120},"subject":"win32: unit-test the CreateProcess() command line quoting","message":"win32: unit-test the CreateProcess() command line quoting\n\nCover which argument shapes wide_cmd_line() quotes: plain arguments and\nthe batch delimiters , ; \u003d stay bare, a space or a cmd.exe metacharacter\nforces quotes, and an embedded double quote is replaced so quoting cannot\nbe broken out of. The first two cases pin the compatibility guarantee -\nthey are what a later \"just quote everything\" simplification would break.\n\nMove wide_cmd_line() to win32-util.c next to wide_string(), which it\ncalls. The unit tests already link that file, so nothing else needs to\nchange to reach it.\n\nChange-Id: Iba66235cbad52692da542abd47e9f51810b0ed66\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Heiko Hund \u003cheiko@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1892\nMessage-Id: \u003c20260902141002.16513-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38899.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}