)]}'
{"id":"openvpn~1893","triplet_id":"openvpn~master~I64920ed9f714803604d76c6df6b38cf20ce7626d","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000030":{"account":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2026-09-03 07:21:53.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-03 07:21:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I64920ed9f714803604d76c6df6b38cf20ce7626d","subject":"Move check_session_buf_not_used method into the method that free the buffer","status":"MERGED","created":"2026-09-02 17:03:38.000000000","updated":"2026-09-03 07:21:53.000000000","submitted":"2026-09-03 07:21:53.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1893","meta_rev_id":"34a22995dd74832ba244d7d8cacd347dda69ad43","_number":1893,"virtual_id_number":1893,"owner":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"}],"reviewers":{"REVIEWER":[{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"}],"CC":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-02 17:03:38.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"state":"REVIEWER"},{"updated":"2026-09-02 17:03:38.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-02 17:03:39.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-02 17:09:14.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"CC"},{"updated":"2026-09-02 18:39:30.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-03 07:21:53.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"CC"}],"messages":[{"id":"2df45a7847dfafe2167bcc1fa4dc5c53e2f09911","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-02 17:03:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9beb196d0575355f3cb69ca472a457ef62b8dcb2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-02 17:09:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7556d38a943d7111cea80aa2d872cae11a2b75ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-02 18:39:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"34a22995dd74832ba244d7d8cacd347dda69ad43","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-03 07:21:53.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2a881d737b2562ee28247148160cfb60f0ba4645","revisions":{"59c042b3002ef0030dc644710282e591cdb4a0b8":{"kind":"REWORK","_number":1,"created":"2026-09-02 17:03:38.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/93/1893/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/93/1893/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/1 \u0026\u0026 git checkout -b change-1893 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/93/1893/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3496ee3fb3d21ec8790abd2ebee6e5b15e7dc5d7","subject":"win32: unit-test the CreateProcess() command line quoting"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-01 10:29:12.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-02 17:03:31.000000000","tz":120},"subject":"Move check_session_buf_not_used method into the method that free the buffer","message":"Move check_session_buf_not_used method into the method that free the buffer\n\nThis cleans the code up a bit and ensure that we do not miss an invocation\nof a problematic code path. This is still a band-aid fix and a real fix\nrequires more refactoring and changing the logic.\n\nCVE: 2026-84471\nReported-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nGithub: openvpn/openvpn-private-issues#157\nReported-By: Haruki Oyama (Waseda University)\nGithub: openvpn/openvpn-private-issues#132\nChange-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"7c988280ca5399c68799882b08a524ef746cee8a":{"kind":"REWORK","_number":2,"created":"2026-09-02 17:09:14.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/93/1893/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/93/1893/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/2 \u0026\u0026 git checkout -b change-1893 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/93/1893/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3496ee3fb3d21ec8790abd2ebee6e5b15e7dc5d7","subject":"win32: unit-test the CreateProcess() command line quoting"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-01 10:29:12.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-02 17:08:51.000000000","tz":120},"subject":"Move check_session_buf_not_used method into the method that free the buffer","message":"Move check_session_buf_not_used method into the method that free the buffer\n\nThis cleans the code up a bit and ensure that we do not miss an invocation\nof a problematic code path. This is still a band-aid fix and a real fix\nrequires more refactoring and changing the logic.\n\nv2: sprinkle some \"const\" over check_keystate_buf_not_used() args\n\nCVE: 2026-84471\nReported-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nGithub: openvpn/openvpn-private-issues#157\nReported-By: Haruki Oyama (Waseda University)\nGithub: openvpn/openvpn-private-issues#132\nChange-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"76fb884d03d459ca4cbfd5771c41320e52acc104":{"kind":"REWORK","_number":3,"created":"2026-09-02 18:39:30.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/93/1893/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/93/1893/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/3 \u0026\u0026 git checkout -b change-1893 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/93/1893/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3496ee3fb3d21ec8790abd2ebee6e5b15e7dc5d7","subject":"win32: unit-test the CreateProcess() command line quoting"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-07-01 10:29:12.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-02 18:39:09.000000000","tz":120},"subject":"Move check_session_buf_not_used method into the method that free the buffer","message":"Move check_session_buf_not_used method into the method that free the buffer\n\nThis cleans the code up a bit and ensure that we do not miss an invocation\nof a problematic code path. This is still a band-aid fix and a real fix\nrequires more refactoring and changing the logic.\n\nv2: sprinkle some \"const\" over check_keystate_buf_not_used() args\nv3: add missing doxygen for to_link parameter to tls_session_free()\n\nCVE: 2026-84471\nReported-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nGithub: openvpn/openvpn-private-issues#157\nReported-By: Haruki Oyama (Waseda University)\nGithub: openvpn/openvpn-private-issues#132\nChange-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"2a881d737b2562ee28247148160cfb60f0ba4645":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2026-09-03 07:21:53.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/93/1893/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/93/1893/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/4 \u0026\u0026 git checkout -b change-1893 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/93/1893/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/93/1893/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3496ee3fb3d21ec8790abd2ebee6e5b15e7dc5d7","subject":"win32: unit-test the CreateProcess() command line quoting"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-09-03 06:12:02.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-03 06:41:10.000000000","tz":120},"subject":"Move check_session_buf_not_used method into the method that free the buffer","message":"Move check_session_buf_not_used method into the method that free the buffer\n\nThis cleans the code up a bit and ensure that we do not miss an invocation\nof a problematic code path. This is still a band-aid fix and a real fix\nrequires more refactoring and changing the logic.\n\nv2: sprinkle some \"const\" over check_keystate_buf_not_used() args\nv3: add missing doxygen for to_link parameter to tls_session_free()\n\nCVE: 2026-84471\nReported-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nTested-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nGithub: openvpn/openvpn-private-issues#157\nReported-By: Haruki Oyama (Waseda University)\nGithub: openvpn/openvpn-private-issues#132\nChange-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1893\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nMessage-Id: \u003c20260903061209.12599-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38913.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}