)]}'
{"id":"openvpn~1895","triplet_id":"openvpn~master~I70dfdc70778458b78f80b8d0b0b786f18fe4fc76","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-07 16:04:10.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-09-07 16:04:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I70dfdc70778458b78f80b8d0b0b786f18fe4fc76","subject":"win32: stop cmd.exe from expanding variables in quoted arguments","status":"MERGED","created":"2026-09-03 10:30:06.000000000","updated":"2026-09-07 16:04:10.000000000","submitted":"2026-09-07 16:04:10.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1895","meta_rev_id":"46389cc6e6bea0b1ea88c0aaae97707f1fefb63d","_number":1895,"virtual_id_number":1895,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-03 10:30:07.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-03 10:30:07.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-03 10:55:36.000000000","updated_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"a92e876b9a09b371d18309732b16a5ec2561ca66","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-09-03 10:30:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dd1b9e2dcaf374e05ee269eb23bbe6e1f7416d7d","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-03 10:55:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"46389cc6e6bea0b1ea88c0aaae97707f1fefb63d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-07 16:04:10.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eb12c84ef08566c4d2d5f3ea1294891339a5b5e9","revisions":{"a7ec3039f051c7664d7d004a1fea2a301d4b639f":{"kind":"REWORK","_number":1,"created":"2026-09-03 10:30:06.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/95/1895/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/95/1895/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/1 \u0026\u0026 git checkout -b change-1895 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/95/1895/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a881d737b2562ee28247148160cfb60f0ba4645","subject":"Move check_session_buf_not_used method into the method that free the buffer"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-03 09:18:34.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-03 10:25:12.000000000","tz":180},"subject":"win32: stop cmd.exe from expanding variables in quoted arguments","message":"win32: stop cmd.exe from expanding variables in quoted arguments\n\nCommit cf08504 quotes arguments that contain cmd.exe metacharacters, so a\ncertificate subject passed to --tls-verify cannot start a second command\nwhen CreateProcess() runs a .bat or .cmd hook.\n\nQuoting is not enough for %VAR% and !VAR!: cmd.exe expands those even\ninside double quotes, and OpenVPN exports peer-controlled certificate\nfields into the child environment. A subject that puts a quote and an\noperator in one field (O\u003dBREAK\"\u0026whoami\u0026\") and references it from another\n(CN\u003d%X509_0_O%) expands back into a quote and command operator after\nwide_cmd_line() has already replaced the direct quotes, running a command\nbefore the hook can reject the peer.\n\nReplace % and ! in wide_cmd_line() along with the double quotes and CRLF,\nso no argument can expand. This reuses two character classes that had no\nusers, CC_AT and CC_EQUAL, renamed to CC_PERCENT and CC_EXCLAMATION. Add\nregression tests for a bare percent or bang, a closed expansion token, and\nthe reported subject.\n\nThis completes the CVE-2026-84256 fix for Windows batch hooks.\n\nGitHub: OpenVPN/openvpn-private-issues#176\nReported-By: Darren Carreras\nCVE: 2026-84256\nChange-Id: I70dfdc70778458b78f80b8d0b0b786f18fe4fc76\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"eb12c84ef08566c4d2d5f3ea1294891339a5b5e9":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-09-07 16:04:10.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/95/1895/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/95/1895/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/2 \u0026\u0026 git checkout -b change-1895 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/95/1895/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/95/1895/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22a24132da88b6be9f121e4c6e74c18a46e7741f","subject":"Check for \\0 and RFC 2253 chars in cert subjects"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-07 14:43:44.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-07 15:58:36.000000000","tz":120},"subject":"win32: stop cmd.exe from expanding variables in quoted arguments","message":"win32: stop cmd.exe from expanding variables in quoted arguments\n\nCommit cf08504 quotes arguments that contain cmd.exe metacharacters, so a\ncertificate subject passed to --tls-verify cannot start a second command\nwhen CreateProcess() runs a .bat or .cmd hook.\n\nQuoting is not enough for %VAR% and !VAR!: cmd.exe expands those even\ninside double quotes, and OpenVPN exports peer-controlled certificate\nfields into the child environment. A subject that puts a quote and an\noperator in one field (O\u003dBREAK\"\u0026whoami\u0026\") and references it from another\n(CN\u003d%X509_0_O%) expands back into a quote and command operator after\nwide_cmd_line() has already replaced the direct quotes, running a command\nbefore the hook can reject the peer.\n\nReplace % and ! in wide_cmd_line() along with the double quotes and CRLF,\nso no argument can expand. This reuses two character classes that had no\nusers, CC_AT and CC_EQUAL, renamed to CC_PERCENT and CC_EXCLAMATION. Add\nregression tests for a bare percent or bang, a closed expansion token, and\nthe reported subject.\n\nThis completes the CVE-2026-84256 fix for Windows batch hooks.\n\nGitHub: OpenVPN/openvpn-private-issues#176\nReported-By: Darren Carreras\nCVE: 2026-84256\nChange-Id: I70dfdc70778458b78f80b8d0b0b786f18fe4fc76\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1895\nMessage-Id: \u003c20260907144351.22085-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38985.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}