)]}'
{"id":"openvpn~1896","triplet_id":"openvpn~master~I1cd2fcb363b6ee95f25c5cba72f74f85e43ab66d","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-03 13:11:44.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I1cd2fcb363b6ee95f25c5cba72f74f85e43ab66d","subject":"dco_linux: set ifindex also when adopting a pre-existing interface","status":"ABANDONED","created":"2026-09-03 13:06:53.000000000","updated":"2026-09-03 13:11:44.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"501039ee80d452207f9cadfca7fa870798bf7106","_number":1896,"virtual_id_number":1896,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"rejected":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"all":[{"value":-2,"date":"2026-09-03 13:11:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"blocking":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-03 13:06:53.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-03 13:06:53.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"8cd36ed58eaadca7811b42efe77716920451e650","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 13:06:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8551e76325637815615fb36afb5d9fd875c69698","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 13:11:35.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"501039ee80d452207f9cadfca7fa870798bf7106","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 13:11:44.000000000","message":"Abandoned\n\nduplicate of #1734","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e597f69e1f1583a086fe787c591924f58020ecf","revisions":{"3e597f69e1f1583a086fe787c591924f58020ecf":{"kind":"REWORK","_number":1,"created":"2026-09-03 13:06:53.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/96/1896/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/96/1896/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1896/1 \u0026\u0026 git checkout -b change-1896 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1896/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1896/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1896/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/96/1896/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1896/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a881d737b2562ee28247148160cfb60f0ba4645","subject":"Move check_session_buf_not_used method into the method that free the buffer"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-03 12:38:08.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-03 12:56:41.000000000","tz":120},"subject":"dco_linux: set ifindex also when adopting a pre-existing interface","message":"dco_linux: set ifindex also when adopting a pre-existing interface\n\nWhen the DCO interface is created by the user before the daemon is\nstarted, net_iface_new() gets -EEXIST back from the kernel.\nAt this point open_tun_dco() returns right away and never reaches\nthe assignment of tt-\u003edco.ifindex.\n\nMissing the ifindex assignment makes all subsequent netlink call fail,\nas they require a proper ifindex to identify the target device (ENODEV).\n\nThe breakage is easy to miss, because the error is reported at D_DCO,\nwhich is not printed at the default verb, while the reassuring \"re-using\nexisting device\" message is.\n\nResolve the ifindex for the -EEXIST case too and pass -EEXIST on to the\ncaller, which already knows how to deal with it. This also brings the\nLinux implementation in line with the FreeBSD one, which has always\ncompleted the interface setup on -EEXIST as well.\n\nThe dynamic device name path is not affected: it accepts a return value\nof 0 only and keeps scanning the next name on -EEXIST.\n\nChange-Id: I1cd2fcb363b6ee95f25c5cba72f74f85e43ab66d\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}