)]}'
{"id":"openvpn~1897","triplet_id":"openvpn~master~I10326c787cd8149e7617279e45166073d66b9101","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-10-23 06:31:40.000000000","reason":"Someone else replied on the change"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-03 23:10:48.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-10-23 06:31:40.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I10326c787cd8149e7617279e45166073d66b9101","subject":"dco_freebsd: close DCO fds when closing the tun device","status":"NEW","created":"2026-09-03 23:10:47.000000000","updated":"2026-10-23 06:31:40.000000000","submit_type":"CHERRY_PICK","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"344c4035e1d7ea57cdf8f07be7187bfa7e1032bf","_number":1897,"virtual_id_number":1897,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-10-23 06:31:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-03 23:10:48.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-03 23:10:48.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-20 09:22:21.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"b81df5b6db36acab540fe513c446f7cbe9dc9a96","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 23:10:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3237e1063e86fb8d8237147f9c1f2a6da16b4ce8","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-20 09:22:21.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"83c8a1c1cfba71f68fdbf1937e9d19444458ac5b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-10-22 20:39:28.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6c3604ff9d37ee8d4ade771bb309b7d7a3e61b90","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-10-22 20:39:57.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"344c4035e1d7ea57cdf8f07be7187bfa7e1032bf","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-23 06:31:40.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"52abc98d46a5797e6c823005f89399f370380d3c","revisions":{"bcd5ef323aa524e5fc02aff083a743917b95fba0":{"kind":"REWORK","_number":1,"created":"2026-09-03 23:10:47.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/97/1897/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1897/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/1 \u0026\u0026 git checkout -b change-1897 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/97/1897/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d988ef4508e63b28c8e3efcb9f62eb8c836907fe","subject":"Ignore acks for packets that cannot be outstanding"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-03 14:50:18.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-03 23:10:37.000000000","tz":120},"subject":"dco_freebsd: don\u0027t destroy pre-existing interfaces on close","message":"dco_freebsd: don\u0027t destroy pre-existing interfaces on close\n\nclose_tun_dco() calls remove_interface() unconditionally, ignoring\ntt-\u003epersistent_if. Since create_interface() stores the requested name in\ntt-\u003edco.ifname before the SIOCSIFNAME rename, on -EEXIST the destroy\ntargets the pre-existing interface rather than the temporary one.\n\nSkip remove_interface() for persistent interfaces, as done on Linux.\n\nChange-Id: I10326c787cd8149e7617279e45166073d66b9101\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"52abc98d46a5797e6c823005f89399f370380d3c":{"kind":"REWORK","_number":2,"created":"2026-10-22 20:39:28.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/97/1897/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1897/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/2 \u0026\u0026 git checkout -b change-1897 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/97/1897/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1897/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0702ff8e2945f8615f67c0dfc03e5a013567b3f8","subject":"buffer: make buf_valid() and buf_defined() NULL-safe"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-22 19:24:29.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-22 19:24:29.000000000","tz":120},"subject":"dco_freebsd: close DCO fds when closing the tun device","message":"dco_freebsd: close DCO fds when closing the tun device\n\nOn FreeBSD close_tun_dco() is never called: its only call site lives in\nthe Linux close_tun(), behind a TARGET_FREEBSD guard that can never be\ntrue there. As a result the DCO control socket and notification pipe\nleak every time the tun device is closed (e.g. on restart without\n--persist-tun).\n\nCall close_tun_dco() from the FreeBSD close_tun() as well. Since that\nfunction already destroys the interface via \"ifconfig destroy\" (and\nkeeps it when persistent_if is set), reduce close_tun_dco() to closing\nthe fds and drop the now unused remove_interface().\n\nWhile at it, remove the dead TARGET_FREEBSD guard from the Linux\nclose_tun().\n\nChange-Id: I10326c787cd8149e7617279e45166073d66b9101\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}