)]}'
{"id":"openvpn~1899","triplet_id":"openvpn~master~Iaf68abf0d2575ee4cd30dc4f3ef627f6b22ecb03","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-10-07 21:35:21.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-07 17:18:33.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Iaf68abf0d2575ee4cd30dc4f3ef627f6b22ecb03","subject":"reliable: characterize the packet id comparisons before rewriting them","status":"MERGED","created":"2026-09-07 07:23:01.000000000","updated":"2026-10-07 21:35:21.000000000","submitted":"2026-10-07 21:35:21.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1899","meta_rev_id":"13f5777b930ab0ad2fe41fbf2156cb45b02060e8","_number":1899,"virtual_id_number":1899,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-07 07:23:01.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-07 07:23:01.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"f2beb634fdb9f61d5dde0f6a9e4c30c8c2656bc8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-07 07:23:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0253cd66dfdbfd044ea5bb93abb466c7c810003f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-07 08:05:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2b8a6f12a503a7316531c08d071383658b34f305","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-10-07 17:18:33.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1f966f2666d772b3b894ae46c37cde88586ecb45","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-07 20:05:18.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"13f5777b930ab0ad2fe41fbf2156cb45b02060e8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-07 21:35:21.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"3a78bd3912607e5a62dad0453d5fc8bc37619073","revisions":{"93495f90cf625486a2d071ee04a7c7eeefca1870":{"kind":"REWORK","_number":1,"created":"2026-09-07 07:23:01.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/99/1899/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1899/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/1 \u0026\u0026 git checkout -b change-1899 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/99/1899/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"96f059ccfb16f051513b59314b7b3631d4fe7dae","subject":"test_schedule: Make all the counting variables unsigned"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-04 10:25:22.000000000","tz":180},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-06 07:02:15.000000000","tz":180},"subject":"reliable: characterize the packet id comparisons before rewriting them","message":"reliable: characterize the packet id comparisons before rewriting them\n\nThe comparisons are about to lose their 2^31 horizon helpers. Pin the\naccepted id set at each site first, by sweeping anchors and offsets across\nthe 0/2^32 wrap and the 0x80000000 midpoint against reference\nimplementations of the current behaviour.\n\nreliable_not_replay(), reliable_wont_break_sequentiality(), the three scans\nfor the oldest unacknowledged entry and the ASSERT in\nreliable_mark_active_incoming() had no coverage at all.\n\nThe receive path is characterized as the verdict ssl.c produces\n(drop / ack-only / store) rather than as two predicates, because a replay is\nstill acknowledged while a sequentiality break is not. Its sweep splits at\n2^31: reliable_wont_break_sequentiality() compares in absolute terms, so\nabove that base its accepted set shifts.\n\nChange-Id: Iaf68abf0d2575ee4cd30dc4f3ef627f6b22ecb03\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"ff9790a5c419a1cc6430aac7aec65764b9151485":{"kind":"REWORK","_number":2,"created":"2026-09-07 08:05:00.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/99/1899/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1899/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/2 \u0026\u0026 git checkout -b change-1899 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/99/1899/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"96f059ccfb16f051513b59314b7b3631d4fe7dae","subject":"test_schedule: Make all the counting variables unsigned"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-04 10:25:22.000000000","tz":180},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-07 08:01:59.000000000","tz":180},"subject":"reliable: characterize the packet id comparisons before rewriting them","message":"reliable: characterize the packet id comparisons before rewriting them\n\nThe comparisons are about to lose their 2^31 horizon helpers. Pin the\naccepted id set at each site first, by sweeping anchors and offsets across\nthe 0/2^32 wrap and the 0x80000000 midpoint against reference\nimplementations of the current behaviour.\n\nreliable_not_replay(), reliable_wont_break_sequentiality(), the three scans\nfor the oldest unacknowledged entry and the ASSERT in\nreliable_mark_active_incoming() had no coverage at all.\n\nThe receive path is characterized as the verdict ssl.c produces\n(drop / ack-only / store) rather than as two predicates, because a replay is\nstill acknowledged while a sequentiality break is not. Its sweep splits at\n2^31: reliable_wont_break_sequentiality() compares in absolute terms, so\nabove that base its accepted set shifts.\n\nChange-Id: Iaf68abf0d2575ee4cd30dc4f3ef627f6b22ecb03\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"008a20a3952e077b35db9841d2ff9b75cf564cfd":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-10-07 20:05:18.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/99/1899/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1899/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/3 \u0026\u0026 git checkout -b change-1899 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/99/1899/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1c4187364f14dc267becbcbdf60f16354d9d70b","subject":"Add missing includes for C files and their own headers"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-04 10:25:22.000000000","tz":180},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-10-07 20:02:16.000000000","tz":180},"subject":"reliable: characterize the packet id comparisons before rewriting them","message":"reliable: characterize the packet id comparisons before rewriting them\n\nThe comparisons are about to lose their 2^31 horizon helpers. Pin the\naccepted id set at each site first, by sweeping anchors and offsets across\nthe 0/2^32 wrap and the 0x80000000 midpoint against reference\nimplementations of the current behaviour.\n\nreliable_not_replay(), reliable_wont_break_sequentiality(), the three scans\nfor the oldest unacknowledged entry and the ASSERT in\nreliable_mark_active_incoming() had no coverage at all.\n\nThe receive path is characterized as the verdict ssl.c produces\n(drop / ack-only / store) rather than as two predicates, because a replay is\nstill acknowledged while a sequentiality break is not. Its sweep splits at\n2^31: reliable_wont_break_sequentiality() compares in absolute terms, so\nabove that base its accepted set shifts.\n\nChange-Id: Iaf68abf0d2575ee4cd30dc4f3ef627f6b22ecb03\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"3a78bd3912607e5a62dad0453d5fc8bc37619073":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2026-10-07 21:35:21.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/99/1899/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1899/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/4 \u0026\u0026 git checkout -b change-1899 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/99/1899/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/99/1899/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1c4187364f14dc267becbcbdf60f16354d9d70b","subject":"Add missing includes for C files and their own headers"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-10-07 17:20:01.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-07 21:33:11.000000000","tz":120},"subject":"reliable: characterize the packet id comparisons before rewriting them","message":"reliable: characterize the packet id comparisons before rewriting them\n\nThe comparisons are about to lose their 2^31 horizon helpers. Pin the\naccepted id set at each site first, by sweeping anchors and offsets across\nthe 0/2^32 wrap and the 0x80000000 midpoint against reference\nimplementations of the current behaviour.\n\nreliable_not_replay(), reliable_wont_break_sequentiality(), the three scans\nfor the oldest unacknowledged entry and the ASSERT in\nreliable_mark_active_incoming() had no coverage at all.\n\nThe receive path is characterized as the verdict ssl.c produces\n(drop / ack-only / store) rather than as two predicates, because a replay is\nstill acknowledged while a sequentiality break is not. Its sweep splits at\n2^31: reliable_wont_break_sequentiality() compares in absolute terms, so\nabove that base its accepted set shifts.\n\nChange-Id: Iaf68abf0d2575ee4cd30dc4f3ef627f6b22ecb03\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1899\nMessage-Id: \u003c20261007172007.23382-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39760.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}