)]}'
{"id":"openvpn~1901","triplet_id":"openvpn~master~I63c141075d89ae6a07872e784faff817dd3350b1","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-10-11 16:07:02.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-08 11:25:01.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I63c141075d89ae6a07872e784faff817dd3350b1","subject":"reliable: fix the send window width","status":"MERGED","created":"2026-09-07 07:23:01.000000000","updated":"2026-10-11 16:07:02.000000000","submitted":"2026-10-11 16:07:02.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1901","meta_rev_id":"0e6c1331c70ca0b8c8fc0d0d728ce48eab5c6c7f","_number":1901,"virtual_id_number":1901,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-07 07:23:02.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-07 07:23:02.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"448375b0268c17afdbd68ab35a535b137568df75","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-07 07:23:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3c7167e6ed4b75042189f16044237932fa73989d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-07 08:05:00.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"6136919f19cfb11cafabdc8e46d0fc34f075adc7","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-10-07 17:12:20.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9bd15e21097a312deea2c0772ec047dfbfc6b175","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-07 20:05:18.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b1af5d8a4511acc1be9bd31441634f096593f634","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-10-08 11:25:01.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0e6c1331c70ca0b8c8fc0d0d728ce48eab5c6c7f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-11 16:07:02.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"01619660cc1c1c56c999c8ec8de1b23c63580a9b","revisions":{"f82b16705f3b7628d7891d7930b7452668835cab":{"kind":"REWORK","_number":1,"created":"2026-09-07 07:23:01.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/01/1901/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/1901/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/1 \u0026\u0026 git checkout -b change-1901 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/01/1901/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"69816164a9b60a38214c21ce64a6cf169d732327","subject":"reliable: drop the half-space packet id comparisons"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-04 10:36:36.000000000","tz":180},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-07 07:13:11.000000000","tz":180},"subject":"reliable: fix the send window width","message":"reliable: fix the send window width\n\nThe check accepted the 11 ids below rel-\u003epacket_id where its documentation\nsaid RELIABLE_CAPACITY. Twelve is right: reliable_get_buf_output_sequenced()\nissues an id while it is less than rel-\u003esize beyond the oldest unacknowledged\none, so an entry can sit a full rel-\u003esize below rel-\u003epacket_id, and rel-\u003esize\nmay be RELIABLE_CAPACITY.\n\nNo effect today, TLS_RELIABLE_N_SEND_BUFFERS being 6. Raising the send buffer\ncount to RELIABLE_CAPACITY, which reliable_init() permits, would have\ndiscarded the ACK for the oldest outstanding packet.\n\nThe width is now the extent passed to reliable_pid_in_range() rather than a\ncomparison operator.\n\nAlso renames validate_packet_id_window() to reliable_pid_in_send_window(),\nreturning bool and taking a const struct reliable * like its neighbours, and\nthe same const on reliable_get_num_output_sequenced_available().\n\nThree doc comments described what the code does not do: the window bounds,\nreliable_wont_break_sequentiality()\u0027s reference id, subtract_pid()\u0027s argument\norder. reliable_mark_active_incoming() now states the precondition it asserts.\n\nChange-Id: I63c141075d89ae6a07872e784faff817dd3350b1\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"d5e69f956cb2f6fb32c32d449d6204604a041768":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-09-07 08:05:00.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/01/1901/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/1901/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/2 \u0026\u0026 git checkout -b change-1901 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/01/1901/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65f2d4b01cce8c3f3a0869362c4fd086d0b5c021","subject":"reliable: drop the half-space packet id comparisons"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-04 10:36:36.000000000","tz":180},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-07 08:01:59.000000000","tz":180},"subject":"reliable: fix the send window width","message":"reliable: fix the send window width\n\nThe check accepted the 11 ids below rel-\u003epacket_id where its documentation\nsaid RELIABLE_CAPACITY. Twelve is right: reliable_get_buf_output_sequenced()\nissues an id while it is less than rel-\u003esize beyond the oldest unacknowledged\none, so an entry can sit a full rel-\u003esize below rel-\u003epacket_id, and rel-\u003esize\nmay be RELIABLE_CAPACITY.\n\nNo effect today, TLS_RELIABLE_N_SEND_BUFFERS being 6. Raising the send buffer\ncount to RELIABLE_CAPACITY, which reliable_init() permits, would have\ndiscarded the ACK for the oldest outstanding packet.\n\nThe width is now the extent passed to reliable_pid_in_range() rather than a\ncomparison operator.\n\nAlso renames validate_packet_id_window() to reliable_pid_in_send_window(),\nreturning bool and taking a const struct reliable * like its neighbours, and\nthe same const on reliable_get_num_output_sequenced_available().\n\nThree doc comments described what the code does not do: the window bounds,\nreliable_wont_break_sequentiality()\u0027s reference id, subtract_pid()\u0027s argument\norder. reliable_mark_active_incoming() now states the precondition it asserts.\n\nChange-Id: I63c141075d89ae6a07872e784faff817dd3350b1\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"e8b3f9aeeddf74dc15ebbb0e21003b4d1a25f833":{"kind":"REWORK","_number":3,"created":"2026-10-07 20:05:18.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/01/1901/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/1901/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/3 \u0026\u0026 git checkout -b change-1901 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/01/1901/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3498ac23db3d94543a33fa766ccba64d10c1183","subject":"reliable: drop the half-space packet id comparisons"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-09-04 10:36:36.000000000","tz":180},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-10-07 20:04:53.000000000","tz":180},"subject":"reliable: fix the send window width","message":"reliable: fix the send window width\n\nThe check accepted the 11 ids below rel-\u003epacket_id where its documentation\nsaid RELIABLE_CAPACITY. Twelve is right: reliable_get_buf_output_sequenced()\nissues an id while it is less than rel-\u003esize beyond the oldest unacknowledged\none, so an entry can sit a full rel-\u003esize below rel-\u003epacket_id, and rel-\u003esize\nmay be RELIABLE_CAPACITY.\n\nNo effect today, TLS_RELIABLE_N_SEND_BUFFERS being 6. Raising the send buffer\ncount to RELIABLE_CAPACITY, which reliable_init() permits, would have\ndiscarded the ACK for the oldest outstanding packet.\n\nThe width is now the extent passed to reliable_pid_in_range() rather than a\ncomparison operator.\n\nAlso renames validate_packet_id_window() to reliable_pid_in_send_window(),\nreturning bool and taking a const struct reliable * like its neighbours, and\nthe same const on reliable_get_num_output_sequenced_available().\n\nThree doc comments described what the code does not do: the window bounds,\nreliable_wont_break_sequentiality()\u0027s reference id, subtract_pid()\u0027s argument\norder. reliable_mark_active_incoming() now states the precondition it asserts.\n\nChange-Id: I63c141075d89ae6a07872e784faff817dd3350b1\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"01619660cc1c1c56c999c8ec8de1b23c63580a9b":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-10-11 16:07:02.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/01/1901/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/1901/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/4 \u0026\u0026 git checkout -b change-1901 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/01/1901/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/1901/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2318e3366392d0d066c2a8cfa1b3d1f332935334","subject":"reliable: drop the half-space packet id comparisons"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-10-08 20:50:39.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-11 16:02:37.000000000","tz":120},"subject":"reliable: fix the send window width","message":"reliable: fix the send window width\n\nThe check accepted the 11 ids below rel-\u003epacket_id where its documentation\nsaid RELIABLE_CAPACITY. Twelve is right: reliable_get_buf_output_sequenced()\nissues an id while it is less than rel-\u003esize beyond the oldest\nunacknowledged one, so an entry can sit a full rel-\u003esize below\nrel-\u003epacket_id, and rel-\u003esize may be RELIABLE_CAPACITY.\n\nNo effect today, TLS_RELIABLE_N_SEND_BUFFERS being 6. Raising the send\nbuffer count to RELIABLE_CAPACITY, which reliable_init() permits, would\nhave discarded the ACK for the oldest outstanding packet.\n\nThe width is now the extent passed to reliable_pid_in_range() rather\nthan a comparison operator.\n\nAlso renames validate_packet_id_window() to reliable_pid_in_send_window(),\nreturning bool and taking a const struct reliable * like its neighbours,\nand the same const on reliable_get_num_output_sequenced_available().\n\nThree doc comments described what the code does not do: the window\nbounds, reliable_wont_break_sequentiality()\u0027s reference id, subtract_pid()\u0027s\nargument order. reliable_mark_active_incoming() now states the\nprecondition it asserts.\n\nChange-Id: I63c141075d89ae6a07872e784faff817dd3350b1\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1901\nMessage-Id: \u003c20261008205045.28233-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39795.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}