)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"7be6d236355a9225cbeb459cdde2594f5338c253","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"buffer: When extracting pointers from buffer, retain const"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently you can use BPTR and similar to implictly remove"},{"line_number":10,"context_line":"const. That avoids some warnings that we should get and"},{"line_number":11,"context_line":"confuses tools like cppcheck into giving wrong suggestions."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9badfdf6_6d1189f1","line":9,"updated":"2026-09-10 19:38:40.000000000","message":"Typo: \"implicitly\".","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0eb44e7bc48a38f37b9d26a0ec7ce43f22aceee2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"buffer: When extracting pointers from buffer, retain const"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently you can use BPTR and similar to implictly remove"},{"line_number":10,"context_line":"const. That avoids some warnings that we should get and"},{"line_number":11,"context_line":"confuses tools like cppcheck into giving wrong suggestions."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c72b284e_2efe3978","line":9,"in_reply_to":"9badfdf6_6d1189f1","updated":"2026-09-11 11:59:56.000000000","message":"Done","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"7be6d236355a9225cbeb459cdde2594f5338c253","unresolved":true,"context_lines":[{"line_number":11,"context_line":"confuses tools like cppcheck into giving wrong suggestions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So make sure that by default we do not return a non-const"},{"line_number":14,"context_line":"pointer if the buffer is not const. Change all call sites"},{"line_number":15,"context_line":"that threw warnings."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bc2d77d9_4f619c6e","line":14,"updated":"2026-09-10 19:38:40.000000000","message":"\"if the buffer is const\"?","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0eb44e7bc48a38f37b9d26a0ec7ce43f22aceee2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"confuses tools like cppcheck into giving wrong suggestions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So make sure that by default we do not return a non-const"},{"line_number":14,"context_line":"pointer if the buffer is not const. Change all call sites"},{"line_number":15,"context_line":"that threw warnings."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7811f908_40797ef6","line":14,"in_reply_to":"0c344c20_c1663d2b","updated":"2026-09-11 11:59:56.000000000","message":"Done","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1d1db6feec06b871547472f0f0d7ab45138cb245","unresolved":true,"context_lines":[{"line_number":11,"context_line":"confuses tools like cppcheck into giving wrong suggestions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So make sure that by default we do not return a non-const"},{"line_number":14,"context_line":"pointer if the buffer is not const. Change all call sites"},{"line_number":15,"context_line":"that threw warnings."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0c344c20_c1663d2b","line":14,"in_reply_to":"bc2d77d9_4f619c6e","updated":"2026-09-11 10:40:10.000000000","message":"I will try to remove a few levels of negation from the sentence ;)","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"}],"src/openvpn/buffer.c":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"7be6d236355a9225cbeb459cdde2594f5338c253","unresolved":true,"context_lines":[{"line_number":1135,"context_line":"    if (buf \u0026\u0026 buf-\u003elen)"},{"line_number":1136,"context_line":"    {"},{"line_number":1137,"context_line":"        msglvl_t msglevel \u003d D_ALIGN_DEBUG;"},{"line_number":1138,"context_line":"        const uintptr_t u \u003d (uintptr_t)BPTR(buf);"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        if (u \u0026 (PAYLOAD_ALIGN - 1))"},{"line_number":1141,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8f5bf6b8_18e617f5","line":1138,"updated":"2026-09-10 19:38:40.000000000","message":"CBPTR here as well?","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0eb44e7bc48a38f37b9d26a0ec7ce43f22aceee2","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"    if (buf \u0026\u0026 buf-\u003elen)"},{"line_number":1136,"context_line":"    {"},{"line_number":1137,"context_line":"        msglvl_t msglevel \u003d D_ALIGN_DEBUG;"},{"line_number":1138,"context_line":"        const uintptr_t u \u003d (uintptr_t)BPTR(buf);"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        if (u \u0026 (PAYLOAD_ALIGN - 1))"},{"line_number":1141,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"0f68e3b9_1dc994af","line":1138,"in_reply_to":"79679f3f_a0e3247c","updated":"2026-09-11 11:59:56.000000000","message":"Done","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1d1db6feec06b871547472f0f0d7ab45138cb245","unresolved":true,"context_lines":[{"line_number":1135,"context_line":"    if (buf \u0026\u0026 buf-\u003elen)"},{"line_number":1136,"context_line":"    {"},{"line_number":1137,"context_line":"        msglvl_t msglevel \u003d D_ALIGN_DEBUG;"},{"line_number":1138,"context_line":"        const uintptr_t u \u003d (uintptr_t)BPTR(buf);"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        if (u \u0026 (PAYLOAD_ALIGN - 1))"},{"line_number":1141,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"79679f3f_a0e3247c","line":1138,"in_reply_to":"8f5bf6b8_18e617f5","updated":"2026-09-11 10:40:10.000000000","message":"Yeah, code that isn\u0027t every compiled, so the build will not flag it. I didn\u0027t investigate all existing occurrences of BPTR.","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"}],"src/openvpn/manage.c":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"7be6d236355a9225cbeb459cdde2594f5338c253","unresolved":true,"context_lines":[{"line_number":2521,"context_line":"#ifdef TARGET_ANDROID"},{"line_number":2522,"context_line":"        if (man-\u003econnection.fdtosend \u003e 0)"},{"line_number":2523,"context_line":"        {"},{"line_number":2524,"context_line":"            sent \u003d man_send_with_fd(man-\u003econnection.sd_cli, CBPTR(buf), len, MSG_NOSIGNAL,"},{"line_number":2525,"context_line":"                                    man-\u003econnection.fdtosend);"},{"line_number":2526,"context_line":"            man-\u003econnection.fdtosend \u003d -1;"},{"line_number":2527,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a819ef54_4e081b68","line":2524,"updated":"2026-09-10 19:38:40.000000000","message":"Not fully sure this is right, `man_send_with_fd()` takes a `void *ptr` here so this will probably trigger a warning on Android builds now.","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7c893ce880f4a126884d67141b9d60bbb374f926","unresolved":false,"context_lines":[{"line_number":2521,"context_line":"#ifdef TARGET_ANDROID"},{"line_number":2522,"context_line":"        if (man-\u003econnection.fdtosend \u003e 0)"},{"line_number":2523,"context_line":"        {"},{"line_number":2524,"context_line":"            sent \u003d man_send_with_fd(man-\u003econnection.sd_cli, CBPTR(buf), len, MSG_NOSIGNAL,"},{"line_number":2525,"context_line":"                                    man-\u003econnection.fdtosend);"},{"line_number":2526,"context_line":"            man-\u003econnection.fdtosend \u003d -1;"},{"line_number":2527,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"738c764b_39771bc1","line":2524,"in_reply_to":"3d3c13fd_590c3be8","updated":"2026-09-11 13:16:11.000000000","message":"Done","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1d1db6feec06b871547472f0f0d7ab45138cb245","unresolved":true,"context_lines":[{"line_number":2521,"context_line":"#ifdef TARGET_ANDROID"},{"line_number":2522,"context_line":"        if (man-\u003econnection.fdtosend \u003e 0)"},{"line_number":2523,"context_line":"        {"},{"line_number":2524,"context_line":"            sent \u003d man_send_with_fd(man-\u003econnection.sd_cli, CBPTR(buf), len, MSG_NOSIGNAL,"},{"line_number":2525,"context_line":"                                    man-\u003econnection.fdtosend);"},{"line_number":2526,"context_line":"            man-\u003econnection.fdtosend \u003d -1;"},{"line_number":2527,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"3d3c13fd_590c3be8","line":2524,"in_reply_to":"a819ef54_4e081b68","updated":"2026-09-11 10:40:10.000000000","message":"Yeah, seems we do not run the android build with -Werror: http://buildbot.community.aws.openvpn.in:8010/#/builders/367/builds/3498/steps/7/logs/stdio","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"7be6d236355a9225cbeb459cdde2594f5338c253","unresolved":true,"context_lines":[{"line_number":2528,"context_line":"        else"},{"line_number":2529,"context_line":"#endif"},{"line_number":2530,"context_line":"        {"},{"line_number":2531,"context_line":"            sent \u003d send(man-\u003econnection.sd_cli, CBSTR(buf), len, MSG_NOSIGNAL);"},{"line_number":2532,"context_line":"        }"},{"line_number":2533,"context_line":"        if (sent \u003e\u003d 0)"},{"line_number":2534,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"922ac025_217c7d89","line":2531,"updated":"2026-09-10 19:38:40.000000000","message":"Should this be `CBPTR` (not `CBSTR`)?","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1d1db6feec06b871547472f0f0d7ab45138cb245","unresolved":true,"context_lines":[{"line_number":2528,"context_line":"        else"},{"line_number":2529,"context_line":"#endif"},{"line_number":2530,"context_line":"        {"},{"line_number":2531,"context_line":"            sent \u003d send(man-\u003econnection.sd_cli, CBSTR(buf), len, MSG_NOSIGNAL);"},{"line_number":2532,"context_line":"        }"},{"line_number":2533,"context_line":"        if (sent \u003e\u003d 0)"},{"line_number":2534,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"89d8721a_c7b40780","line":2531,"in_reply_to":"922ac025_217c7d89","updated":"2026-09-11 10:40:10.000000000","message":"Windows wants a const char*, with CBPTR we get a warning\n\"pointer targets in passing argument 2 of ‘send’ differ in signedness (expected ‘const char *’ but argument is of type ‘const uint8_t *’)\" in MinGW build. Using CBSTR let\u0027s us avoid using a cast.","commit_id":"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c"}]}