)]}'
{"id":"openvpn~1904","triplet_id":"openvpn~master~Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-09-11 13:23:17.000000000","reason":"removed on reply"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-12 13:08:12.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-09-12 13:08:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e","subject":"buffer: When extracting pointers from buffer, retain const","status":"MERGED","created":"2026-09-07 21:03:55.000000000","updated":"2026-09-12 13:08:12.000000000","submitted":"2026-09-12 13:08:12.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":13,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1904-cppcheck","meta_rev_id":"81781cbdd50eef9c6249a4bc5a7e051597eab573","_number":1904,"virtual_id_number":1904,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-07 21:03:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-07 21:03:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-10 19:38:40.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"CC"},{"updated":"2026-09-11 13:23:17.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"5d01a52bdff696740987c9cffae47d2d6469bb97","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-07 21:03:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"faabd11936661d99c0e155372d70015e35f7506d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-08 11:51:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7be6d236355a9225cbeb459cdde2594f5338c253","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-10 19:38:40.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1d1db6feec06b871547472f0f0d7ab45138cb245","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 10:40:10.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"c855724ae1f433f6709eacd88e6530b0a66083a9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 11:49:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0eb44e7bc48a38f37b9d26a0ec7ce43f22aceee2","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 11:59:56.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"d54f30e9ee216b72696acd3707be12e196f23599","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 13:15:34.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7c893ce880f4a126884d67141b9d60bbb374f926","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 13:16:11.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"814a7b361a3e1c6c0bab2cbb1fa8c5de5a50f647","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-11 13:23:17.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"81781cbdd50eef9c6249a4bc5a7e051597eab573","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-12 13:08:12.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"e031978fd3e33b8f4b4e82d211c070b583e12b56","revisions":{"c3a39a4174522b5e37a428ef57c5f4c84fc52348":{"kind":"REWORK","_number":1,"created":"2026-09-07 21:03:55.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/04/1904/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1904/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/1 \u0026\u0026 git checkout -b change-1904 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/1904/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36f20d2bc0d9a6c5a5e3e7c3d302dcd653522451","subject":"management: Remove management argument to functions that do not need it"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 20:27:26.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 20:58:17.000000000","tz":120},"subject":"buffer: When extracting pointers from buffer, retain const","message":"buffer: When extracting pointers from buffer, retain const\n\nCurrently you can use BPTR and similar to implictly remove\nconst. That avoids some warnings that we should get and\nconfuses tools like cppcheck into giving wrong suggestions.\n\nSo make sure that by default we do not return a non-const\npointer if the buffer is not const. Change all call sites\nthat threw warnings.\n\nChange-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"65b938e40b3fd0ceed1bcfa6a12d35b5071e655c":{"kind":"REWORK","_number":2,"created":"2026-09-08 11:51:58.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/04/1904/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1904/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/2 \u0026\u0026 git checkout -b change-1904 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/1904/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"440c2a864a19eafe9affd31f95fbd546d1b0e8f9","subject":"management: Remove management argument to functions that do not need it"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 20:27:26.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-08 11:50:34.000000000","tz":120},"subject":"buffer: When extracting pointers from buffer, retain const","message":"buffer: When extracting pointers from buffer, retain const\n\nCurrently you can use BPTR and similar to implictly remove\nconst. That avoids some warnings that we should get and\nconfuses tools like cppcheck into giving wrong suggestions.\n\nSo make sure that by default we do not return a non-const\npointer if the buffer is not const. Change all call sites\nthat threw warnings.\n\nChange-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"cd975aa044ffd02f2dd16b2f954081d9f0099f8a":{"kind":"REWORK","_number":3,"created":"2026-09-11 11:49:27.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/04/1904/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1904/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/3 \u0026\u0026 git checkout -b change-1904 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/1904/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5c5d65d441b73c3fa30eb7d0151e89b2c04c8dad","subject":"management: Remove management argument to functions that do not need it"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 20:27:26.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 11:41:48.000000000","tz":120},"subject":"buffer: When extracting pointers from buffer, retain const","message":"buffer: When extracting pointers from buffer, retain const\n\nCurrently you can use BPTR and similar to implicitly remove\nconst. That avoids some warnings that we should get and\nconfuses tools like cppcheck into giving wrong suggestions.\n\nSo make sure that by default we only return a non-const\npointer if the buffer pointer is not const. Change all call\nsites that threw warnings.\n\nChange-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"8126032d14b9fbf864424f8c4982da147220beec":{"kind":"REWORK","_number":4,"created":"2026-09-11 13:15:34.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/04/1904/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1904/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/4 \u0026\u0026 git checkout -b change-1904 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/1904/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5c5d65d441b73c3fa30eb7d0151e89b2c04c8dad","subject":"management: Remove management argument to functions that do not need it"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-07 20:27:26.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 13:02:06.000000000","tz":120},"subject":"buffer: When extracting pointers from buffer, retain const","message":"buffer: When extracting pointers from buffer, retain const\n\nCurrently you can use BPTR and similar to implicitly remove\nconst. That avoids some warnings that we should get and\nconfuses tools like cppcheck into giving wrong suggestions.\n\nSo make sure that by default we only return a non-const\npointer if the buffer pointer is not const. Change all call\nsites that threw warnings.\n\nChange-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e031978fd3e33b8f4b4e82d211c070b583e12b56":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2026-09-12 13:08:12.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/04/1904/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1904/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/5 \u0026\u0026 git checkout -b change-1904 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/1904/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/1904/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e542754a8fc979e025e6d70186102b1934c1162d","subject":"cppcheck: Update suppressions for current master"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 20:45:07.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-12 12:35:17.000000000","tz":120},"subject":"buffer: When extracting pointers from buffer, retain const","message":"buffer: When extracting pointers from buffer, retain const\n\nCurrently you can use BPTR and similar to implicitly remove\nconst. That avoids some warnings that we should get and\nconfuses tools like cppcheck into giving wrong suggestions.\n\nSo make sure that by default we only return a non-const\npointer if the buffer pointer is not const. Change all call\nsites that threw warnings.\n\nChange-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1904\nMessage-Id: \u003c20260911204513.15692-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39108.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}