)]}'
{"id":"openvpn~1910","triplet_id":"openvpn~master~I8f2bd694146aacd244a1d385ddfe9bb84ec29334","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-13 09:26:49.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-09-13 09:26:49.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-09-13 09:26:49.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8f2bd694146aacd244a1d385ddfe9bb84ec29334","subject":"socket: factor out UDP socket creation and setup","status":"MERGED","created":"2026-09-11 08:18:16.000000000","updated":"2026-09-13 09:26:49.000000000","submitted":"2026-09-13 09:26:49.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1910","meta_rev_id":"00ed2af3bef59979c3080a78b10a19fa612d4869","_number":1910,"virtual_id_number":1910,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-11 08:18:23.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-11 08:18:23.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-11 13:55:48.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"state":"REVIEWER"}],"messages":[{"id":"df334bcab14116769d90e5217b1c0b8886ce59be","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-09-11 08:18:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"db6479e03ad4db02e5a6da95c2d9716ee30243af","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-09-11 09:11:03.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"2ee6dc08a81707facc902b092a0098019bfff820","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-11 13:55:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"21cb2660fe86bdb6955547fdf480962304839715","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-09-11 15:23:13.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b64ab1fd5ee4fea3475db59c29a9807eb1a09ab7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-09-12 07:08:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"00ed2af3bef59979c3080a78b10a19fa612d4869","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-13 09:26:49.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"af1f73dbe442b42b8a1addc614aa13c3485db266","revisions":{"eb930310fd92dc2ea9859800a975ead0c73960fe":{"kind":"REWORK","_number":1,"created":"2026-09-11 08:18:16.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/10/1910/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1910/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/1 \u0026\u0026 git checkout -b change-1910 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1910/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cce38c5f2703f7386944ddbdd8f4e962f94ffc95","subject":"oob: Add probe-result ranking for server selection"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-10 11:55:29.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-10 11:55:29.000000000","tz":180},"subject":"socket: factor out UDP socket creation and setup","message":"socket: factor out UDP socket creation and setup\n\ncreate_socket() creates the UDP socket and then applies the link\nsocket\u0027s options and local bind in place. Pull that sequence into\ncreate_socket_udp_configured(), taking the address family and the\noption values rather than a struct link_socket, and have create_socket()\ncall it; the TCP path keeps its own sequence through the shared\nsocket_apply_options().\n\n--server-probe will open its probe sockets through the same function, so\na probe socket is set up and bound exactly like the connection socket it\nmay later become. No behaviour change here.\n\nChange-Id: I8f2bd694146aacd244a1d385ddfe9bb84ec29334\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"91a8a065f47d169f28fa7d2b4b772126da5179e2":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-09-11 09:11:03.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/10/1910/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1910/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/2 \u0026\u0026 git checkout -b change-1910 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1910/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb8c5e1e123fa2e835c21f7486dbf5fb9131a380","subject":"oob: Add probe-result ranking for server selection"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-10 11:55:29.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-11 09:03:49.000000000","tz":180},"subject":"socket: factor out UDP socket creation and setup","message":"socket: factor out UDP socket creation and setup\n\ncreate_socket() creates the UDP socket and then applies the link\nsocket\u0027s options and local bind in place. Pull that sequence into\ncreate_socket_udp_configured(), taking the address family and the\noption values rather than a struct link_socket, and have create_socket()\ncall it; the TCP path keeps its own sequence through the shared\nsocket_apply_options().\n\n--server-probe will open its probe sockets through the same function, so\na probe socket is set up and bound exactly like the connection socket it\nmay later become. No behaviour change here.\n\nChange-Id: I8f2bd694146aacd244a1d385ddfe9bb84ec29334\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"14405c4b129ad134ba8847f7f8a2cd825bffa0fc":{"kind":"REWORK","_number":3,"created":"2026-09-11 15:23:13.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/10/1910/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1910/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/3 \u0026\u0026 git checkout -b change-1910 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1910/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc33d9e8dcc963889db83d71d209ea7573859095","subject":"oob: Add probe-result ranking for server selection"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-10 11:55:29.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-11 15:00:44.000000000","tz":180},"subject":"socket: factor out UDP socket creation and setup","message":"socket: factor out UDP socket creation and setup\n\ncreate_socket() creates the UDP socket and then applies the link\nsocket\u0027s options and local bind in place. Pull that sequence into\ncreate_socket_udp_configured(), taking the address family and the\noption values rather than a struct link_socket, and have create_socket()\ncall it; the TCP path keeps its own sequence through the shared\nsocket_apply_options().\n\n--server-probe will open its probe sockets through the same function, so\na probe socket is set up and bound exactly like the connection socket it\nmay later become. No behaviour change here.\n\nChange-Id: I8f2bd694146aacd244a1d385ddfe9bb84ec29334\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"533c4818d69234a3ba0542f56e50657cfdce6573":{"kind":"REWORK","_number":4,"created":"2026-09-12 07:08:46.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/10/1910/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1910/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/4 \u0026\u0026 git checkout -b change-1910 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1910/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc33d9e8dcc963889db83d71d209ea7573859095","subject":"oob: Add probe-result ranking for server selection"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-10 11:55:29.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-12 07:06:25.000000000","tz":180},"subject":"socket: factor out UDP socket creation and setup","message":"socket: factor out UDP socket creation and setup\n\ncreate_socket() creates the UDP socket and then applies the link\nsocket\u0027s options and local bind in place. Pull that sequence into\ncreate_socket_udp_configured(), taking the address family and the\noption values rather than a struct link_socket, and have create_socket()\ncall it; the TCP path keeps its own sequence through the shared\nsocket_apply_options().\n\n--server-probe will open its probe sockets through the same function, so\na probe socket is set up and bound exactly like the connection socket it\nmay later become. Its \"optional\" argument lets that caller treat a\nsocket the host cannot create as \"do not probe this address family\"\ninstead of dying; the connection path passes false and keeps the fatal\nerror. No behaviour change for existing callers.\n\nChange-Id: I8f2bd694146aacd244a1d385ddfe9bb84ec29334\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"af1f73dbe442b42b8a1addc614aa13c3485db266":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-09-13 09:26:49.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/10/1910/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1910/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/5 \u0026\u0026 git checkout -b change-1910 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1910/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1910/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cf02cd4f1190acb0ae934e8d6ed8d953fb4b0ddd","subject":"Fix various function parameters shadowing other symbols"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-09-12 09:29:12.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-12 20:13:36.000000000","tz":120},"subject":"socket: factor out UDP socket creation and setup","message":"socket: factor out UDP socket creation and setup\n\ncreate_socket() creates the UDP socket and then applies the link\nsocket\u0027s options and local bind in place. Pull that sequence into\ncreate_socket_udp_configured(), taking the address family and the\noption values rather than a struct link_socket, and have create_socket()\ncall it; the TCP path keeps its own sequence through the shared\nsocket_apply_options().\n\n--server-probe will open its probe sockets through the same function, so\na probe socket is set up and bound exactly like the connection socket it\nmay later become. Its \"optional\" argument lets that caller treat a\nsocket the host cannot create as \"do not probe this address family\"\ninstead of dying; the connection path passes false and keeps the fatal\nerror. No behaviour change for existing callers.\n\nChange-Id: I8f2bd694146aacd244a1d385ddfe9bb84ec29334\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1910\nMessage-Id: \u003c20260912092917.27218-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39126.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}