)]}'
{"id":"openvpn~1912","triplet_id":"openvpn~master~I0ac934da5eeed0424b54ed9b528a2bf2b561ffdf","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-12 17:36:03.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-09-12 17:36:03.000000000","reason":"Change was submitted"},"1000053":{"account":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-09-11 15:16:12.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I0ac934da5eeed0424b54ed9b528a2bf2b561ffdf","subject":"Fix various function parameters shadowing other symbols","status":"MERGED","created":"2026-09-11 11:49:27.000000000","updated":"2026-09-12 17:36:03.000000000","submitted":"2026-09-12 17:36:03.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1912-cppcheck","meta_rev_id":"6a5f62edbf0240580986c18e20aff324438cd65b","_number":1912,"virtual_id_number":1912,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-11 11:49:31.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-11 11:49:31.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-11 13:29:19.000000000","updated_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"CC"},{"updated":"2026-09-11 15:16:12.000000000","updated_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"39704e685a372f8ebf76e046c8cc176e24e48a32","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 11:49:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b8606d63ac20b6e9405048e9f8cd733afd93b5d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 13:15:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"18daba6116c4d2b1b0ac245067525d06bdd60198","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-11 13:29:19.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"255e37fa293f051ef379d5a09b4634121d5177fb","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-11 13:31:25.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7c911973da9493bde488b643f04d87ba10bb23ee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 15:08:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4e8ca0a76720786f690303af8aa607caf73402ec","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-11 15:09:48.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7dbcbb81c2400cf03c0ea94710c9970c46d9ed08","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-11 15:16:12.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"6a5f62edbf0240580986c18e20aff324438cd65b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-12 17:36:03.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"cf02cd4f1190acb0ae934e8d6ed8d953fb4b0ddd","revisions":{"6ac81027afd97865c3c692a5dc8d8a87dd1486d5":{"kind":"REWORK","_number":1,"created":"2026-09-11 11:49:27.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/12/1912/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/1912/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/1 \u0026\u0026 git checkout -b change-1912 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/12/1912/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8f98f0b457ea3e87bcf64a8b401fe81bb7d88a9c","subject":"Remove various useless assignments"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 11:34:26.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 11:48:18.000000000","tz":120},"subject":"Fix various function parameters shadowing other symbols","message":"Fix various function parameters shadowing other symbols\n\nUpdated to a newer version of cppcheck (2.21.0) and it\nreported a new group of issues where function parameters\nshadow global variables or function names.\n\nUsed a variety of different solutions depending on context,\neither renaming the global variables, the function parameters.\n\nIn one case I removed the parameter since it only cointained\nthe global variable anyway.\n\nWhere applicable I have combined the change with fixing\noccurrences of constParameterPointer to reduce conflicts\nbetween different cppcheck fix commits.\n\nChange-Id: I0ac934da5eeed0424b54ed9b528a2bf2b561ffdf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c674d3c37f1d589451feb45c760b2b63f4bae94a":{"kind":"REWORK","_number":2,"created":"2026-09-11 13:15:34.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/12/1912/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/1912/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/2 \u0026\u0026 git checkout -b change-1912 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/12/1912/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35aca022b11f9efa8a8f0f3eef5c632a9c52102b","subject":"Remove various useless assignments"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 11:34:26.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 13:06:53.000000000","tz":120},"subject":"Fix various function parameters shadowing other symbols","message":"Fix various function parameters shadowing other symbols\n\nUpdated to a newer version of cppcheck (2.21.0) and it\nreported a new group of issues where function parameters\nshadow global variables or function names.\n\nUsed a variety of different solutions depending on context,\neither renaming the global variables, the function parameters.\n\nIn one case I removed the parameter since it only cointained\nthe global variable anyway.\n\nWhere applicable I have combined the change with fixing\noccurrences of constParameterPointer to reduce conflicts\nbetween different cppcheck fix commits.\n\nChange-Id: I0ac934da5eeed0424b54ed9b528a2bf2b561ffdf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b32e3b58e898f1e19c1c5d49019db566c749b810":{"kind":"REWORK","_number":3,"created":"2026-09-11 15:08:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/12/1912/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/1912/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/3 \u0026\u0026 git checkout -b change-1912 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/12/1912/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35aca022b11f9efa8a8f0f3eef5c632a9c52102b","subject":"Remove various useless assignments"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 11:34:26.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 15:02:35.000000000","tz":120},"subject":"Fix various function parameters shadowing other symbols","message":"Fix various function parameters shadowing other symbols\n\nUpdated to a newer version of cppcheck (2.21.0) and it\nreported a new group of issues where function parameters\nshadow global variables or function names.\n\nUsed a variety of different solutions depending on context,\neither renaming the global variables or the function\nparameters.\n\nIn one case I removed the parameter since it only contained\nthe global variable anyway.\n\nWhere applicable I have combined the change with fixing\noccurrences of constParameterPointer to reduce conflicts\nbetween different cppcheck fix commits.\n\nChange-Id: I0ac934da5eeed0424b54ed9b528a2bf2b561ffdf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"cf02cd4f1190acb0ae934e8d6ed8d953fb4b0ddd":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-09-12 17:36:03.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/12/1912/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/1912/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/4 \u0026\u0026 git checkout -b change-1912 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/12/1912/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/1912/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e031978fd3e33b8f4b4e82d211c070b583e12b56","subject":"buffer: When extracting pointers from buffer, retain const"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-11 20:44:04.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-12 17:22:47.000000000","tz":120},"subject":"Fix various function parameters shadowing other symbols","message":"Fix various function parameters shadowing other symbols\n\nUpdated to a newer version of cppcheck (2.21.0) and it\nreported a new group of issues where function parameters\nshadow global variables or function names.\n\nUsed a variety of different solutions depending on context,\neither renaming the global variables or the function\nparameters.\n\nIn one case I removed the parameter since it only contained\nthe global variable anyway.\n\nWhere applicable I have combined the change with fixing\noccurrences of constParameterPointer to reduce conflicts\nbetween different cppcheck fix commits.\n\nChange-Id: I0ac934da5eeed0424b54ed9b528a2bf2b561ffdf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1912\nMessage-Id: \u003c20260911204411.15575-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39107.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}