)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"94e6dcd3b9921803c76cf03bed82e923ef7c6913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5d351a2_6980d933","updated":"2026-09-24 06:22:06.000000000","message":"The test only builds on Linux (see the currently failed BSD tests).","commit_id":"472d1fe901e0a0261fd0cf88801d08820cd201a6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"19b74e82524a2eec7d3ec9f62560bb339c7eee6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34c59f14_08066ac6","updated":"2026-09-28 10:17:59.000000000","message":"Please fix the builds","commit_id":"90dac0ff74b5023b593c7903d89f7c9210fbd403"}],"CMakeLists.txt":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0391f8d70069898849ce0e789119af3c8bbe157a","unresolved":true,"context_lines":[{"line_number":909,"context_line":"        src/openvpn/base64.c"},{"line_number":910,"context_line":"        )"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"    if (TARGET test_route)"},{"line_number":913,"context_line":"        target_link_libraries(test_route PUBLIC ${RESOLV_LIBRARIES})"},{"line_number":914,"context_line":"        target_sources(test_route PRIVATE"},{"line_number":915,"context_line":"            tests/unit_tests/openvpn/mock_get_random.c"}],"source_content_type":"text/x-cmake","patch_set":2,"id":"18d068a0_27a7fd53","line":912,"updated":"2026-09-25 09:43:31.000000000","message":"Instead adding a completely new test driver that only has three tests could you just add the new test_route.c to the test_networking target? \n\ntest_misc already does this with test_schedule if you need an example.","commit_id":"b5a04e7484242f1d3ac861ce929773c19fd58732"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"19b74e82524a2eec7d3ec9f62560bb339c7eee6a","unresolved":true,"context_lines":[{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    if (TARGET test_cryptoapi)"},{"line_number":946,"context_line":"        target_sources(test_cryptoapi PRIVATE"},{"line_number":947,"context_line":"            tests/unit_tests/openvpn/mock_get_random.c"},{"line_number":948,"context_line":"            tests/unit_tests/openvpn/cert_data.h"},{"line_number":949,"context_line":"            tests/unit_tests/openvpn/pkey_test_utils.c"},{"line_number":950,"context_line":"            src/openvpn/xkey_provider.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"f9b10e32_c8cea815","side":"PARENT","line":947,"updated":"2026-09-28 10:17:59.000000000","message":"breaks the windows builds","commit_id":"0cc99b10b4464bdeaa8c254f8388aeb241e8e8b6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"19b74e82524a2eec7d3ec9f62560bb339c7eee6a","unresolved":true,"context_lines":[{"line_number":1004,"context_line":"            -DSOFTHSM2_UTIL_PATH\u003d\\\"${SOFTHSM2_UTIL}\\\""},{"line_number":1005,"context_line":"            )"},{"line_number":1006,"context_line":"        target_sources(test_pkcs11 PRIVATE"},{"line_number":1007,"context_line":"            tests/unit_tests/openvpn/mock_get_random.c"},{"line_number":1008,"context_line":"            tests/unit_tests/openvpn/pkey_test_utils.c"},{"line_number":1009,"context_line":"            src/openvpn/argv.c"},{"line_number":1010,"context_line":"            src/openvpn/base64.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"7d4a99eb_c9821be4","side":"PARENT","line":1007,"updated":"2026-09-28 10:17:59.000000000","message":"Why was this removed? It broke the build.","commit_id":"0cc99b10b4464bdeaa8c254f8388aeb241e8e8b6"},{"author":{"_account_id":1000054,"name":"chugly","email":"charlie.vigue@openvpn.com","username":"chugly"},"change_message_id":"b42aee7ecbf8d5b2577b32bfe973774d2e3a8995","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        )"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    target_link_libraries(test_socket PUBLIC ${RESOLV_LIBRARIES})"},{"line_number":912,"context_line":"    target_sources(test_socket PRIVATE"},{"line_number":913,"context_line":"        tests/unit_tests/openvpn/mock_get_random.c"},{"line_number":914,"context_line":"        tests/unit_tests/openvpn/mock_management.c"},{"line_number":915,"context_line":"        tests/unit_tests/openvpn/mock_win32_execve.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"15ae40d6_e06c28ec","line":912,"in_reply_to":"18d068a0_27a7fd53","updated":"2026-09-28 07:41:03.000000000","message":"Done in PS3, though not quite the way test_misc does it. test_networking is not a cmocka driver: it has a main() that dispatches on argv and t_net.sh drives it by test number, so there is no CMUnitTest list to add to. The route tests are a numbered case instead, case 9, which runs cmocka_run_group_tests.\n\nt_net.sh runs the cases above LAST_AUTO_TEST after it has torn down its dummy interface, so bumping LAST_TEST to 9 gets them run there without needing an interface or any particular network state. They still run on their own, networking_testdriver 9, since they need no privileges.\n\nThis also drops the separate gating Razvan asked for on PS1, because networking_testdriver is already restricted to HAVE_SITNL and to Linux in CMake.","commit_id":"90dac0ff74b5023b593c7903d89f7c9210fbd403"}]}