)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"04ac50b36dddbb8c3e886cd6e3b319d86a8b4e44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d56aad8_112f894f","updated":"2026-09-25 15:33:44.000000000","message":"LGTM!","commit_id":"62781dc17328af91c589e6aa2b3c276188e2383a"}],"src/openvpn/multi.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"994a5f391c51ec85e668d141a698fe28ed52d39e","unresolved":true,"context_lines":[{"line_number":504,"context_line":"        {"},{"line_number":505,"context_line":"            return;"},{"line_number":506,"context_line":"        }"},{"line_number":507,"context_line":"    }"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    setenv_counter(c-\u003ec2.es, \"bytes_received\", c-\u003ec2.link_read_bytes + c-\u003ec2.dco_read_bytes);"},{"line_number":510,"context_line":"    setenv_counter(c-\u003ec2.es, \"bytes_sent\", c-\u003ec2.link_write_bytes + c-\u003ec2.dco_write_bytes);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"83aaef13_b354ec76","side":"PARENT","line":507,"updated":"2026-09-25 14:18:13.000000000","message":"Could removing this here end up with stale stats in some corner case? Would it be useful to still call this, but somewhere else (some \"global\" uninit function)?","commit_id":"235e8730afd06d8b6cd75d8422c2e64089d5ffbe"},{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"98c16f5407471a84f957d90a182068d2b11d413b","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        {"},{"line_number":505,"context_line":"            return;"},{"line_number":506,"context_line":"        }"},{"line_number":507,"context_line":"    }"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    setenv_counter(c-\u003ec2.es, \"bytes_received\", c-\u003ec2.link_read_bytes + c-\u003ec2.dco_read_bytes);"},{"line_number":510,"context_line":"    setenv_counter(c-\u003ec2.es, \"bytes_sent\", c-\u003ec2.link_write_bytes + c-\u003ec2.dco_write_bytes);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"948864fb_a0d685bb","side":"PARENT","line":507,"in_reply_to":"83aaef13_b354ec76","updated":"2026-09-25 15:16:22.000000000","message":"Yes this was a real regression. Fixed by calling dco_get_peer_stats_multi in multi_uninit.","commit_id":"235e8730afd06d8b6cd75d8422c2e64089d5ffbe"},{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"b39bc99b43854508bc196b94037b14301ee561e1","unresolved":true,"context_lines":[{"line_number":503,"context_line":"}"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"static void"},{"line_number":506,"context_line":"multi_client_disconnect_setenv(struct multi_context *m, struct multi_instance *mi)"},{"line_number":507,"context_line":"{"},{"line_number":508,"context_line":"    /* setenv client real IP address */"},{"line_number":509,"context_line":"    setenv_trusted(mi-\u003econtext.c2.es, get_link_socket_info(\u0026mi-\u003econtext));"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5e6f5069_77e37c9b","line":506,"updated":"2026-09-25 14:05:22.000000000","message":"you should remove *m from the param list too. Also check the caller to see if this param con go there too.","commit_id":"5655c770a96630ceb381007087759de61afc87ae"},{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"98c16f5407471a84f957d90a182068d2b11d413b","unresolved":false,"context_lines":[{"line_number":503,"context_line":"}"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"static void"},{"line_number":506,"context_line":"multi_client_disconnect_setenv(struct multi_context *m, struct multi_instance *mi)"},{"line_number":507,"context_line":"{"},{"line_number":508,"context_line":"    /* setenv client real IP address */"},{"line_number":509,"context_line":"    setenv_trusted(mi-\u003econtext.c2.es, get_link_socket_info(\u0026mi-\u003econtext));"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f2b618b0_6d782ed9","line":506,"in_reply_to":"5e6f5069_77e37c9b","updated":"2026-09-25 15:16:22.000000000","message":"wiped it out!","commit_id":"5655c770a96630ceb381007087759de61afc87ae"}]}