)]}'
{"id":"openvpn~1952","triplet_id":"openvpn~master~Ic535bb1f0da1739f87e9d6bef6fd1061247b05de","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000041":{"account":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-09-28 12:14:15.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-09-26 18:56:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-09-25 15:33:44.000000000","reason":"\u003cGERRIT_ACCOUNT_1000053\u003e replied on the change","reason_account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-28 12:14:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic535bb1f0da1739f87e9d6bef6fd1061247b05de","subject":"dco: stop fetching peer stats during client disconnect","status":"MERGED","created":"2026-09-25 13:52:16.000000000","updated":"2026-09-28 12:14:15.000000000","submitted":"2026-09-28 12:14:15.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1952","meta_rev_id":"0a32cfe003b0bd310d9eaaf92cd39dadaa66a718","_number":1952,"virtual_id_number":1952,"owner":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-25 13:52:16.000000000","updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-25 13:52:16.000000000","updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-25 14:05:22.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2026-09-25 14:18:13.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"CC"},{"updated":"2026-09-25 15:33:44.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"704b0d9ef2302ab84d02b20e5eefc3304aa68b9a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-25 13:52:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b39bc99b43854508bc196b94037b14301ee561e1","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-25 14:05:22.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"994a5f391c51ec85e668d141a698fe28ed52d39e","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-25 14:18:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4a8faf4885f0075d0b2c5a2d2a7eb54d1b50de78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-25 15:12:21.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"98c16f5407471a84f957d90a182068d2b11d413b","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-25 15:16:22.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"04ac50b36dddbb8c3e886cd6e3b319d86a8b4e44","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-25 15:33:44.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b429b448aade161b04bb1d3afbb86e154fbd69d3","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-26 18:56:51.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0a32cfe003b0bd310d9eaaf92cd39dadaa66a718","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-28 12:14:15.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"459fcbb252b9c9781d2807f4d44dbfd758a26afa","revisions":{"5655c770a96630ceb381007087759de61afc87ae":{"kind":"REWORK","_number":1,"created":"2026-09-25 13:52:16.000000000","uploader":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/52/1952/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/1952/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/1 \u0026\u0026 git checkout -b change-1952 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/52/1952/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"235e8730afd06d8b6cd75d8422c2e64089d5ffbe","subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-09-25 10:57:11.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-09-25 13:50:11.000000000","tz":120},"subject":"dco: stop fetching peer stats during client disconnect","message":"dco: stop fetching peer stats during client disconnect\n\nThe disconnect path asks DCO for a fresh peer dump after the multi\ninstance has already been removed from the peer-id lookup table. For\nkernel-initiated disconnects, the peer has also already been deleted by\nthe time its notification is processed. The reply therefore cannot\nupdate the disconnecting instance.\n\nMoreover, each disconnect dumps all surviving peers, causing avoidable\nnetlink traffic and repeated work when many clients disconnect at once.\n\nUse the cached counters directly. Kernels that provide a final\nstatistics snapshot in the deletion notification can update them before\nthe disconnect environment is prepared.\n\nChange-Id: Ic535bb1f0da1739f87e9d6bef6fd1061247b05de\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"62781dc17328af91c589e6aa2b3c276188e2383a":{"kind":"REWORK","_number":2,"created":"2026-09-25 15:12:21.000000000","uploader":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/52/1952/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/1952/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/2 \u0026\u0026 git checkout -b change-1952 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/52/1952/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"235e8730afd06d8b6cd75d8422c2e64089d5ffbe","subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-09-25 10:57:11.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-09-25 15:12:13.000000000","tz":120},"subject":"dco: stop fetching peer stats during client disconnect","message":"dco: stop fetching peer stats during client disconnect\n\nThe disconnect path asks DCO for a fresh peer dump after the multi\ninstance has already been removed from the peer-id lookup table. For\nkernel-initiated disconnects, the peer has also already been deleted by\nthe time its notification is processed. The reply therefore cannot\nupdate the disconnecting instance.\n\nMoreover, each disconnect dumps all surviving peers, causing avoidable\nnetlink traffic and repeated work when many clients disconnect at once.\n\nDuring shutdown or restart, fetch a single final peer snapshot before\nclosing any instances, while all peers can still be mapped to their\nuserspace contexts.\n\nFor individual disconnects, use the cached counters directly. Kernels\nthat provide a final statistics snapshot in the deletion notification\ncan update them before the disconnect environment is prepared.\n\nChange-Id: Ic535bb1f0da1739f87e9d6bef6fd1061247b05de\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"459fcbb252b9c9781d2807f4d44dbfd758a26afa":{"kind":"REWORK","_number":3,"created":"2026-09-28 12:14:15.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/52/1952/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/1952/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/3 \u0026\u0026 git checkout -b change-1952 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/52/1952/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/1952/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0702ff8e2945f8615f67c0dfc03e5a013567b3f8","subject":"buffer: make buf_valid() and buf_defined() NULL-safe"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-09-26 20:09:51.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-28 11:06:59.000000000","tz":120},"subject":"dco: stop fetching peer stats during client disconnect","message":"dco: stop fetching peer stats during client disconnect\n\nThe disconnect path asks DCO for a fresh peer dump after the multi\ninstance has already been removed from the peer-id lookup table. For\nkernel-initiated disconnects, the peer has also already been deleted by\nthe time its notification is processed. The reply therefore cannot\nupdate the disconnecting instance.\n\nMoreover, each disconnect dumps all surviving peers, causing avoidable\nnetlink traffic and repeated work when many clients disconnect at once.\n\nDuring shutdown or restart, fetch a single final peer snapshot before\nclosing any instances, while all peers can still be mapped to their\nuserspace contexts.\n\nFor individual disconnects, use the cached counters directly. Kernels\nthat provide a final statistics snapshot in the deletion notification\ncan update them before the disconnect environment is prepared.\n\nChange-Id: Ic535bb1f0da1739f87e9d6bef6fd1061247b05de\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1952\nMessage-Id: \u003c20260926200956.24545-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39533.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}