)]}'
{"id":"openvpn~1953","triplet_id":"openvpn~master~Ie06d3543d0a5d4ca3d3fd6f41498e6917ab4c8a9","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-26 08:18:47.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-09-26 08:18:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie06d3543d0a5d4ca3d3fd6f41498e6917ab4c8a9","subject":"cppcheck: Clean up suppressions to not annoy developers","status":"MERGED","created":"2026-09-25 16:09:37.000000000","updated":"2026-09-26 08:18:47.000000000","submitted":"2026-09-26 08:18:47.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1953-cppcheck","meta_rev_id":"9362d913241197257432d62f102ff994c61c40b7","_number":1953,"virtual_id_number":1953,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-25 16:09:37.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-25 16:09:37.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-25 17:45:59.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"5ecc30c5df22be5f9feafec5539342ae303ad9b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-25 16:09:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a85d9aaea9827d5f3bdbab60fb68febd638259bb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-25 16:10:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8e9a81f6d0891ccb3cf7be9831274d90caab36c5","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-25 17:45:59.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9362d913241197257432d62f102ff994c61c40b7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-26 08:18:47.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"060b9ebd1460600803d49abed990ab5f71b72395","revisions":{"a1f82017c677cf00f14e74693be1435fcea8a6cd":{"kind":"REWORK","_number":1,"created":"2026-09-25 16:09:37.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/53/1953/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1953/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/1 \u0026\u0026 git checkout -b change-1953 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/53/1953/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0cc99b10b4464bdeaa8c254f8388aeb241e8e8b6","subject":"GHA: Maintenance update September 2026"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-25 16:02:36.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-25 16:08:45.000000000","tz":120},"subject":"cppcheck: Clean up suppressions to not annoy developers","message":"cppcheck: Clean up suppressions to not annoy developers\n\nActually using it in CI has shown that the line number\nbased suppression is just too annoying. Therefor:\n\n- Switch to XML based suppressions that allow us to\n  use symbolName in addition to lineNumber to limit the\n  suppression.\n- Suppress knownConditionTrueFalse always. There are just\n  too many instances due to how our code is structured.\n- Also remove some unused suppressions.\n- Replace some suppressions with code fixes. These are\n  generally speaking false positives but the code fix\n  is less ugly than the suppression.\n- Work around one issue with using PRIx64 macro in a\n  pre-prepared format string by adding a definition in\n  our library definition.\n- All suppressions that remain that were still lineNumber\n  based (due to the check not reporting a symbol), move\n  to inline suppressions. Inline suppressions are somewhat\n  ugly, but these are very few and I see no better\n  alternative. Maybe we can get rid of some of them by\n  reporting issues to cppcheck. (Or, in some cases, by\n  improving our code).\n\nWhile here, make sure that we always run the Windows scan\nas well, so developers get complete feedback on first push.\n\nChange-Id: Ie06d3543d0a5d4ca3d3fd6f41498e6917ab4c8a9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3262f93a6a2b812f996b2686ad87b5d993cbfb1b":{"kind":"REWORK","_number":2,"created":"2026-09-25 16:10:58.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/53/1953/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1953/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/2 \u0026\u0026 git checkout -b change-1953 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/53/1953/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"67e6faa4496ff6fedc9297faf78d8cd4646a0b4b","subject":"multi: make multi_add_mbuf static"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-25 16:02:36.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-25 16:10:43.000000000","tz":120},"subject":"cppcheck: Clean up suppressions to not annoy developers","message":"cppcheck: Clean up suppressions to not annoy developers\n\nActually using it in CI has shown that the line number\nbased suppression is just too annoying. Therefor:\n\n- Switch to XML based suppressions that allow us to\n  use symbolName in addition to lineNumber to limit the\n  suppression.\n- Suppress knownConditionTrueFalse always. There are just\n  too many instances due to how our code is structured.\n- Also remove some unused suppressions.\n- Replace some suppressions with code fixes. These are\n  generally speaking false positives but the code fix\n  is less ugly than the suppression.\n- Work around one issue with using PRIx64 macro in a\n  pre-prepared format string by adding a definition in\n  our library definition.\n- All suppressions that remain that were still lineNumber\n  based (due to the check not reporting a symbol), move\n  to inline suppressions. Inline suppressions are somewhat\n  ugly, but these are very few and I see no better\n  alternative. Maybe we can get rid of some of them by\n  reporting issues to cppcheck. (Or, in some cases, by\n  improving our code).\n\nWhile here, make sure that we always run the Windows scan\nas well, so developers get complete feedback on first push.\n\nChange-Id: Ie06d3543d0a5d4ca3d3fd6f41498e6917ab4c8a9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"060b9ebd1460600803d49abed990ab5f71b72395":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-09-26 08:18:47.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/53/1953/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1953/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/3 \u0026\u0026 git checkout -b change-1953 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/53/1953/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/53/1953/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e6670b335b99bed5810cf2d0465279e208d14462","subject":"dco_linux: drop the now-redundant __is_locked re-entrancy guard"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-25 21:31:12.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-26 08:16:19.000000000","tz":120},"subject":"cppcheck: Clean up suppressions to not annoy developers","message":"cppcheck: Clean up suppressions to not annoy developers\n\nActually using it in CI has shown that the line number\nbased suppression is just too annoying. Therefor:\n\n- Switch to XML based suppressions that allow us to\n  use symbolName in addition to lineNumber to limit the\n  suppression.\n- Suppress knownConditionTrueFalse always. There are just\n  too many instances due to how our code is structured.\n- Also remove some unused suppressions.\n- Replace some suppressions with code fixes. These are\n  generally speaking false positives but the code fix\n  is less ugly than the suppression.\n- Work around one issue with using PRIx64 macro in a\n  pre-prepared format string by adding a definition in\n  our library definition.\n- All suppressions that remain that were still lineNumber\n  based (due to the check not reporting a symbol), move\n  to inline suppressions. Inline suppressions are somewhat\n  ugly, but these are very few and I see no better\n  alternative. Maybe we can get rid of some of them by\n  reporting issues to cppcheck. (Or, in some cases, by\n  improving our code).\n\nWhile here, make sure that we always run the Windows scan\nas well, so developers get complete feedback on first push.\n\nChange-Id: Ie06d3543d0a5d4ca3d3fd6f41498e6917ab4c8a9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1953\nMessage-Id: \u003c20260925213118.29507-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39523.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}